Sergey Biryukov
2dcbf39e2d
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/options.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33863 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:30:58 +00:00
Sergey Biryukov
31caf44a24
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/nav-menus.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33862 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:20:53 +00:00
Sergey Biryukov
50224510ec
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:14:14 +00:00
Sergey Biryukov
0299c00fbb
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33860 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:03:10 +00:00
Sergey Biryukov
a505ad3382
Set svn:eol-style for the files added in [32806].
...
see #32576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33859 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:54:13 +00:00
John Blackbourn
65c7f9113d
Correctly encode spaces in URLs passed to esc_url()
instead of removing them.
...
Fixes #23605
Props enshrined, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@33858 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:19:29 +00:00
Sergey Biryukov
1ec4b77ac2
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33857 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:05:01 +00:00
Andrea Fercia
2ffd8b52cf
Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].
...
Fixes #33633 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33856 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:55:46 +00:00
John Blackbourn
f34a386916
More unit tests for esc_url()
and esc_url_raw()
.
...
See #23605 , #20771 , #16859
git-svn-id: https://develop.svn.wordpress.org/trunk@33855 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:50:02 +00:00
Sergey Biryukov
22919f8150
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:28:18 +00:00
Sergey Biryukov
1efad51200
Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:20:46 +00:00
Sergey Biryukov
029964a5ed
Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:05:07 +00:00
John Blackbourn
4720c6e482
Add some more passing unit tests for esc_url()
in preparation for upcoming changes.
...
See #23605 , #20771 , #16859
git-svn-id: https://develop.svn.wordpress.org/trunk@33851 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 14:19:21 +00:00
Boone Gorges
7232be7dcd
Remove #
from @ticket
annotation in a unit test.
...
This improper character was erroneously introduced in [33724].
Props netweb.
Fixes #33532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33850 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 13:39:05 +00:00
John Blackbourn
46c336e78a
Introduce wp_removable_query_args()
, which returns an array of single-use query variables which can be removed from a URL.
...
Also applies the function to the return URL when the Customizer is closed.
Fixes #32692
Props swissspidy, Mte90
git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
Jeremy Felt
4d2dbebb35
Multisite: Remove duplicate span element output from row actions
...
Fixes #32961 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:50:33 +00:00
DrewAPicture
62230a38e1
Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set()
.
...
Props racase for the initial patch.
Fixes #33652 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33847 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:46:02 +00:00
Scott Taylor
42dcb586ee
After [33807], fix unit tests for PHP 5.2
...
Fixes #17626 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33846 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 17:03:13 +00:00
Scott Taylor
a3e0e719d6
De-Jorbin [33814].
...
See #23012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33845 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 15:47:16 +00:00
Sergey Biryukov
622032fece
Make curly quotes in playlist item title translatable.
...
fixes #33391 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:57 +00:00
Scott Taylor
1e084b6eaa
Move widget classes to their own files in wp-includes/widgets
:
...
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded`
See #33413 , #23012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33843 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:00 +00:00
Sergey Biryukov
cfff91526f
Merge two similar strings.
...
props pavelevap.
fixes #33643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33842 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:45:15 +00:00
Scott Taylor
f6ab99bc68
Add some JS docs to customize-base.js
...
Props ericlewis.
Fixes #33639 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33841 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 04:14:50 +00:00
Scott Taylor
99c34d57c1
User Settings: allow dashes in get|set_user_setting()
in PHP and get|setUserSetting()
in JS.
...
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.
Fixes #22781 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33840 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:56:44 +00:00
Sergey Biryukov
3710226cf4
Correct @since
version for [33838].
...
props JustinSainton.
see #23692 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33839 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:13:27 +00:00
Sergey Biryukov
357bd80a0b
Add filters to feed_links()
to choose whether to display the links to posts feed and comments feed, separately.
...
props joostdevalk, juliobox.
fixes #23692 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33838 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 02:45:58 +00:00
Weston Ruter
57a7ed15a7
Customizer: Collapse any expanded panel/sections before expanding other panel/sections
...
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.
Props celloexpressions, westonruter.
Fixes #33396 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:57 +00:00
Andrew Ozz
43d053318e
Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
...
Fixes #23691 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33836 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:36 +00:00
Andrew Ozz
0807da1bdd
TinyMCE: disable the native fullscreen plugin on mobile devices by default.
...
Props iseulde. Fixes #33137 ;
git-svn-id: https://develop.svn.wordpress.org/trunk@33835 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:44:40 +00:00
Andrew Ozz
9c90fe1198
TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content.
...
Fixes #33477 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33834 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:06:11 +00:00
Sergey Biryukov
79907af59c
Add 'dashboard_secondary_items'
filter for the number of secondary link items in the 'WordPress News' dashboard widget.
...
props MikeHansenMe, DrewAPicture.
fixes #31434 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:56:50 +00:00
SergeyBiryukov
f0ab8b5a06
Add 'update_right_now_text'
filter for the text displayed in the 'At a Glance' dashboard widget.
...
props obenland.
fixes #33355 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:44:02 +00:00
John Blackbourn
e5eec20a25
Space out.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33831 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:24:27 +00:00
Drew Jaynes
f7507e511d
Docs: Add a duplicate filter comment to the comment_email
filter call in WP_Comments_List_Table
, introduced in [33829].
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:21:14 +00:00
Scott Taylor
e10c682b83
Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link()
, the internals can be simplified and applied inline.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:08:17 +00:00
Scott Taylor
fef8794b2c
Fix warnings after [33826]. Only only one function call needs a global $comment
, we shall hamburger it.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:58:12 +00:00
Drew Jaynes
f995a3cb96
Docs: Clarify the DocBlock summary for wp_create_nonce()
to mention that nonce-creation is also now dependent on user tokens, as of [29221].
...
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.
Props ericlewis
Fixes #33636 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33827 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:49:49 +00:00
Scott Taylor
0f59069a7f
WP_Comments_List_Table::single_row()
has no reason to set the $comment
global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment()
elsewhere, since get_comment()
internally bypasses the cache/db when a global is set.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:41:09 +00:00
Sergey Biryukov
20767f42aa
Use wp_html_excerpt()
to properly cut comment author URL for display on Comments screen.
...
props brettz95, solarissmoke.
fixes #15659 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:40:28 +00:00
Scott Taylor
49923580bd
WP_Widget_Pages::widget()
has no reason to set $comment
and $comments
globals.
...
See #11566 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33824 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:30:32 +00:00
Scott Taylor
48ae1fcc1d
After [33822], really add those unit tests for wp_count_comments()
.
...
See #19903 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33823 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 18:51:00 +00:00
Scott Taylor
3028a096be
Comments: wp_count_comments()
can use get_comment_count()
internally to makes its DB query, provided that get_comment_count()
returns more properties.
...
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.
Fixes #19903 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33822 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 18:50:12 +00:00
Scott Taylor
af101dec19
Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
...
Fixes #33414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 17:57:32 +00:00
Sergey Biryukov
ff7e86d14c
Bump H3 headings to H2 on Themes screen for better accessibility.
...
props joehills.
fixes #33560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:50:05 +00:00
Sergey Biryukov
0de0c060c1
Bump H3 headings to H2 on Tools screen for better accessibility.
...
props Cheffheid.
fixes #33607 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:31:38 +00:00
Sergey Biryukov
77b54f319d
Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
...
props Cheffheid.
fixes #33611 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:28:32 +00:00
Sergey Biryukov
7f3b90bc77
Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
...
props Cheffheid.
fixes #33559 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:25:27 +00:00
Drew Jaynes
8aefa21974
Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard:
...
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant
See #33413
git-svn-id: https://develop.svn.wordpress.org/trunk@33816 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 23:13:45 +00:00
Konstantin Obenland
903b9af181
Themes: Get the correct theme when template and stylesheet were both passed as arguments.
...
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.
Introduced in [21131].
Props obenland, wonderboymusic.
Fixes #32635 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33815 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 21:44:38 +00:00
Scott Taylor
e3a3ba4caa
Improve/update escaping in default widgets:
...
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs
Props welcher.
See #23012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33814 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 05:37:53 +00:00