Commit Graph

31067 Commits

Author SHA1 Message Date
Scott Taylor 3484a266a1 Bump H3 headings to H2 on the Media Settings screen for better accessibility.
Props metodiew.
Fixes #33610.


git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:11:24 +00:00
Scott Taylor 32d296fb6a Bump H3 headings to H2 on Export screen for better accessibility.
Props metodiew.
Fixes #33608.


git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:08:29 +00:00
Scott Taylor 23f2e79350 Correct the param docs for `comment_guid()` and `get_comment_guid()`.
Props dimadin.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:59:10 +00:00
Scott Taylor b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00
Scott Taylor 38038ccba3 Add Customizer docs.
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:52:17 +00:00
Scott Taylor 26dd8b5b08 Allow `wp_insert_post()` to accept a `meta_input` argument. Devs should use `register_meta()` to ensure that specific values specified by key are sanitized properly.
Adds unit test.

Props CoenJacobs, swissspidy.
Fixes #20451.


git-svn-id: https://develop.svn.wordpress.org/trunk@33910 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:49:53 +00:00
Andrea Fercia 7b3b1c12d5 Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens.
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.

git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 18:29:40 +00:00
Sergey Biryukov 36ed764d60 Fix closing div in `wp_print_request_filesystem_credentials_modal()`.
Props trepmal.
Fixes #33737.

git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 15:16:15 +00:00
Sergey Biryukov dde7dc7145 Update `Tests_Sanitize_Option::test_sanitize_option()` after [33858].
See #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33907 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 14:17:24 +00:00
Sergey Biryukov b0d3f5922e Update `Tests_Admin_includesPlugin::test_menu_page_url()` after [33858].
See #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33906 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 14:15:51 +00:00
Sergey Biryukov b09823a1d3 Update `Tests_Formatting_GetUrlInContent::get_input_output()` after [33858].
Props gitlost.
Fixes #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33905 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 14:05:05 +00:00
Boone Gorges 3fba46b557 Allow `wp_terms_checklist()` to return markup rather than echoing it.
Props kevinlangleyjr.
Fixes #33720.

git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 21:24:04 +00:00
Boone Gorges 9dfc5551ee In `get_terms()`, allow terms to be ordered by 'term_id'.
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.

git-svn-id: https://develop.svn.wordpress.org/trunk@33903 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 21:16:11 +00:00
Sergey Biryukov dfceba6d05 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`.
fixes #33685. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 03:39:33 +00:00
Drew Jaynes 9f5b896fac Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33901 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:51:08 +00:00
Drew Jaynes a767e01f17 Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API.
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33900 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:46:29 +00:00
Drew Jaynes 3abc0933bb Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33899 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:41:17 +00:00
Drew Jaynes d615705cec Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750].
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33898 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:37:23 +00:00
Drew Jaynes 8cc0808e3b Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:32:59 +00:00
Drew Jaynes 68f62a46e5 Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33896 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:28:10 +00:00
Drew Jaynes 8b3693c9e0 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749].
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33895 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:25:56 +00:00
Scott Taylor 43c8ec5f32 Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table.
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 23:22:32 +00:00
Drew Jaynes 46af2b9cd9 Docs: Add complete file, class, property, and method documentation for the new `WP_Comment` class, introduced in [33891].
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 19:57:15 +00:00
Sergey Biryukov 2487080654 Add missing translation functions to the error messages added in [33889].
props kraftbj, GaryJ.
fixes #33684.

git-svn-id: https://develop.svn.wordpress.org/trunk@33892 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:36:22 +00:00
Scott Taylor 60ba8b05e4 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:16:35 +00:00
Helen Hou-Sandi 52f31a77e9 UI: Restrict textarea resizing to vertical to prevent ugliness.
props tyxla, MatheusFD.
fixes #33400.


git-svn-id: https://develop.svn.wordpress.org/trunk@33890 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:04:27 +00:00
Sergey Biryukov 71d4444ac7 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-includes/class-wp-customize-manager.php`.
props kraftbj.
fixes #33684. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33889 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 09:20:40 +00:00
Sergey Biryukov 55bb26c58a Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33888 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 09:02:13 +00:00
Sergey Biryukov 7c32770901 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33887 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:58:34 +00:00
Sergey Biryukov 190561b89d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33886 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:55:53 +00:00
Sergey Biryukov 708cd13d77 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/users.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33885 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:53:23 +00:00
Sergey Biryukov e7beccf78c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33884 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:44:37 +00:00
Drew Jaynes 03a85947ef Docs: Add inline DocBlocks for the `require_once()` calls that now bring in top-level HTTP API functionality and HTTP API classes.
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33882 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:46:27 +00:00
Drew Jaynes febec2128e Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33881 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:40:45 +00:00
Drew Jaynes 77a4ee7659 Docs: Add a missing file header for wp-includes/class-http.php.
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33880 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:38:45 +00:00
Drew Jaynes 76f63a3b47 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748].
Also removes now-moot extra information from the file header description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33879 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:36:24 +00:00
Drew Jaynes 608957f426 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33878 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:32:54 +00:00
Drew Jaynes 572a9fa86b Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33876 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:29:39 +00:00
Drew Jaynes 81e8cc3d7e Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33875 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:27:04 +00:00
Drew Jaynes 069668dde9 Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33874 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:22:15 +00:00
Drew Jaynes b0ea6406a8 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748].
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33873 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:18:20 +00:00
Drew Jaynes fba0e92dc6 Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API.
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33872 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:13:20 +00:00
Drew Jaynes 50d0b587f6 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33871 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:57:10 +00:00
Drew Jaynes f70c0d7080 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33870 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:53:19 +00:00
Drew Jaynes 4c5276edcf Docs: Improve the file header for class-wp-widget.php to describe what the file contains.
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33869 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:49:39 +00:00
Drew Jaynes b75e5cdfd8 Docs: Add a missing summary to the DocBlock for `Walker::get_number_of_root_elements()`.
Props wen-solutions
See #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33868 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 19:50:32 +00:00
Scott Taylor 4b9ccd27b1 After [33723], ensure that `$i` is properly set before looping.
See #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33867 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:47:51 +00:00
Sergey Biryukov 5cf9c22518 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33866 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:44:07 +00:00
Sergey Biryukov 45237109dc Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33865 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:37:28 +00:00
Sergey Biryukov 89fca37568 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33864 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:35:05 +00:00