sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,339 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

7843 Commits

Author SHA1 Message Date
Scott Taylor ad163d3547 In `get_page_uri()`, do not add parent slugs to orphaned pages. 
Adds unit test.

Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34001 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:53:52 +00:00
Scott Taylor 2deb9565c0 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:46:38 +00:00
Jeremy Felt 9473a479d9 Multisite: Correct `ms_not_installed()` `@since` version for new parameters 
Props dimadin.
See 27264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33999 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:20:29 +00:00
Sergey Biryukov 5d8eb77621 Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.

git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 10:58:58 +00:00
Jeremy Felt 837b6c3e3e Multisite: Add action to handle network not found 
`ms_network_not_found` fires when the global `$current_site` has not been filled and `ms_not_installed()` is about to fire. It cannot be used to populate `$current_site`, but can be used to capture the request and redirect or present a custom error.

Props rmccue.
Fixes #31702.


git-svn-id: https://develop.svn.wordpress.org/trunk@33990 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 05:05:14 +00:00
Jeremy Felt d0706ac9ca Multisite: Remove `$domain` and `$path` globals in `ms_not_installed()` 
Further reduces the reliance on these unnecessary globals.

Fixes #27264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33989 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:52:21 +00:00
Jeremy Felt ef1f697564 Multisite: Allow users with `manage_network_users` to edit network users. 
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.

* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.

Props daniellandau, chriscct7.
Fixes #16860.


git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:33:22 +00:00
Scott Taylor a025ce4f12 After the `global` churn in [33964], also set `$post` to `null` at the end of `WP_Comments_List_Table::single_row()` to ensure that an orphaned comment doesn't inherit the previous row's `$post` context. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33986 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:11:09 +00:00
Scott Taylor 6bc498c0e6 Implement a priority system for Help Tabs to add them at specific positions. 
Adds unit tests.

Props swissspidy.
Fixes #19828.


git-svn-id: https://develop.svn.wordpress.org/trunk@33985 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:26:26 +00:00
Scott Taylor 89f4c471fa Add `@access` docs to `class-wp-filesystem-*` files. 
Props wenthemes.
Fixes #33725.


git-svn-id: https://develop.svn.wordpress.org/trunk@33984 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:20:58 +00:00
Scott Taylor c5220e43f5 Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition. 
Props swissspidy.
Fixes #26494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33983 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:10:25 +00:00
Scott Taylor c83106d13f After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc). 
See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33982 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:02:05 +00:00
Andrew Ozz cc18f258cb TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1. 
Fixes #33782 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33981 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 19:44:09 +00:00
Drew Jaynes 81ec5c8e91 Docs: Add a changelog entry to the DocBlock for `touch_time()` to mention the shift from accessing the global `$comment` to using `get_comment()`. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 15:47:43 +00:00
Drew Jaynes d651587a0d Docs: Use the `$widget_links_args` parameter in the hook doc for the `widget_links_args` filter, introduced when the args array was split out to a variable in [33971]. 
See #20788.


git-svn-id: https://develop.svn.wordpress.org/trunk@33978 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 15:44:46 +00:00
Scott Taylor ab9bbfa9ce `WP_Widget_Links`: pass widget instance to `widget_links_args` filter 
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788.


git-svn-id: https://develop.svn.wordpress.org/trunk@33971 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 04:41:21 +00:00
Scott Taylor d6e73d47e4 Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 04:38:31 +00:00
Scott Taylor 9eefbd1999 Deprecate `wp_get_http()` - function isn't used anywhere (apart from itself). 
Props swissspidy.
Fixes #33709.


git-svn-id: https://develop.svn.wordpress.org/trunk@33969 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 04:25:24 +00:00
Scott Taylor 4016b77b1a Add a parameter, `$post`, to `get_{$adjacent}_post_join`, `get_{$adjacent}_post_where`, and `get_{$adjacent}_post_sort` 
Props JustinSainton.
Fixes #24597.


git-svn-id: https://develop.svn.wordpress.org/trunk@33968 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:49:00 +00:00
Scott Taylor 05e249d5ac Ensure that `role` is not empty before adding it in `add_role()` function and methods. 
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746.


git-svn-id: https://develop.svn.wordpress.org/trunk@33967 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:41:27 +00:00
Scott Taylor 047f3ef01a Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types. 
Props lancewillett, adamsilverstein.
Fixes #31910.


git-svn-id: https://develop.svn.wordpress.org/trunk@33966 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:22:36 +00:00
Scott Taylor 42e8258275 Use `get_comment()` instead of a global in `touch_time()`. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:04:38 +00:00
Scott Taylor df637648e2 In `WP_Comments_List_Table`, favor passing `WP_Comment` instances instead of `$comment_ID` to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:59:54 +00:00
Scott Taylor 38d374ab01 After [33891], `get_comment()` returns `global $comment` if no args are passed and the global is set (after setting the default to `null` here). This allows us to ditch global comment imports. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:50:43 +00:00
Scott Taylor 8088ffafd6 `Walker_Comment` should be in its own file. Loaded now via `wp-includes/comment.php`, which makes it 100% BC. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33962 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:40:53 +00:00
Scott Taylor 95247e5bd8 After [33891], a lot of comment functions can take `WP_Comment` instead of only accepting `comment_ID`. Update the `@param` docs to reflect this. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33961 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:33:19 +00:00
Scott Taylor 5936394bb6 In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 01:12:41 +00:00
Scott Taylor 297df83c5d `WP_Theme` has an ad hoc property in `WP_MS_Themes_List_Table`, `$update`. This can be set to a default value on the class, as it's not obtained via `__get()`. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33957 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 01:01:12 +00:00
Scott Taylor ae16cec9fb In `wpdb::get_col_length()`, the final `return false` is unreachable since the default `switch` case returns. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33956 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 00:47:31 +00:00
Andrew Ozz bb6dee64ae Formatting: maintain the content of HTML comments when they contain `<object>` tags. Add more tests for wpaitop(). 
Props miqrogroove.
Fixes #33645 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33955 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 22:54:08 +00:00
Scott Taylor a4a469d887 After [33843], update the location of some files in `This filter is documented in` docs 
Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 22:16:57 +00:00
Scott Taylor f8b6a357a0 Multisite: Don't allow sites to be created with the following reserved slugs: `wp-admin`, `wp-content`, `wp-includes` 
Props austinginder.
Fixes #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 19:31:52 +00:00
Scott Taylor 44286b9ac1 After [33814], `checked()` outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms. 
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33951 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 19:22:19 +00:00
Scott Taylor ae8a4e496e Bump the timeout in `trackback()` to 10 seconds (from 4) to match `wp_xmlrpc_server::pingback_ping()` and prevent trackback timeouts. 
Props gnaka08 for the initial patch.
Fixes #10414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33948 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 18:55:45 +00:00
Scott Taylor 6d0c15836b After [33840], JS regex needs the `g` modifier. 
Add another unit test case.

Props kitchin.
Fixes #22781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33947 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 16:43:27 +00:00
Andrea Fercia 9f2738924c Bump H3 headings to H2 on the Network Add New User screen for better accessibility. 
Props Cheffheid.
Fixes #33605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33945 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 16:02:43 +00:00
Weston Ruter 395c8b7cd4 Customize: Fix logic for determining the container element when focusing on a panel, section, or control. 
Fixes #33695 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33939 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:58:44 +00:00
Weston Ruter 0c101e8cf6 Customize: Fix clearing of a color control's setting by using proper empty value. 
Props stevehenty.
Fixes #30280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33938 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:47:17 +00:00
Gary Pendergast 0b6454bac5 Readme: Update the recommended PHP version to 5.6. 
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.



git-svn-id: https://develop.svn.wordpress.org/trunk@33937 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:22:03 +00:00
Dion Hulse 95b3edd4ce Cron: Reject events when the provided `$timestamp` is not a valid timestamp. 
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.

Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423, Fixes #33475


git-svn-id: https://develop.svn.wordpress.org/trunk@33936 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 02:38:12 +00:00
Dion Hulse 628440fe5d Favicon: Do not specify a `Content-Length: 0` header for our "empty" response to fail more gracefully on environments with extra whitespace on output. 
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.

Props swissspidy.
Fixes #33626


git-svn-id: https://develop.svn.wordpress.org/trunk@33935 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 02:17:32 +00:00
Sergey Biryukov 8f2b90e299 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.

git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 07:59:01 +00:00
Sergey Biryukov 3853980a9a Merge two permission error strings. 
Props pavelevap.
Fixes #33745.

git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 06:41:58 +00:00
Sergey Biryukov 5d9dcf3d8a Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response. 
Props extendwings.
Fixes #33753.

git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:16:02 +00:00
Sergey Biryukov 4fb57210cd Update the parameter docs for `wp_add_post_tags()`, `wp_set_post_tags()`, and `wp_set_post_terms()`. 
Props johnbillion.
Fixes #33749.

git-svn-id: https://develop.svn.wordpress.org/trunk@33931 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:11:56 +00:00
Sergey Biryukov 8512ff08c0 Correct the docblock for `wp_list_widget_controls()`. 
Props swissspidy.
Fixes #33751.

git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:37:17 +00:00
John Blackbourn 547742f14a Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area. 
See #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@33929 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:24:06 +00:00
Sergey Biryukov 038a2c3b7a List tables: Adjust the styles for checkbox column to align better with longer column names. 
Props swissspidy.
Fixes #32825.

git-svn-id: https://develop.svn.wordpress.org/trunk@33928 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:15:57 +00:00
John Blackbourn 07861df743 Introduce a new `$is_edge` global for the Microsoft Edge browser. 
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.

See #33193
Props gregrickaby, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33927 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:33:01 +00:00
Scott Taylor 542ac152fc In `wp_list_comments()`, update the comment meta cache when the comments derive from `WP_Query` and the new `->comment_meta_cached` prop is `false`. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@33925 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:24:16 +00:00
John Blackbourn 43340fe787 When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to. 
See #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@33924 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:34:01 +00:00
John Blackbourn dd9722fac0 Bail out early from `esc_url()` if the URL becomes empty after stripping out disallowed characters. 
Fixes #28015
Props jesin for the unit test


git-svn-id: https://develop.svn.wordpress.org/trunk@33923 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:28:50 +00:00
John Blackbourn 6bfd06d5c8 Function docs for the `tax_input` and `meta_input` parameters available for `wp_insert_post()`. 
See #20451


git-svn-id: https://develop.svn.wordpress.org/trunk@33922 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:01:37 +00:00
Jeremy Felt 6b5e1e8c9b Multisite: Update help tab text for `site-info.php` to reference "site URL". 
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:52:52 +00:00
John Blackbourn 38fe3c4db5 Implement a language chooser on the Network Admin -> Sites -> Add New screen. 
Props DrewAPicture
Fixes #33528


git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:47:00 +00:00
Sergey Biryukov f8f8de0ecf Merge two strings in `Walker_Comment::comment()` and `Walker_Comment::html5_comment()`. 
Props pavelevap.
Fixes #33744.

git-svn-id: https://develop.svn.wordpress.org/trunk@33919 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:45:13 +00:00
Jeremy Felt d77b6f99c6 Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action. 
Props @swissspidy, @MikeHansenMe.
Fixes #32907.


git-svn-id: https://develop.svn.wordpress.org/trunk@33918 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:38:27 +00:00
Scott Taylor 1adb9643d9 Bump H3 headings to H2 on the {Term} screens for better accessibility. 
Props mrahmadawais.
Fixes #33658.


git-svn-id: https://develop.svn.wordpress.org/trunk@33917 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:16:17 +00:00
Scott Taylor 31663c6782 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33916 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:14:00 +00:00
Scott Taylor 3484a266a1 Bump H3 headings to H2 on the Media Settings screen for better accessibility. 
Props metodiew.
Fixes #33610.


git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:11:24 +00:00
Scott Taylor 32d296fb6a Bump H3 headings to H2 on Export screen for better accessibility. 
Props metodiew.
Fixes #33608.


git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:08:29 +00:00
Scott Taylor 23f2e79350 Correct the param docs for `comment_guid()` and `get_comment_guid()`. 
Props dimadin.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:59:10 +00:00
Scott Taylor b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:56:15 +00:00
Scott Taylor 38038ccba3 Add Customizer docs. 
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:52:17 +00:00
Scott Taylor 26dd8b5b08 Allow `wp_insert_post()` to accept a `meta_input` argument. Devs should use `register_meta()` to ensure that specific values specified by key are sanitized properly. 
Adds unit test.

Props CoenJacobs, swissspidy.
Fixes #20451.


git-svn-id: https://develop.svn.wordpress.org/trunk@33910 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:49:53 +00:00
Andrea Fercia 7b3b1c12d5 Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens. 
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.

git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 18:29:40 +00:00
Sergey Biryukov 36ed764d60 Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 
Props trepmal.
Fixes #33737.

git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 15:16:15 +00:00
Boone Gorges 3fba46b557 Allow `wp_terms_checklist()` to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.

git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:24:04 +00:00
Boone Gorges 9dfc5551ee In `get_terms()`, allow terms to be ordered by 'term_id'. 
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.

git-svn-id: https://develop.svn.wordpress.org/trunk@33903 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:16:11 +00:00
Sergey Biryukov dfceba6d05 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`. 
fixes #33685. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 03:39:33 +00:00
Drew Jaynes 9f5b896fac Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33901 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:51:08 +00:00
Drew Jaynes a767e01f17 Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API. 
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33900 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:46:29 +00:00
Drew Jaynes 3abc0933bb Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33899 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:41:17 +00:00
Drew Jaynes d615705cec Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750]. 
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33898 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:37:23 +00:00
Drew Jaynes 8cc0808e3b Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API. 
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:32:59 +00:00
Drew Jaynes 68f62a46e5 Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33896 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:28:10 +00:00
Drew Jaynes 8b3693c9e0 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749]. 
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33895 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:25:56 +00:00
Scott Taylor 43c8ec5f32 Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 23:22:32 +00:00
Drew Jaynes 46af2b9cd9 Docs: Add complete file, class, property, and method documentation for the new `WP_Comment` class, introduced in [33891]. 
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 19:57:15 +00:00
Sergey Biryukov 2487080654 Add missing translation functions to the error messages added in [33889]. 
props kraftbj, GaryJ.
fixes #33684.

git-svn-id: https://develop.svn.wordpress.org/trunk@33892 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:36:22 +00:00
Scott Taylor 60ba8b05e4 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:16:35 +00:00
Helen Hou-Sandi 52f31a77e9 UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.


git-svn-id: https://develop.svn.wordpress.org/trunk@33890 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:04:27 +00:00
Sergey Biryukov 71d4444ac7 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-includes/class-wp-customize-manager.php`. 
props kraftbj.
fixes #33684. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33889 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 09:20:40 +00:00
Sergey Biryukov 55bb26c58a Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33888 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 09:02:13 +00:00
Sergey Biryukov 7c32770901 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33887 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:58:34 +00:00
Sergey Biryukov 190561b89d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33886 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:55:53 +00:00
Sergey Biryukov 708cd13d77 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33885 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:53:23 +00:00
Sergey Biryukov e7beccf78c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33884 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:44:37 +00:00
Drew Jaynes 03a85947ef Docs: Add inline DocBlocks for the `require_once()` calls that now bring in top-level HTTP API functionality and HTTP API classes. 
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33882 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:46:27 +00:00
Drew Jaynes febec2128e Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33881 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:40:45 +00:00
Drew Jaynes 77a4ee7659 Docs: Add a missing file header for wp-includes/class-http.php. 
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33880 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:38:45 +00:00
Drew Jaynes 76f63a3b47 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748]. 
Also removes now-moot extra information from the file header description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33879 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:36:24 +00:00
Drew Jaynes 608957f426 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33878 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:32:54 +00:00
Drew Jaynes 572a9fa86b Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33876 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:29:39 +00:00
Drew Jaynes 81e8cc3d7e Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33875 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:27:04 +00:00
Drew Jaynes 069668dde9 Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33874 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:22:15 +00:00
Drew Jaynes b0ea6406a8 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748]. 
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33873 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:18:20 +00:00
Drew Jaynes fba0e92dc6 Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API. 
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33872 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 03:13:20 +00:00
Drew Jaynes 50d0b587f6 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33871 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 02:57:10 +00:00
Drew Jaynes f70c0d7080 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33870 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 02:53:19 +00:00
Drew Jaynes 4c5276edcf Docs: Improve the file header for class-wp-widget.php to describe what the file contains. 
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33869 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 02:49:39 +00:00
Drew Jaynes b75e5cdfd8 Docs: Add a missing summary to the DocBlock for `Walker::get_number_of_root_elements()`. 
Props wen-solutions
See #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33868 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 19:50:32 +00:00
Scott Taylor 4b9ccd27b1 After [33723], ensure that `$i` is properly set before looping. 
See #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33867 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:47:51 +00:00
Sergey Biryukov 5cf9c22518 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33866 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:44:07 +00:00
Sergey Biryukov 45237109dc Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33865 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:37:28 +00:00
Sergey Biryukov 89fca37568 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33864 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:35:05 +00:00
Sergey Biryukov 2dcbf39e2d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/options.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33863 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:30:58 +00:00
Sergey Biryukov 31caf44a24 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/nav-menus.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33862 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:20:53 +00:00
Sergey Biryukov 50224510ec Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:14:14 +00:00
Sergey Biryukov 0299c00fbb Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit-comments.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33860 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:03:10 +00:00
John Blackbourn 65c7f9113d Correctly encode spaces in URLs passed to `esc_url()` instead of removing them. 
Fixes #23605
Props enshrined, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33858 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 17:19:29 +00:00
Sergey Biryukov 1ec4b77ac2 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/customize.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33857 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 17:05:01 +00:00
Andrea Fercia 2ffd8b52cf Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604]. 
Fixes #33633.

git-svn-id: https://develop.svn.wordpress.org/trunk@33856 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:55:46 +00:00
Sergey Biryukov 22919f8150 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/custom-header.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:28:18 +00:00
Sergey Biryukov 1efad51200 Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:20:46 +00:00
Sergey Biryukov 029964a5ed Provide more helful feedback than just “Cheatin’ uh?” for permission errors in `wp-admin/edit-tags.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:05:07 +00:00
John Blackbourn 46c336e78a Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 11:28:11 +00:00
Jeremy Felt 4d2dbebb35 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.


git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 21:50:33 +00:00
DrewAPicture 62230a38e1 Docs: Add missing parameter documentation to the the DocBlock for `WP_User::__set()`. 
Props racase for the initial patch.
Fixes #33652.


git-svn-id: https://develop.svn.wordpress.org/trunk@33847 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 21:46:02 +00:00
Scott Taylor a3e0e719d6 De-Jorbin [33814]. 
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33845 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 15:47:16 +00:00
Sergey Biryukov 622032fece Make curly quotes in playlist item title translatable. 
fixes #33391.

git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 13:49:57 +00:00
Scott Taylor 1e084b6eaa Move widget classes to their own files in `wp-includes/widgets`: 
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33843 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 13:49:00 +00:00
Sergey Biryukov cfff91526f Merge two similar strings. 
props pavelevap.
fixes #33643.

git-svn-id: https://develop.svn.wordpress.org/trunk@33842 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 13:45:15 +00:00
Scott Taylor f6ab99bc68 Add some JS docs to `customize-base.js` 
Props ericlewis.
Fixes #33639.


git-svn-id: https://develop.svn.wordpress.org/trunk@33841 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 04:14:50 +00:00
Scott Taylor 99c34d57c1 User Settings: allow dashes in `get|set_user_setting()` in PHP and `get|setUserSetting()` in JS. 
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33840 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 03:56:44 +00:00
Sergey Biryukov 3710226cf4 Correct `@since` version for [33838]. 
props JustinSainton.
see #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33839 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 03:13:27 +00:00
Sergey Biryukov 357bd80a0b Add filters to `feed_links()` to choose whether to display the links to posts feed and comments feed, separately. 
props joostdevalk, juliobox.
fixes #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33838 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 02:45:58 +00:00
Weston Ruter 57a7ed15a7 Customizer: Collapse any expanded panel/sections before expanding other panel/sections 
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 23:07:57 +00:00
Andrew Ozz 43d053318e Editor, Press This: force a page reload when the user publishes a post and then clicks the back button. 
Fixes #23691.

git-svn-id: https://develop.svn.wordpress.org/trunk@33836 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 23:07:36 +00:00
Andrew Ozz 0807da1bdd TinyMCE: disable the native fullscreen plugin on mobile devices by default. 
Props iseulde. Fixes #33137;

git-svn-id: https://develop.svn.wordpress.org/trunk@33835 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 22:44:40 +00:00
Andrew Ozz 9c90fe1198 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content. 
Fixes #33477.

git-svn-id: https://develop.svn.wordpress.org/trunk@33834 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 22:06:11 +00:00
Sergey Biryukov 79907af59c Add `'dashboard_secondary_items'` filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.

git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:56:50 +00:00
SergeyBiryukov f0ab8b5a06 Add `'update_right_now_text'` filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.

git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:44:02 +00:00
John Blackbourn e5eec20a25 Space out. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33831 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:24:27 +00:00
Drew Jaynes f7507e511d Docs: Add a duplicate filter comment to the `comment_email` filter call in `WP_Comments_List_Table`, introduced in [33829]. 
See #11566.


git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:21:14 +00:00
Scott Taylor e10c682b83 Remove the hamburger global'ing from [33828]: since no args are passed to `comment_author_email_link()`, the internals can be simplified and applied inline. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:08:17 +00:00
Scott Taylor fef8794b2c Fix warnings after [33826]. Only only one function call needs a global `$comment`, we shall hamburger it. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:58:12 +00:00
Drew Jaynes f995a3cb96 Docs: Clarify the DocBlock summary for `wp_create_nonce()` to mention that nonce-creation is also now dependent on user tokens, as of [29221]. 
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.

Props ericlewis
Fixes #33636.


git-svn-id: https://develop.svn.wordpress.org/trunk@33827 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:49:49 +00:00
Scott Taylor 0f59069a7f `WP_Comments_List_Table::single_row()` has no reason to set the `$comment` global. No other methods use it, and we are not in template/loop context. This can mess with the response of `get_comment()` elsewhere, since `get_comment()` internally bypasses the cache/db when a global is set. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:41:09 +00:00
Sergey Biryukov 20767f42aa Use `wp_html_excerpt()` to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.

git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:40:28 +00:00
Scott Taylor 49923580bd `WP_Widget_Pages::widget()` has no reason to set `$comment` and `$comments` globals. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33824 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:30:32 +00:00
Scott Taylor 3028a096be Comments: `wp_count_comments()` can use `get_comment_count()` internally to makes its DB query, provided that `get_comment_count()` returns more properties. 
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.

Fixes #19903. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33822 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 18:50:12 +00:00
Scott Taylor af101dec19 Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation. 
Fixes #33414. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 17:57:32 +00:00
Sergey Biryukov ff7e86d14c Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:50:05 +00:00
Sergey Biryukov 0de0c060c1 Bump H3 headings to H2 on Tools screen for better accessibility. 
props Cheffheid.
fixes #33607.

git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:31:38 +00:00
Sergey Biryukov 77b54f319d Bump H3 headings to H2 on Permalink Settings screen for better accessibility. 
props Cheffheid.
fixes #33611.

git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:28:32 +00:00
Sergey Biryukov 7f3b90bc77 Bump H3 headings to H2 on WordPress Updates screen for better accessibility. 
props Cheffheid.
fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:25:27 +00:00
Drew Jaynes 8aefa21974 Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard: 
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant

See #33413


git-svn-id: https://develop.svn.wordpress.org/trunk@33816 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 23:13:45 +00:00
Konstantin Obenland 903b9af181 Themes: Get the correct theme when template and stylesheet were both passed as arguments. 
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.

Introduced in [21131].

Props obenland, wonderboymusic.
Fixes #32635.



git-svn-id: https://develop.svn.wordpress.org/trunk@33815 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 21:44:38 +00:00
Scott Taylor e3a3ba4caa Improve/update escaping in default widgets: 
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs

Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33814 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 05:37:53 +00:00
Scott Taylor 5d91ddf4e1 Improve/update escaping in `WP_Widget_Pages`. 
Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33813 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 04:47:00 +00:00
Scott Taylor 062aa80c1f Fix the doc block syntax for the `'wp_get_current_commenter'` filter. 
Props dimadin.
Fixes #33304.


git-svn-id: https://develop.svn.wordpress.org/trunk@33811 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:20:24 +00:00
Scott Taylor 413df72474 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 
Props pavelevap.
Fixes #33515.


git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:09:25 +00:00
Scott Taylor 75998818a4 Fix copy pasta in `wp_cache_decr()` doc block. 
Props danielbachhuber.
Fixes #33548.


git-svn-id: https://develop.svn.wordpress.org/trunk@33809 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:03:47 +00:00
Scott Taylor 905a612d88 Switching themes: if the new theme doesn't have `nav_menu_locations` defined, but the old theme does, copy the old theme's `nav_menu_locations` into the new theme's theme mods. 
cc melchoyce

Fixes #18588.


git-svn-id: https://develop.svn.wordpress.org/trunk@33808 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:00:45 +00:00
Scott Taylor c4b8ad087f Improve the reliability of the crop returned by `image_get_intermediate_size()`. 
Add a bunch of unit tests to `tests/image/intermediate_size.php`.

Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626.


git-svn-id: https://develop.svn.wordpress.org/trunk@33807 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 02:40:40 +00:00
Scott Taylor da0a823129 `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying. 
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33806 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 02:18:18 +00:00
Boone Gorges 0c7f2237f0 Pass taxonomy name to filters in `get_adjacent_post()`. 
Props sboisvert.
Fixes #33568.

git-svn-id: https://develop.svn.wordpress.org/trunk@33805 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 19:58:13 +00:00
Boone Gorges 27c8977af9 In `wp_list_categories()`, 'current_category' should accept an array of values. 
This allows the 'current-cat' or 'current-cat-parent' classes to be applied
to more than one item in the list.

Props vilkatis.
Fixes #33565.

git-svn-id: https://develop.svn.wordpress.org/trunk@33804 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 19:45:35 +00:00
Boone Gorges 5b0c402e6f Simplify the weeks-per-year calculation `WP_Date_Query::validate_date_values()`. 
Props luciole135.
Fixes #30845.

git-svn-id: https://develop.svn.wordpress.org/trunk@33803 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 01:46:53 +00:00
Sergey Biryukov a47ee912ac Make a period translatable. 
props mako09.
fixes #33594.

git-svn-id: https://develop.svn.wordpress.org/trunk@33802 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 01:39:51 +00:00
John Blackbourn a4808224ff Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 
Fixes #32913


git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 00:18:06 +00:00
Sergey Biryukov 7b9f6f54bf Twenty Fifteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33800 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:52:32 +00:00
Sergey Biryukov 8fbb450852 Twenty Fourteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33799 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:52:14 +00:00
Sergey Biryukov f5ee92c336 Twenty Thirteen: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33798 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:52:01 +00:00
Sergey Biryukov c64c73af89 Twenty Twelve: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33797 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:51:46 +00:00
Sergey Biryukov 1b60dc074d Twenty Eleven: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33796 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:51:32 +00:00
Sergey Biryukov 6ba3956fd8 Twenty Ten: Correct license information in `readme.txt`. 
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33795 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 16:51:02 +00:00
Drew Jaynes 002e2a0e4a Docs: Add a changelog entry to the `set_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
Fixes #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33794 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:40:32 +00:00
Drew Jaynes 3734aa1682 Docs: Add a changelog entry to the `pre_set_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33793 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:39:11 +00:00
Drew Jaynes bddb0de4d8 Docs: Add a changelog entry to the `site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33792 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:38:01 +00:00
Drew Jaynes 9a566ea593 Docs: Add a changelog entry to the `pre_site_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33791 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:36:49 +00:00
Drew Jaynes c71531275b Docs: Add a changelog entry to the `pre_update_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33790 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:35:35 +00:00
Drew Jaynes d06525c8a1 Docs: Add a changelog entry to the `pre_delete_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33789 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:34:26 +00:00
Drew Jaynes 3f8132e89e Docs: Add a changelog entry to the `pre_add_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33788 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:33:14 +00:00
Drew Jaynes 9eb92ae5ea Docs: Add a changelog entry to the `site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33787 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:31:58 +00:00
Drew Jaynes 0d27e9b012 Docs: Add a changelog entry to the `default_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33786 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:30:44 +00:00
Drew Jaynes 21ed57e09d Docs: Add a changelog entry to the `pre_site_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33785 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:29:26 +00:00
Drew Jaynes e2c8f3ec0d Docs: Add a changelog entry to the `pre_set_transient_$transient` hook doc for the `$transient` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33784 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:28:06 +00:00
Drew Jaynes 86a49119a2 Docs: Add a changelog entry to the `transient_$transient` hook doc for the `$transient` parameter, introduced in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33783 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:26:21 +00:00
Drew Jaynes 8336c88273 Docs: Add a changelog entry to the `pre_transient_$transient` hook doc for the `$transient` parameter, introduced in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33782 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:24:49 +00:00
Drew Jaynes 958c835f9a Docs: Add a changelog entry to the `update_option_{$option}` hook doc for the `$option` parameter, introduced in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33781 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:23:14 +00:00
Drew Jaynes 323ca7e1d3 Docs: Add a changelog entry to the `pre_update_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33780 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:21:18 +00:00
Drew Jaynes 41370b6e97 Docs: Add a changelog entry to the `option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33779 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:19:54 +00:00
Drew Jaynes 9973d71384 Docs: Add a changelog entry to the `default_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402


git-svn-id: https://develop.svn.wordpress.org/trunk@33778 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 15:17:33 +00:00
Sergey Biryukov d5dd61424d Network Admin: Hide the bulk actions checkbox for super admins. 
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:48:47 +00:00
Sergey Biryukov 28767e1bac In `get_post_type_labels()`, ensure that filtered labels contain all required default values. 
fixes #33543.

git-svn-id: https://develop.svn.wordpress.org/trunk@33776 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:38:26 +00:00
Sergey Biryukov 923498aaa4 Avoid PHP notices in `redirect_canonical()` and `_wp_menu_item_classes_by_context()` if `$_SERVER['HTTP_HOST']` is not set. 
fixes #32229.

git-svn-id: https://develop.svn.wordpress.org/trunk@33775 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:30:55 +00:00
Helen Hou-Sandi 0c19c94561 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:16:02 +00:00
John Blackbourn d89398f945 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post. 
Fixes #32954
Props boonebgorges, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:56:54 +00:00
Sergey Biryukov 65c07b81c0 Remove `wp-includes/comment-functions.php` from the `$_old_files` array. See [33750]. 
props rachelbaker.
fixes #33569.

git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:39:58 +00:00
John Blackbourn f312173db5 Improve the efficiency of `is_user_member_of_blog()` by removing its use of `get_blogs_of_user()`. Adds additional tests. 
Fixes #32472
Props BinaryKitten, sammybeats, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33771 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:01:37 +00:00
John Blackbourn 0d0a8353f5 Remove `error` from the query variables when cleaning up a URL in `wp_admin_canonical_url()`. 
Fixes #32847


git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:25:15 +00:00
John Blackbourn e95ce848f9 Correct the hook docs for the `user_profile_update_errors` action. 
Fixes #33537
Props yamchhetri


git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:15:54 +00:00
Drew Jaynes ffb128a3c6 Docs: Add a changelog entry to the `pre_option_$option` hook doc for the `$option` parameter, added in [33738]. 
See #28402


git-svn-id: https://develop.svn.wordpress.org/trunk@33768 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 16:59:17 +00:00
Boone Gorges 718787cd18 Rename param added to `wp_list_categories()` in [33764] to 'hide_title_if_empty'. 
Props vilkatis, DrewAPicture.
Fixes #33565.

git-svn-id: https://develop.svn.wordpress.org/trunk@33767 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 02:08:31 +00:00
Sergey Biryukov 30eb4853f0 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile. 
props peterwilsoncc.
fixes #33419 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 00:10:39 +00:00
Boone Gorges 1f7031e2f8 After [33764], fix docblock formatting for `wp_list_categories()`. 
See #33460.

git-svn-id: https://develop.svn.wordpress.org/trunk@33765 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 19:42:02 +00:00
Boone Gorges a684d5d19d Introduce `hide_title_if_no_cats` parameter to `wp_list_categories()`. 
When generating a `<ul>` using `wp_list_categories()`, a title `<li>` element
is put at the top of the term list. Current behavior is that this title `<li>`
appears even when no terms are found. The new `hide_title_if_no_cats` param
allows developers to specify that the title should be hidden when the term list
is empty.

Props vilkatis.
Fixes #33460.

git-svn-id: https://develop.svn.wordpress.org/trunk@33764 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 19:41:55 +00:00
Boone Gorges 91a24f5cca Use proper array documentation formatting for `wp_list_categories()`. 
This changeset also corrects a few parameter descriptions, and adds a few that
were previously missing.

Fixes #33556.

git-svn-id: https://develop.svn.wordpress.org/trunk@33763 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 15:29:35 +00:00
Sergey Biryukov a69c9ff66f Make post meta box toggles accessible. 
props joedolson.
fixes #33544.

git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 15:22:57 +00:00
Scott Taylor 46d0feea46 Meta: move `WP_Meta_Query` into its own file. `meta.php` loads the new files, so this is 100% BC if someone is loading `meta.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-meta-query.php` 
`meta-functions.php` 

`meta.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33761 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 13:01:22 +00:00
Scott Taylor bb0b507718 Taxonomy: move `WP_Tax_Query` into its own file. `taxonomy.php` loads the new files, so this is 100% BC if someone is loading `taxonomy.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-tax-query.php` 
`taxonomy-functions.php` 

`taxonomy.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33760 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 12:48:11 +00:00
Scott Taylor 718c1a8d25 Posts: move `WP_Post` into its own file. `post.php` loads the new files, so this is 100% BC if someone is loading `post.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-post.php` 
`post-functions.php` 

`post.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33759 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 12:39:07 +00:00
Drew Jaynes 2fda97b15a Docs: Add inline-docblocks for the `require_once()` calls that now bring in the `WP_Widget` and `WP_Widget_Factory` classes, as well as general core widgets functionality, as of [33746]. 
See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33758 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 08:00:35 +00:00
Drew Jaynes fc691e0457 Docs: Add a file header description and `@since` version to wp-includes/widget-functions.php, introduced in [33746]. 
Also adds sub-section headers per the inline documentation standards for syntax.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33757 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 07:56:30 +00:00
Drew Jaynes 9f61d73c0c Docs: Add a file header to wp-includes/class-wp-widget-factory.php, created when the `WP_Widget_Factory` class was moved to its own file in [33746]. 
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33756 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 07:52:05 +00:00
Drew Jaynes 76f5134023 Docs: Add a file header to wp-includes/class-wp-widget.php, created when the `WP_Widget` class was moved to its own file in [33746]. 
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33755 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 07:44:59 +00:00
Weston Ruter 9c4f261598 Customizer: Ensure persistence of unchanged `active` state for controls, sections, and panels. 
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 07:25:20 +00:00
Weston Ruter e32f3cd3e1 Customizer: Prevent JS error during init when `nav_menus` panel is removed by plugin. 
Fixes #33411 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 06:42:16 +00:00
Scott Taylor 28217ae6a0 Roles: move classes into their own file. `capbilities.php` loads the new files, so this is 100% BC if someone is loading `capbilities.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-roles.php` 
`class-wp-role.php` 
`class-wp-user.php` 
`capbilities-functions.php` 

`capbilities.php` contains only top-level code. Class files only contains classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33752 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 04:57:48 +00:00
Scott Taylor 799f28a918 Rewrite: move `WP_Rewrite` into its own file. `rewrite.php` loads the new files, so this is 100% BC if someone is loading `rewrite.php` directly. New files created using `svn cp`. 
The rewrite functions have all kinds of cross-dependencies (like `WP_Query`), so loading the file by itself would have been bizarre (and still is).

Creates: 
`rewrite-constants.php` 
`rewrite-functions.php` 
`class-wp-rewrite.php` 

`rewrite.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33751 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 04:41:29 +00:00
Scott Taylor d61669232c Comments: move `WP_Comment_Query` into its own file. `comment.php` loads the new files, so this is 100% BC if someone is loading `comment.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-comment-query.php` 
`comment-functions.php` 

`comment.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33750 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 04:26:29 +00:00
Scott Taylor 7b58399a45 Users: move `WP_User_Query` into its own file. `user.php` loads the new files, so this is 100% BC if someone is loading `user.php` directly (a lot of plugins do). New files created using `svn cp`. 
Creates: 
`class-wp-user-query.php` 
`user-functions.php` 

`user.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33749 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 04:19:32 +00:00
Scott Taylor f4ecd11e10 HTTP: move classes into their own files, `http.php` loads the new files, so this is 100% BC if someone is loading `http.php` directly. New files created using `svn cp`. 
`class-http.php` requires functions from `http.php`, so loading it by itself wouldn't have worked.

Creates: 
`class-wp-http-cookie.php` 
`class-wp-http-curl.php` 
`class-wp-http-encoding.php` 
`class-wp-http-proxy.php` 
`class-wp-http-streams.php` 
`http-functions.php` 

`WP_Http` remains in `class-http.php`.

`http.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33748 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 03:55:00 +00:00
Gary Pendergast 2b67add6dd When `wp_json_encode()` calls `json_encode()`, the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that. 
The good news is, the point of `wp_json_encode()` is to handle those non-UTF-8 characters. It'll totally just fix them up, no problem.

Anyway, we can just ignore those warnings.

Fixes #33524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33747 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 03:25:15 +00:00
Scott Taylor 6c71ee8d84 Widgets: move classes into their own files, `widgets.php` loads the new files, so this is 100% BC if someone is loading `widgets.php` directly. New files created using `svn cp`. 
Creates: 
`class-wp-widget.php` 
`class-wp-widget-factory.php` 
`widget-functions.php` 

`widgets.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33746 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 02:39:50 +00:00
Sergey Biryukov 0654d9ed35 Add oEmbed support for ReverbNation. 
props rhubbardreverb.
fixes #33207.

git-svn-id: https://develop.svn.wordpress.org/trunk@33745 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 00:28:11 +00:00
Sergey Biryukov b935049f24 Add `'wp_verify_nonce_failed'` action that fires when nonce verification fails. 
props johnbillion, garza, Shelob9.
fixes #24030.

git-svn-id: https://develop.svn.wordpress.org/trunk@33744 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 00:05:11 +00:00
Sergey Biryukov 4bc9b3db6d Fire the `check_ajax_referer` action on failure as well as success. 
See [33017] for `check_admin_referer`.

props egill.
fixes #33342.

git-svn-id: https://develop.svn.wordpress.org/trunk@33743 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 23:24:39 +00:00
Sergey Biryukov 6598033243 Remove rounded corners from "Choose from the most used tags" result in Tags meta box. 
props tyxla.
fixes #31560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 23:13:30 +00:00
Sergey Biryukov b73b9ed936 Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951]. 
props egill.
fixes #33416.

git-svn-id: https://develop.svn.wordpress.org/trunk@33741 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:52:45 +00:00
Scott Taylor 4a622d21fb Allow these CSS properties in KSES: `min-height', 'max-height', 'min-width', 'max-width'` 
Props MikeHansenMe.
Fixes #31949.


git-svn-id: https://develop.svn.wordpress.org/trunk@33739 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:45:42 +00:00
Scott Taylor c76e3b3273 Pass option name to option and transient filters with dynamic names. 
Props Viper007Bond, SergeyBiryukov, MikeHansenMe.
Fixes #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33738 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:41:53 +00:00
wonderboymusic 20bad276e8 After [33698], wrap the time constants in a DocBlock template. 
Props egill.
Fixes #33397.


git-svn-id: https://develop.svn.wordpress.org/trunk@33737 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:20:02 +00:00
Scott Taylor 1fb94edb99 In `get_home_url()`, import the `$pagenow` global to avoid having to check if it exists before comparing against it. 
Props KalenJohnson.
See #33545.


git-svn-id: https://develop.svn.wordpress.org/trunk@33736 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 21:02:14 +00:00
Scott Taylor ff7fcf5f04 In `WP_Users_List_Table::single_row()`, `$actions` is not always set before being used. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:37:50 +00:00
Scott Taylor 3b8c5529cb `foreach` is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Scott Taylor 755d109d10 Instead of [33713], allow `WP_Posts_List_Table::get_bulk_actions()` to check `edit_posts` AND `delete_posts`. 
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:11:27 +00:00
Sergey Biryukov b59d10ccac Multisite: Add `'invite_user'` action that fires immediately after a user is invited to join a site, but before the notification is sent. 
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.

git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:47:26 +00:00
Drew Jaynes 40ce8c68fe Docs: The type for the `$t_time` parameter in the `post_date_column_time` filter docs should be `string`, not `array`. 
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:14:28 +00:00
Drew Jaynes e853c467fd Docs: Document the default comment data arguments for `wp_new_comment()`. 
Props rachelbaker, DrewAPicture
Fixes #32369.


git-svn-id: https://develop.svn.wordpress.org/trunk@33730 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:02:51 +00:00
Scott Taylor e1b1541932 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 12:12:59 +00:00
Andrew Ozz a9b27cbc07 TinyMCE: ensure the `wordpress` plugin is loaded before calling `_createToolbar()`. 
Props hauvong, azaozz. Fixes #33393.

git-svn-id: https://develop.svn.wordpress.org/trunk@33728 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:37:27 +00:00
Dion Hulse 3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:31:52 +00:00
Drew Jaynes bc9e25d053 Docs: Clarify the return description for `wp_create_user()` to illustrate that a `WP_Error` object will be returned on failure. 
Props jmayhak
Fixes #33321.


git-svn-id: https://develop.svn.wordpress.org/trunk@33725 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 22:22:33 +00:00
Boone Gorges 32cd95e1c1 In `WP_Query::parse_tax_query()`, allow 'cat' and 'tag' querystrings to be formatted as arrays. 
See [33095] #32454 for a previous fix related to custom taxonomies.

Props Veraxus.
Fixes #33532.

git-svn-id: https://develop.svn.wordpress.org/trunk@33724 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 21:21:49 +00:00
Scott Taylor 5f3879e37c With a few modifications in `wp-admin/menu.php`, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare `menu_position` on post type registration. 
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 21:18:20 +00:00
Scott Taylor dc577d6072 `WP_Query`: add changelog for the `title` param after [33706] 
Props dimadin.
Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33722 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 20:09:25 +00:00
Drew Jaynes 7b7cd91984 Docs: Improve pared formatting of the oEmbed providers tables by removing the unrecognized first and last rows in the hook docs for the `oembed_providers` filter. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33720 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 04:37:40 +00:00
Gary Pendergast 845d31baf9 oEmbed: Remove blip.tv as an oEmbed provider, the service has been shut down. 
Vale, blip.tv.

Fixes #33522.

Props rabmalin.



git-svn-id: https://develop.svn.wordpress.org/trunk@33719 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 04:11:13 +00:00
Gary Pendergast bf3d36e0b6 WPDB: `get_table_from_query()` didn't find table names with hyphens in them. 
Props dustinbolton for the fix.

Fixes #33470.



git-svn-id: https://develop.svn.wordpress.org/trunk@33718 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 00:18:49 +00:00
Drew Jaynes 83476bb77f Docs: Add a description and example to the hook docs for the `navigation_markup_template` filter, introduced in [33714]. 
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.

See #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33717 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 18:07:41 +00:00
Drew Jaynes 3969554606 Docs: Better clarify that the `$post_type` parameter for the `get_usernumposts` filter and `count_user_posts()` can accept either a single post type or array of post types. 
Props tyxla
See #33481. Fixes #33520.


git-svn-id: https://develop.svn.wordpress.org/trunk@33716 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 17:45:51 +00:00
Drew Jaynes 797b6c4d7c Docs: Add better documentation for all accepted values for the `fields` argument in `get_terms()`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33715 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 17:39:07 +00:00
Scott Taylor d8ba4fde1b Add a filter to `_navigation_markup`: 'navigation_markup_template' 
Props joedolson, mordauk.
Fixes #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33714 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:33:25 +00:00
Scott Taylor 9596ae0993 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:27:44 +00:00
Drew Jaynes dfa9da5356 Docs: Fix a minor alignment issue in the DocBlock for `get_pagenum_link()`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33712 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 07:18:19 +00:00
Boone Gorges b01b3be23e In `wp_delete_term()`, the `$deleted_term` object passed to filters should be generated before term relationships are deleted. 
This allows the `count` property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.

git-svn-id: https://develop.svn.wordpress.org/trunk@33711 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 19:42:30 +00:00
Boone Gorges 6c3449b710 Pass the `$public_only` value to 'get_usernumposts' filter. 
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33710 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 18:58:18 +00:00