Drew Jaynes
81ec5c8e91
Docs: Add a changelog entry to the DocBlock for touch_time()
to mention the shift from accessing the global $comment
to using get_comment()
.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:47:43 +00:00
Drew Jaynes
d651587a0d
Docs: Use the $widget_links_args
parameter in the hook doc for the widget_links_args
filter, introduced when the args array was split out to a variable in [33971].
...
See #20788 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33978 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:44:46 +00:00
Scott Taylor
ab9bbfa9ce
WP_Widget_Links
: pass widget instance to widget_links_args
filter
...
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33971 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:41:21 +00:00
Scott Taylor
d6e73d47e4
Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
...
Props yoavf.
Fixes #32875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:38:31 +00:00
Scott Taylor
9eefbd1999
Deprecate wp_get_http()
- function isn't used anywhere (apart from itself).
...
Props swissspidy.
Fixes #33709 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33969 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:25:24 +00:00
Scott Taylor
4016b77b1a
Add a parameter, $post
, to get_{$adjacent}_post_join
, get_{$adjacent}_post_where
, and get_{$adjacent}_post_sort
...
Props JustinSainton.
Fixes #24597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33968 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:49:00 +00:00
Scott Taylor
05e249d5ac
Ensure that role
is not empty before adding it in add_role()
function and methods.
...
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33967 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:41:27 +00:00
Scott Taylor
047f3ef01a
Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types.
...
Props lancewillett, adamsilverstein.
Fixes #31910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33966 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:22:36 +00:00
Scott Taylor
42e8258275
Use get_comment()
instead of a global in touch_time()
.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:04:38 +00:00
Scott Taylor
df637648e2
In WP_Comments_List_Table
, favor passing WP_Comment
instances instead of $comment_ID
to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:59:54 +00:00
Scott Taylor
38d374ab01
After [33891], get_comment()
returns global $comment
if no args are passed and the global is set (after setting the default to null
here). This allows us to ditch global comment imports.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:50:43 +00:00
Scott Taylor
8088ffafd6
Walker_Comment
should be in its own file. Loaded now via wp-includes/comment.php
, which makes it 100% BC.
...
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33962 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:40:53 +00:00
Scott Taylor
95247e5bd8
After [33891], a lot of comment functions can take WP_Comment
instead of only accepting comment_ID
. Update the @param
docs to reflect this.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33961 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:33:19 +00:00
Scott Taylor
5936394bb6
In WP_User
, add @property
docs for description
, first_name
, and last_name
. user_firstname
and user_lastname
only exist for back-compat.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:12:41 +00:00
Scott Taylor
297df83c5d
WP_Theme
has an ad hoc property in WP_MS_Themes_List_Table
, $update
. This can be set to a default value on the class, as it's not obtained via __get()
.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33957 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:01:12 +00:00
Scott Taylor
ae16cec9fb
In wpdb::get_col_length()
, the final return false
is unreachable since the default switch
case returns.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33956 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 00:47:31 +00:00
Andrew Ozz
bb6dee64ae
Formatting: maintain the content of HTML comments when they contain <object>
tags. Add more tests for wpaitop().
...
Props miqrogroove.
Fixes #33645 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33955 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:54:08 +00:00
Scott Taylor
a4a469d887
After [33843], update the location of some files in This filter is documented in
docs
...
Props dimadin.
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:16:57 +00:00
Scott Taylor
f8b6a357a0
Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin
, wp-content
, wp-includes
...
Props austinginder.
Fixes #33615 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
Scott Taylor
44286b9ac1
After [33814], checked()
outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms.
...
See #23012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33951 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:22:19 +00:00
Scott Taylor
ae8a4e496e
Bump the timeout in trackback()
to 10 seconds (from 4) to match wp_xmlrpc_server::pingback_ping()
and prevent trackback timeouts.
...
Props gnaka08 for the initial patch.
Fixes #10414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33948 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 18:55:45 +00:00
Scott Taylor
6d0c15836b
After [33840], JS regex needs the g
modifier.
...
Add another unit test case.
Props kitchin.
Fixes #22781 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33947 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 16:43:27 +00:00
Andrea Fercia
9f2738924c
Bump H3 headings to H2 on the Network Add New User screen for better accessibility.
...
Props Cheffheid.
Fixes #33605 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33945 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 16:02:43 +00:00
Weston Ruter
395c8b7cd4
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Fixes #33695 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33939 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:58:44 +00:00
Weston Ruter
0c101e8cf6
Customize: Fix clearing of a color control's setting by using proper empty value.
...
Props stevehenty.
Fixes #30280 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33938 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:47:17 +00:00
Gary Pendergast
0b6454bac5
Readme: Update the recommended PHP version to 5.6.
...
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.
Fixes #33758 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33937 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:22:03 +00:00
Dion Hulse
95b3edd4ce
Cron: Reject events when the provided $timestamp
is not a valid timestamp.
...
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.
Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423 , Fixes #33475
git-svn-id: https://develop.svn.wordpress.org/trunk@33936 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:38:12 +00:00
Dion Hulse
628440fe5d
Favicon: Do not specify a Content-Length: 0
header for our "empty" response to fail more gracefully on environments with extra whitespace on output.
...
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.
Props swissspidy.
Fixes #33626
git-svn-id: https://develop.svn.wordpress.org/trunk@33935 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:17:32 +00:00
Sergey Biryukov
8f2b90e299
Widgets: Don't display sidebar description container if it's empty.
...
Props paulwilde.
Fixes #32448 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 07:59:01 +00:00
Sergey Biryukov
3853980a9a
Merge two permission error strings.
...
Props pavelevap.
Fixes #33745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 06:41:58 +00:00
Sergey Biryukov
5d9dcf3d8a
Correct description for version
and current_version
parameters in wp_check_browser_version()
response.
...
Props extendwings.
Fixes #33753 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 00:16:02 +00:00
Sergey Biryukov
4fb57210cd
Update the parameter docs for wp_add_post_tags()
, wp_set_post_tags()
, and wp_set_post_terms()
.
...
Props johnbillion.
Fixes #33749 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33931 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 00:11:56 +00:00
Sergey Biryukov
8512ff08c0
Correct the docblock for wp_list_widget_controls()
.
...
Props swissspidy.
Fixes #33751 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:37:17 +00:00
John Blackbourn
547742f14a
Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area.
...
See #25162
git-svn-id: https://develop.svn.wordpress.org/trunk@33929 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:24:06 +00:00
Sergey Biryukov
038a2c3b7a
List tables: Adjust the styles for checkbox column to align better with longer column names.
...
Props swissspidy.
Fixes #32825 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33928 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:15:57 +00:00
John Blackbourn
07861df743
Introduce a new $is_edge
global for the Microsoft Edge browser.
...
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.
See #33193
Props gregrickaby, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@33927 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 22:33:01 +00:00
Scott Taylor
542ac152fc
In wp_list_comments()
, update the comment meta cache when the comments derive from WP_Query
and the new ->comment_meta_cached
prop is false
.
...
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.
Adds unit tests.
Props wonderboymusic, bradt.
Fixes #16894 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33925 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 22:24:16 +00:00
John Blackbourn
43340fe787
When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to.
...
See #25162
git-svn-id: https://develop.svn.wordpress.org/trunk@33924 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 21:34:01 +00:00
John Blackbourn
dd9722fac0
Bail out early from esc_url()
if the URL becomes empty after stripping out disallowed characters.
...
Fixes #28015
Props jesin for the unit test
git-svn-id: https://develop.svn.wordpress.org/trunk@33923 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 21:28:50 +00:00
John Blackbourn
6bfd06d5c8
Function docs for the tax_input
and meta_input
parameters available for wp_insert_post()
.
...
See #20451
git-svn-id: https://develop.svn.wordpress.org/trunk@33922 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 21:01:37 +00:00
Jeremy Felt
6b5e1e8c9b
Multisite: Update help tab text for site-info.php
to reference "site URL".
...
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.
Fixes #33748 . See #22383 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:52:52 +00:00
John Blackbourn
38fe3c4db5
Implement a language chooser on the Network Admin -> Sites -> Add New screen.
...
Props DrewAPicture
Fixes #33528
git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:47:00 +00:00
Sergey Biryukov
f8f8de0ecf
Merge two strings in Walker_Comment::comment()
and Walker_Comment::html5_comment()
.
...
Props pavelevap.
Fixes #33744 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33919 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:45:13 +00:00
Jeremy Felt
d77b6f99c6
Multisite: Pass the ID of the site being updated to wpmu_update_blog_options
action.
...
Props @swissspidy, @MikeHansenMe.
Fixes #32907 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33918 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:38:27 +00:00
Scott Taylor
1adb9643d9
Bump H3 headings to H2 on the {Term} screens for better accessibility.
...
Props mrahmadawais.
Fixes #33658 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33917 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:16:17 +00:00
Scott Taylor
31663c6782
Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33609 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33916 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:14:00 +00:00
Scott Taylor
3484a266a1
Bump H3 headings to H2 on the Media Settings screen for better accessibility.
...
Props metodiew.
Fixes #33610 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:11:24 +00:00
Scott Taylor
32d296fb6a
Bump H3 headings to H2 on Export screen for better accessibility.
...
Props metodiew.
Fixes #33608 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:08:29 +00:00
Scott Taylor
23f2e79350
Correct the param docs for comment_guid()
and get_comment_guid()
.
...
Props dimadin.
Fixes #32619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:59:10 +00:00
Scott Taylor
b8e30f3ec7
Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
...
Props afercia.
Fixes #32866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00