Commit Graph

7630 Commits

Author SHA1 Message Date
Sergey Biryukov
22919f8150 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:28:18 +00:00
Sergey Biryukov
1efad51200 Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:20:46 +00:00
Sergey Biryukov
029964a5ed Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 16:05:07 +00:00
John Blackbourn
46c336e78a Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
Jeremy Felt
4d2dbebb35 Multisite: Remove duplicate span element output from row actions
Fixes #32961.


git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:50:33 +00:00
DrewAPicture
62230a38e1 Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set().
Props racase for the initial patch.
Fixes #33652.


git-svn-id: https://develop.svn.wordpress.org/trunk@33847 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:46:02 +00:00
Scott Taylor
a3e0e719d6 De-Jorbin [33814].
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33845 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 15:47:16 +00:00
Sergey Biryukov
622032fece Make curly quotes in playlist item title translatable.
fixes #33391.

git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:57 +00:00
Scott Taylor
1e084b6eaa Move widget classes to their own files in wp-includes/widgets:
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33843 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:00 +00:00
Sergey Biryukov
cfff91526f Merge two similar strings.
props pavelevap.
fixes #33643.

git-svn-id: https://develop.svn.wordpress.org/trunk@33842 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:45:15 +00:00
Scott Taylor
f6ab99bc68 Add some JS docs to customize-base.js
Props ericlewis.
Fixes #33639.


git-svn-id: https://develop.svn.wordpress.org/trunk@33841 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 04:14:50 +00:00
Scott Taylor
99c34d57c1 User Settings: allow dashes in get|set_user_setting() in PHP and get|setUserSetting() in JS.
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33840 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:56:44 +00:00
Sergey Biryukov
3710226cf4 Correct @since version for [33838].
props JustinSainton.
see #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33839 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:13:27 +00:00
Sergey Biryukov
357bd80a0b Add filters to feed_links() to choose whether to display the links to posts feed and comments feed, separately.
props joostdevalk, juliobox.
fixes #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33838 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 02:45:58 +00:00
Weston Ruter
57a7ed15a7 Customizer: Collapse any expanded panel/sections before expanding other panel/sections
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:57 +00:00
Andrew Ozz
43d053318e Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
Fixes #23691.

git-svn-id: https://develop.svn.wordpress.org/trunk@33836 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:36 +00:00
Andrew Ozz
0807da1bdd TinyMCE: disable the native fullscreen plugin on mobile devices by default.
Props iseulde. Fixes #33137;

git-svn-id: https://develop.svn.wordpress.org/trunk@33835 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:44:40 +00:00
Andrew Ozz
9c90fe1198 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content.
Fixes #33477.

git-svn-id: https://develop.svn.wordpress.org/trunk@33834 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:06:11 +00:00
Sergey Biryukov
79907af59c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget.
props MikeHansenMe, DrewAPicture.
fixes #31434.

git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:56:50 +00:00
SergeyBiryukov
f0ab8b5a06 Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget.
props obenland.
fixes #33355.

git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:44:02 +00:00
John Blackbourn
e5eec20a25 Space out.
git-svn-id: https://develop.svn.wordpress.org/trunk@33831 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:24:27 +00:00
Drew Jaynes
f7507e511d Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829].
See #11566.


git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:21:14 +00:00
Scott Taylor
e10c682b83 Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:08:17 +00:00
Scott Taylor
fef8794b2c Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:58:12 +00:00
Drew Jaynes
f995a3cb96 Docs: Clarify the DocBlock summary for wp_create_nonce() to mention that nonce-creation is also now dependent on user tokens, as of [29221].
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.

Props ericlewis
Fixes #33636.


git-svn-id: https://develop.svn.wordpress.org/trunk@33827 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:49:49 +00:00
Scott Taylor
0f59069a7f WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:41:09 +00:00
Sergey Biryukov
20767f42aa Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen.
props brettz95, solarissmoke.
fixes #15659.

git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:40:28 +00:00
Scott Taylor
49923580bd WP_Widget_Pages::widget() has no reason to set $comment and $comments globals.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33824 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:30:32 +00:00
Scott Taylor
3028a096be Comments: wp_count_comments() can use get_comment_count() internally to makes its DB query, provided that get_comment_count() returns more properties.
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.

Fixes #19903. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33822 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 18:50:12 +00:00
Scott Taylor
af101dec19 Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
Fixes #33414. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 17:57:32 +00:00
Sergey Biryukov
ff7e86d14c Bump H3 headings to H2 on Themes screen for better accessibility.
props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:50:05 +00:00
Sergey Biryukov
0de0c060c1 Bump H3 headings to H2 on Tools screen for better accessibility.
props Cheffheid.
fixes #33607.

git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:31:38 +00:00
Sergey Biryukov
77b54f319d Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
props Cheffheid.
fixes #33611.

git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:28:32 +00:00
Sergey Biryukov
7f3b90bc77 Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
props Cheffheid.
fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 03:25:27 +00:00
Drew Jaynes
8aefa21974 Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard:
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant

See #33413


git-svn-id: https://develop.svn.wordpress.org/trunk@33816 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 23:13:45 +00:00
Konstantin Obenland
903b9af181 Themes: Get the correct theme when template and stylesheet were both passed as arguments.
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.

Introduced in [21131].

Props obenland, wonderboymusic.
Fixes #32635.



git-svn-id: https://develop.svn.wordpress.org/trunk@33815 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 21:44:38 +00:00
Scott Taylor
e3a3ba4caa Improve/update escaping in default widgets:
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs

Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33814 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 05:37:53 +00:00
Scott Taylor
5d91ddf4e1 Improve/update escaping in WP_Widget_Pages.
Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33813 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 04:47:00 +00:00
Scott Taylor
062aa80c1f Fix the doc block syntax for the 'wp_get_current_commenter' filter.
Props dimadin.
Fixes #33304.


git-svn-id: https://develop.svn.wordpress.org/trunk@33811 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:20:24 +00:00
Scott Taylor
413df72474 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
Props pavelevap.
Fixes #33515.


git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:09:25 +00:00
Scott Taylor
75998818a4 Fix copy pasta in wp_cache_decr() doc block.
Props danielbachhuber.
Fixes #33548.


git-svn-id: https://develop.svn.wordpress.org/trunk@33809 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:03:47 +00:00
Scott Taylor
905a612d88 Switching themes: if the new theme doesn't have nav_menu_locations defined, but the old theme does, copy the old theme's nav_menu_locations into the new theme's theme mods.
cc melchoyce

Fixes #18588.


git-svn-id: https://develop.svn.wordpress.org/trunk@33808 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:00:45 +00:00
Scott Taylor
c4b8ad087f Improve the reliability of the crop returned by image_get_intermediate_size().
Add a bunch of unit tests to `tests/image/intermediate_size.php`.

Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626.


git-svn-id: https://develop.svn.wordpress.org/trunk@33807 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 02:40:40 +00:00
Scott Taylor
da0a823129 get_comment_count() currently increments awaiting_moderation when comments are in the trash. This occurs because case 0: will match any value passed to switch that is a string that isn't specified in the list of cases. This is terrifying.
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33806 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 02:18:18 +00:00
Boone Gorges
0c7f2237f0 Pass taxonomy name to filters in get_adjacent_post().
Props sboisvert.
Fixes #33568.

git-svn-id: https://develop.svn.wordpress.org/trunk@33805 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 19:58:13 +00:00
Boone Gorges
27c8977af9 In wp_list_categories(), 'current_category' should accept an array of values.
This allows the 'current-cat' or 'current-cat-parent' classes to be applied
to more than one item in the list.

Props vilkatis.
Fixes #33565.

git-svn-id: https://develop.svn.wordpress.org/trunk@33804 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 19:45:35 +00:00
Boone Gorges
5b0c402e6f Simplify the weeks-per-year calculation WP_Date_Query::validate_date_values().
Props luciole135.
Fixes #30845.

git-svn-id: https://develop.svn.wordpress.org/trunk@33803 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 01:46:53 +00:00
Sergey Biryukov
a47ee912ac Make a period translatable.
props mako09.
fixes #33594.

git-svn-id: https://develop.svn.wordpress.org/trunk@33802 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 01:39:51 +00:00
John Blackbourn
a4808224ff Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
Fixes #32913


git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-29 00:18:06 +00:00
Sergey Biryukov
7b9f6f54bf Twenty Fifteen: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33800 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:52:32 +00:00
Sergey Biryukov
8fbb450852 Twenty Fourteen: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33799 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:52:14 +00:00
Sergey Biryukov
f5ee92c336 Twenty Thirteen: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33798 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:52:01 +00:00
Sergey Biryukov
c64c73af89 Twenty Twelve: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33797 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:51:46 +00:00
Sergey Biryukov
1b60dc074d Twenty Eleven: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33796 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:51:32 +00:00
Sergey Biryukov
6ba3956fd8 Twenty Ten: Correct license information in readme.txt.
props Otto42.
see #33590, #31814.

git-svn-id: https://develop.svn.wordpress.org/trunk@33795 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 16:51:02 +00:00
Drew Jaynes
002e2a0e4a Docs: Add a changelog entry to the set_site_transient_$transient hook doc for the $transient parameter, added in [33738].
Fixes #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33794 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:40:32 +00:00
Drew Jaynes
3734aa1682 Docs: Add a changelog entry to the pre_set_site_transient_$transient hook doc for the $transient parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33793 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:39:11 +00:00
Drew Jaynes
bddb0de4d8 Docs: Add a changelog entry to the site_transient_$transient hook doc for the $transient parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33792 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:38:01 +00:00
Drew Jaynes
9a566ea593 Docs: Add a changelog entry to the pre_site_transient_$transient hook doc for the $transient parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33791 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:36:49 +00:00
Drew Jaynes
c71531275b Docs: Add a changelog entry to the pre_update_site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33790 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:35:35 +00:00
Drew Jaynes
d06525c8a1 Docs: Add a changelog entry to the pre_delete_site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33789 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:34:26 +00:00
Drew Jaynes
3f8132e89e Docs: Add a changelog entry to the pre_add_site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33788 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:33:14 +00:00
Drew Jaynes
9eb92ae5ea Docs: Add a changelog entry to the site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33787 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:31:58 +00:00
Drew Jaynes
0d27e9b012 Docs: Add a changelog entry to the default_site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33786 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:30:44 +00:00
Drew Jaynes
21ed57e09d Docs: Add a changelog entry to the pre_site_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33785 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:29:26 +00:00
Drew Jaynes
e2c8f3ec0d Docs: Add a changelog entry to the pre_set_transient_$transient hook doc for the $transient parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33784 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:28:06 +00:00
Drew Jaynes
86a49119a2 Docs: Add a changelog entry to the transient_$transient hook doc for the $transient parameter, introduced in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33783 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:26:21 +00:00
Drew Jaynes
8336c88273 Docs: Add a changelog entry to the pre_transient_$transient hook doc for the $transient parameter, introduced in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33782 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:24:49 +00:00
Drew Jaynes
958c835f9a Docs: Add a changelog entry to the update_option_{$option} hook doc for the $option parameter, introduced in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33781 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:23:14 +00:00
Drew Jaynes
323ca7e1d3 Docs: Add a changelog entry to the pre_update_option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33780 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:21:18 +00:00
Drew Jaynes
41370b6e97 Docs: Add a changelog entry to the option_$option hook doc for the $option parameter, added in [33738].
See #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33779 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:19:54 +00:00
Drew Jaynes
9973d71384 Docs: Add a changelog entry to the default_option_$option hook doc for the $option parameter, added in [33738].
See #28402


git-svn-id: https://develop.svn.wordpress.org/trunk@33778 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 15:17:33 +00:00
Sergey Biryukov
d5dd61424d Network Admin: Hide the bulk actions checkbox for super admins.
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:48:47 +00:00
Sergey Biryukov
28767e1bac In get_post_type_labels(), ensure that filtered labels contain all required default values.
fixes #33543.

git-svn-id: https://develop.svn.wordpress.org/trunk@33776 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:38:26 +00:00
Sergey Biryukov
923498aaa4 Avoid PHP notices in redirect_canonical() and _wp_menu_item_classes_by_context() if $_SERVER['HTTP_HOST'] is not set.
fixes #32229.

git-svn-id: https://develop.svn.wordpress.org/trunk@33775 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:30:55 +00:00
Helen Hou-Sandi
0c19c94561 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-28 03:16:02 +00:00
John Blackbourn
d89398f945 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.
Fixes #32954
Props boonebgorges, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:56:54 +00:00
Sergey Biryukov
65c07b81c0 Remove wp-includes/comment-functions.php from the $_old_files array. See [33750].
props rachelbaker.
fixes #33569.

git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:39:58 +00:00
John Blackbourn
f312173db5 Improve the efficiency of is_user_member_of_blog() by removing its use of get_blogs_of_user(). Adds additional tests.
Fixes #32472
Props BinaryKitten, sammybeats, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33771 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 20:01:37 +00:00
John Blackbourn
0d0a8353f5 Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().
Fixes #32847


git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:25:15 +00:00
John Blackbourn
e95ce848f9 Correct the hook docs for the user_profile_update_errors action.
Fixes #33537
Props yamchhetri


git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 17:15:54 +00:00
Drew Jaynes
ffb128a3c6 Docs: Add a changelog entry to the pre_option_$option hook doc for the $option parameter, added in [33738].
See #28402


git-svn-id: https://develop.svn.wordpress.org/trunk@33768 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 16:59:17 +00:00
Boone Gorges
718787cd18 Rename param added to wp_list_categories() in [33764] to 'hide_title_if_empty'.
Props vilkatis, DrewAPicture.
Fixes #33565.

git-svn-id: https://develop.svn.wordpress.org/trunk@33767 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 02:08:31 +00:00
Sergey Biryukov
30eb4853f0 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
props peterwilsoncc.
fixes #33419 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-27 00:10:39 +00:00
Boone Gorges
1f7031e2f8 After [33764], fix docblock formatting for wp_list_categories().
See #33460.

git-svn-id: https://develop.svn.wordpress.org/trunk@33765 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 19:42:02 +00:00
Boone Gorges
a684d5d19d Introduce hide_title_if_no_cats parameter to wp_list_categories().
When generating a `<ul>` using `wp_list_categories()`, a title `<li>` element
is put at the top of the term list. Current behavior is that this title `<li>`
appears even when no terms are found. The new `hide_title_if_no_cats` param
allows developers to specify that the title should be hidden when the term list
is empty.

Props vilkatis.
Fixes #33460.

git-svn-id: https://develop.svn.wordpress.org/trunk@33764 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 19:41:55 +00:00
Boone Gorges
91a24f5cca Use proper array documentation formatting for wp_list_categories().
This changeset also corrects a few parameter descriptions, and adds a few that
were previously missing.

Fixes #33556.

git-svn-id: https://develop.svn.wordpress.org/trunk@33763 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 15:29:35 +00:00
Sergey Biryukov
a69c9ff66f Make post meta box toggles accessible.
props joedolson.
fixes #33544.

git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 15:22:57 +00:00
Scott Taylor
46d0feea46 Meta: move WP_Meta_Query into its own file. meta.php loads the new files, so this is 100% BC if someone is loading meta.php directly. New files created using svn cp.
Creates: 
`class-wp-meta-query.php` 
`meta-functions.php` 

`meta.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33761 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 13:01:22 +00:00
Scott Taylor
bb0b507718 Taxonomy: move WP_Tax_Query into its own file. taxonomy.php loads the new files, so this is 100% BC if someone is loading taxonomy.php directly. New files created using svn cp.
Creates: 
`class-wp-tax-query.php` 
`taxonomy-functions.php` 

`taxonomy.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33760 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 12:48:11 +00:00
Scott Taylor
718c1a8d25 Posts: move WP_Post into its own file. post.php loads the new files, so this is 100% BC if someone is loading post.php directly. New files created using svn cp.
Creates: 
`class-wp-post.php` 
`post-functions.php` 

`post.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33759 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 12:39:07 +00:00
Drew Jaynes
2fda97b15a Docs: Add inline-docblocks for the require_once() calls that now bring in the WP_Widget and WP_Widget_Factory classes, as well as general core widgets functionality, as of [33746].
See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33758 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 08:00:35 +00:00
Drew Jaynes
fc691e0457 Docs: Add a file header description and @since version to wp-includes/widget-functions.php, introduced in [33746].
Also adds sub-section headers per the inline documentation standards for syntax.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33757 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:56:30 +00:00
Drew Jaynes
9f61d73c0c Docs: Add a file header to wp-includes/class-wp-widget-factory.php, created when the WP_Widget_Factory class was moved to its own file in [33746].
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33756 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:52:05 +00:00
Drew Jaynes
76f5134023 Docs: Add a file header to wp-includes/class-wp-widget.php, created when the WP_Widget class was moved to its own file in [33746].
It's important for every file in WordPress, regardless of makeup or architecture, to have its own file header, even if the file contains nothing but a class. When parsed, files and classes are mutually exclusive and should be documented with this in mind.

See [33746]. See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33755 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:44:59 +00:00
Weston Ruter
9c4f261598 Customizer: Ensure persistence of unchanged active state for controls, sections, and panels.
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 07:25:20 +00:00
Weston Ruter
e32f3cd3e1 Customizer: Prevent JS error during init when nav_menus panel is removed by plugin.
Fixes #33411 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 06:42:16 +00:00
Scott Taylor
28217ae6a0 Roles: move classes into their own file. capbilities.php loads the new files, so this is 100% BC if someone is loading capbilities.php directly. New files created using svn cp.
Creates: 
`class-wp-roles.php` 
`class-wp-role.php` 
`class-wp-user.php` 
`capbilities-functions.php` 

`capbilities.php` contains only top-level code. Class files only contains classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33752 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 04:57:48 +00:00
Scott Taylor
799f28a918 Rewrite: move WP_Rewrite into its own file. rewrite.php loads the new files, so this is 100% BC if someone is loading rewrite.php directly. New files created using svn cp.
The rewrite functions have all kinds of cross-dependencies (like `WP_Query`), so loading the file by itself would have been bizarre (and still is).

Creates: 
`rewrite-constants.php` 
`rewrite-functions.php` 
`class-wp-rewrite.php` 

`rewrite.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33751 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 04:41:29 +00:00
Scott Taylor
d61669232c Comments: move WP_Comment_Query into its own file. comment.php loads the new files, so this is 100% BC if someone is loading comment.php directly. New files created using svn cp.
Creates: 
`class-wp-comment-query.php` 
`comment-functions.php` 

`comment.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33750 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 04:26:29 +00:00
Scott Taylor
7b58399a45 Users: move WP_User_Query into its own file. user.php loads the new files, so this is 100% BC if someone is loading user.php directly (a lot of plugins do). New files created using svn cp.
Creates: 
`class-wp-user-query.php` 
`user-functions.php` 

`user.php` contains only top-level code. Class file only contains the class. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33749 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 04:19:32 +00:00
Scott Taylor
f4ecd11e10 HTTP: move classes into their own files, http.php loads the new files, so this is 100% BC if someone is loading http.php directly. New files created using svn cp.
`class-http.php` requires functions from `http.php`, so loading it by itself wouldn't have worked.

Creates: 
`class-wp-http-cookie.php` 
`class-wp-http-curl.php` 
`class-wp-http-encoding.php` 
`class-wp-http-proxy.php` 
`class-wp-http-streams.php` 
`http-functions.php` 

`WP_Http` remains in `class-http.php`.

`http.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33748 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 03:55:00 +00:00
Gary Pendergast
2b67add6dd When wp_json_encode() calls json_encode(), the latter will generate warnings if the string contains non-UTF-8 characters. No-one likes warnings, so we need to do something about that.
The good news is, the point of `wp_json_encode()` is to handle those non-UTF-8 characters. It'll totally just fix them up, no problem.

Anyway, we can just ignore those warnings.

Fixes #33524.



git-svn-id: https://develop.svn.wordpress.org/trunk@33747 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 03:25:15 +00:00
Scott Taylor
6c71ee8d84 Widgets: move classes into their own files, widgets.php loads the new files, so this is 100% BC if someone is loading widgets.php directly. New files created using svn cp.
Creates: 
`class-wp-widget.php` 
`class-wp-widget-factory.php` 
`widget-functions.php` 

`widgets.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33746 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 02:39:50 +00:00
Sergey Biryukov
0654d9ed35 Add oEmbed support for ReverbNation.
props rhubbardreverb.
fixes #33207.

git-svn-id: https://develop.svn.wordpress.org/trunk@33745 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 00:28:11 +00:00
Sergey Biryukov
b935049f24 Add 'wp_verify_nonce_failed' action that fires when nonce verification fails.
props johnbillion, garza, Shelob9.
fixes #24030.

git-svn-id: https://develop.svn.wordpress.org/trunk@33744 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-26 00:05:11 +00:00
Sergey Biryukov
4bc9b3db6d Fire the check_ajax_referer action on failure as well as success.
See [33017] for `check_admin_referer`.

props egill.
fixes #33342.

git-svn-id: https://develop.svn.wordpress.org/trunk@33743 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 23:24:39 +00:00
Sergey Biryukov
6598033243 Remove rounded corners from "Choose from the most used tags" result in Tags meta box.
props tyxla.
fixes #31560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 23:13:30 +00:00
Sergey Biryukov
b73b9ed936 Customizer: Use existing decoupled strings in Menu Locations section. See [31941] and [31951].
props egill.
fixes #33416.

git-svn-id: https://develop.svn.wordpress.org/trunk@33741 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:52:45 +00:00
Scott Taylor
4a622d21fb Allow these CSS properties in KSES: min-height', 'max-height', 'min-width', 'max-width'
Props MikeHansenMe.
Fixes #31949.


git-svn-id: https://develop.svn.wordpress.org/trunk@33739 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:45:42 +00:00
Scott Taylor
c76e3b3273 Pass option name to option and transient filters with dynamic names.
Props Viper007Bond, SergeyBiryukov, MikeHansenMe.
Fixes #28402.


git-svn-id: https://develop.svn.wordpress.org/trunk@33738 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:41:53 +00:00
wonderboymusic
20bad276e8 After [33698], wrap the time constants in a DocBlock template.
Props egill.
Fixes #33397.


git-svn-id: https://develop.svn.wordpress.org/trunk@33737 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:20:02 +00:00
Scott Taylor
1fb94edb99 In get_home_url(), import the $pagenow global to avoid having to check if it exists before comparing against it.
Props KalenJohnson.
See #33545.


git-svn-id: https://develop.svn.wordpress.org/trunk@33736 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 21:02:14 +00:00
Scott Taylor
ff7fcf5f04 In WP_Users_List_Table::single_row(), $actions is not always set before being used.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:37:50 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor
755d109d10 Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts.
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:11:27 +00:00
Sergey Biryukov
b59d10ccac Multisite: Add 'invite_user' action that fires immediately after a user is invited to join a site, but before the notification is sent.
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.

git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:47:26 +00:00
Drew Jaynes
40ce8c68fe Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array.
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:14:28 +00:00
Drew Jaynes
e853c467fd Docs: Document the default comment data arguments for wp_new_comment().
Props rachelbaker, DrewAPicture
Fixes #32369.


git-svn-id: https://develop.svn.wordpress.org/trunk@33730 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 17:02:51 +00:00
Scott Taylor
e1b1541932 Media:
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 12:12:59 +00:00
Andrew Ozz
a9b27cbc07 TinyMCE: ensure the wordpress plugin is loaded before calling _createToolbar().
Props hauvong, azaozz. Fixes #33393.

git-svn-id: https://develop.svn.wordpress.org/trunk@33728 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 04:37:27 +00:00
Dion Hulse
3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler.
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 04:31:52 +00:00
Drew Jaynes
bc9e25d053 Docs: Clarify the return description for wp_create_user() to illustrate that a WP_Error object will be returned on failure.
Props jmayhak
Fixes #33321.


git-svn-id: https://develop.svn.wordpress.org/trunk@33725 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 22:22:33 +00:00
Boone Gorges
32cd95e1c1 In WP_Query::parse_tax_query(), allow 'cat' and 'tag' querystrings to be formatted as arrays.
See [33095] #32454 for a previous fix related to custom taxonomies.

Props Veraxus.
Fixes #33532.

git-svn-id: https://develop.svn.wordpress.org/trunk@33724 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 21:21:49 +00:00
Scott Taylor
5f3879e37c With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration.
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 21:18:20 +00:00
Scott Taylor
dc577d6072 WP_Query: add changelog for the title param after [33706]
Props dimadin.
Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33722 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 20:09:25 +00:00
Drew Jaynes
7b7cd91984 Docs: Improve pared formatting of the oEmbed providers tables by removing the unrecognized first and last rows in the hook docs for the oembed_providers filter.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33720 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 04:37:40 +00:00
Gary Pendergast
845d31baf9 oEmbed: Remove blip.tv as an oEmbed provider, the service has been shut down.
Vale, blip.tv.

Fixes #33522.

Props rabmalin.



git-svn-id: https://develop.svn.wordpress.org/trunk@33719 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 04:11:13 +00:00
Gary Pendergast
bf3d36e0b6 WPDB: get_table_from_query() didn't find table names with hyphens in them.
Props dustinbolton for the fix.

Fixes #33470.



git-svn-id: https://develop.svn.wordpress.org/trunk@33718 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-24 00:18:49 +00:00
Drew Jaynes
83476bb77f Docs: Add a description and example to the hook docs for the navigation_markup_template filter, introduced in [33714].
Since the value of the filter is passed through `sprintf()` it's important to note that any filtered output needs to contain the expected specifiers.

See #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33717 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 18:07:41 +00:00
Drew Jaynes
3969554606 Docs: Better clarify that the $post_type parameter for the get_usernumposts filter and count_user_posts() can accept either a single post type or array of post types.
Props tyxla
See #33481. Fixes #33520.


git-svn-id: https://develop.svn.wordpress.org/trunk@33716 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 17:45:51 +00:00
Drew Jaynes
797b6c4d7c Docs: Add better documentation for all accepted values for the fields argument in get_terms().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33715 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 17:39:07 +00:00
Scott Taylor
d8ba4fde1b Add a filter to _navigation_markup: 'navigation_markup_template'
Props joedolson, mordauk.
Fixes #31315.


git-svn-id: https://develop.svn.wordpress.org/trunk@33714 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:33:25 +00:00
Scott Taylor
9596ae0993 Posts List Table:
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 16:27:44 +00:00
Drew Jaynes
dfa9da5356 Docs: Fix a minor alignment issue in the DocBlock for get_pagenum_link().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33712 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-23 07:18:19 +00:00
Boone Gorges
b01b3be23e In wp_delete_term(), the $deleted_term object passed to filters should be generated before term relationships are deleted.
This allows the `count` property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.

git-svn-id: https://develop.svn.wordpress.org/trunk@33711 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 19:42:30 +00:00
Boone Gorges
6c3449b710 Pass the $public_only value to 'get_usernumposts' filter.
[32523] introduced the `$public_only` parameter to `count_user_posts()`. That
changeset was supposed to pass `$public_only` to the 'get_usernumposts' filter
at the end of the function, but only the documentation was modified, not the
filter itself.

This changeset also fixes an incorrect variable name in the docblock for
the same filter.

Props swisspidy, tmatsuur.
Fixes #33481 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33710 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 18:58:18 +00:00
Scott Taylor
a679368d8b Add some JS Docs for Customizer.
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33709 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:23:37 +00:00
Scott Taylor
7e894153a4 In wp_insert_user(), add a filter: insert_user_meta, to filter a user's meta values and keys before the user is created or updated.
Props tharsheblows, chriscct7, DrewAPicture.
Fixes #31549.


git-svn-id: https://develop.svn.wordpress.org/trunk@33708 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:11:42 +00:00
Scott Taylor
36a9be2af5 In wp_sanitize_redirect(), don't eat @ characters. According to RFC 3986, "@" is a perfectly valid character in a URL path or query string.
Adds unit test.

Props markjaquith.
Fixes #18818.


git-svn-id: https://develop.svn.wordpress.org/trunk@33707 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 17:04:17 +00:00
Scott Taylor
dc48f3d795 Query:
Add a query var, `title`, that allows you to query posts by `post_title`. To accomplish this now, you have to do something like:

{{{
$tacos = get_posts( [
  'post_type' => 'taco',
  's' => $name,
  'exact' => true,
  'sentence' => true,
  'post_status' => 'publish',
  'fields' => 'ids',
  'posts_per_page' => 1
] );
}}}

Adds unit tests.

Fixes #33074.


git-svn-id: https://develop.svn.wordpress.org/trunk@33706 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:58:21 +00:00
Scott Taylor
a70e0183e5 Ensure that attachment_url_to_postid() matches cross-scheme when front-end and back-end schemes are different.
Adds unit test.

Props welcher.
Fixes #33109.


git-svn-id: https://develop.svn.wordpress.org/trunk@33705 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:38:09 +00:00
Scott Taylor
e76b48a26c update-core.php help docs, update string to include translations: themes, plugins, and translations
Props netweb, DrewAPicture.
Fixes #28201.


git-svn-id: https://develop.svn.wordpress.org/trunk@33704 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-22 16:24:58 +00:00
Scott Taylor
326b67c0aa In wpdb::get_col_length(), breaks are not necessary when a case returns
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33701 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:40:55 +00:00
Scott Taylor
5d494bae12 Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double')
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33700 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:35:31 +00:00
Scott Taylor
a14be1fffa In _WP_Editors::editor_settings(), $first_run is unused.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33699 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:29:31 +00:00
Aaron Jorbin
3b24c024b5 Add new constant MONTH_IN_SECONDS and expand time convenience documentation.
The "month" isn't really a month.  It's a WordPress Month. As the docs make clear, it's not about accuracy as much as it about convenience.  This adds a missing step in the time convenience constants. 

Props egill
Fixes #33397




git-svn-id: https://develop.svn.wordpress.org/trunk@33698 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:15:52 +00:00
Scott Taylor
e4f8047716 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:12:56 +00:00
Weston Ruter
d40b6eab66 Widgets: Switch back to using array_key_exists() instead of isset() for widget instance existence check.
Reverts unnecessary change in [32602] since `array_key_exists()` does actually work with `ArrayIterator` objects.

See #32474.
Fixes #33442.


git-svn-id: https://develop.svn.wordpress.org/trunk@33696 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 18:08:53 +00:00
Scott Taylor
a1e5332489 Make 'Docs Committer' translatable.
Props dimadin. 
Fixes #33424.


git-svn-id: https://develop.svn.wordpress.org/trunk@33695 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 17:46:54 +00:00