Commit Graph

27973 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90) 8422a51b98 Improvements to [30333]:
* Move `.hide-if-no-js` class to table row
* Add a wrapper class
* Add missing translators comment

see #30264.

git-svn-id: https://develop.svn.wordpress.org/trunk@30334 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 15:53:52 +00:00
John Blackbourn d93bad3cd3 Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared.
See #30264.
Props jorbin, ocean90, johnbillion



git-svn-id: https://develop.svn.wordpress.org/trunk@30333 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 15:20:42 +00:00
Dominik Schilling (ocean90) c55a06370b Fix selector for the "Live Widget Previews" feature pointer.
props rzen.
fixes #30158.

git-svn-id: https://develop.svn.wordpress.org/trunk@30332 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:49:42 +00:00
Dominik Schilling (ocean90) 103788b4ad Twenty Fifteen: Add a transparent border to a link in the footer to avoid jumpiness on hover.
props iamtakashi.
fixes #30332.

git-svn-id: https://develop.svn.wordpress.org/trunk@30331 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:41:09 +00:00
Dominik Schilling (ocean90) 2aac7ef27c Color Picker: Allow to override `mode` and `width` values for Iris via wpColorPicker options.
props jtsternberg.
fixes #30182.

git-svn-id: https://develop.svn.wordpress.org/trunk@30330 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:33:27 +00:00
Dominik Schilling (ocean90) 8d476eee4f Customizer: Improve ability to filter active state for widget area Customizer sections.
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.

props westonruter.
fixes #30235.

git-svn-id: https://develop.svn.wordpress.org/trunk@30329 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:18:01 +00:00
Boone Gorges 2a941720be Correct `@since` tag in `count_user_posts()` docs.
Props pavelevap, DrewAPicture.
See #21364.

git-svn-id: https://develop.svn.wordpress.org/trunk@30328 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:14:15 +00:00
Dominik Schilling (ocean90) 8d61151356 Improve keyboard accessibility on Custom Header and Custom Background screen.
props florianziegler.
fixes #29289.

git-svn-id: https://develop.svn.wordpress.org/trunk@30327 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 11:59:23 +00:00
Dominik Schilling (ocean90) 9c6b323976 Customizer: Prevent double-encoding in `WP_Customize_Control`.
Control's label and description may include HTML.

fixes #29572.

git-svn-id: https://develop.svn.wordpress.org/trunk@30326 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 11:43:06 +00:00
Ian Stewart 6f98ce5a45 Twenty Fifteen: cleaning up JS introduced in r30305 that doesn't pass jshint.
Props boonebgorges, fixes #29988.



git-svn-id: https://develop.svn.wordpress.org/trunk@30325 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 03:17:42 +00:00
Ian Stewart d97665d331 Twenty Fifteen: unfix the sidebar if we have a menu with submenus as there is a chance visitors might not be able to scroll down to see submenus in some situations.
Props mattwiebe, fixes #30208.



git-svn-id: https://develop.svn.wordpress.org/trunk@30324 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 03:08:21 +00:00
Boone Gorges 5e730a0cf9 Pass query object to 'the_post' filter.
Props tlovett1.
Fixes #30327.

git-svn-id: https://develop.svn.wordpress.org/trunk@30323 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 02:24:43 +00:00
Boone Gorges 3544e20e9a Introduce `$post_type` param for `count_user_posts()`.
Props Caspie, engelen, DrewAPicture.
Fixes #21364.

git-svn-id: https://develop.svn.wordpress.org/trunk@30322 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 02:18:30 +00:00
Andrew Ozz 403cf989ec Twenty Fifteen: reduce the margins on the editor body in esitor-style.css. Fixes #30331.
git-svn-id: https://develop.svn.wordpress.org/trunk@30321 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 02:01:29 +00:00
Boone Gorges f5d88c355e Manually delete fixture in `test_mysqli_flush_sync()`.
This test creates a dummy post and subsequently runs a query containing
`DROP PROCEDURE`. This latter query implies a `COMMIT`, which means that the
post is not cleaned up for later tests. Manually deleting the post with
`wp_delete_post()` solves this problem.

Fixes #28155.

git-svn-id: https://develop.svn.wordpress.org/trunk@30320 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 01:59:49 +00:00
azaozz ca39f65025 Fix typo in translatable string, see #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30319 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 00:59:03 +00:00
Andrew Ozz 307639954a TinyMCE: enhance the inline toolbar for images:
- Add alignment (left, center, right, none) buttons.
- Position the menu above the image when possible, except on iOS.
- Fix selecting images on iOS.
First run, part props avryl. See #30147.

git-svn-id: https://develop.svn.wordpress.org/trunk@30318 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 00:55:22 +00:00
Ian Stewart 5a31b9772a Twenty Fifteen: improve appearance of page links when there are tons of pages to link to
Props iamtakashi, fixes #30301



git-svn-id: https://develop.svn.wordpress.org/trunk@30317 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 23:38:02 +00:00
Ian Stewart 879671c159 Twenty Fifteen: adding context to pagination links for screenreaders.
Props afercia, iamtakashi, fixes #30152



git-svn-id: https://develop.svn.wordpress.org/trunk@30316 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 23:25:51 +00:00
Ian Stewart 0ac9a44244 Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.
Props celloexpressions, iandstewart, fixes #30316



git-svn-id: https://develop.svn.wordpress.org/trunk@30315 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 23:00:28 +00:00
Ian Stewart 23259d37ef Twenty Fifteen: adding context to page links for screenreaders.
Props afercia, fixes #30174.



git-svn-id: https://develop.svn.wordpress.org/trunk@30314 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 22:54:32 +00:00
Helen Hou-Sandi 7514ac3218 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.


git-svn-id: https://develop.svn.wordpress.org/trunk@30313 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 20:27:04 +00:00
Ian Stewart 15af512035 Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags.
Props aprea, obenland, fixes #30319



git-svn-id: https://develop.svn.wordpress.org/trunk@30312 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 17:20:28 +00:00
Dion Hulse e542c7f7b6 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
git-svn-id: https://develop.svn.wordpress.org/trunk@30311 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 10:43:09 +00:00
Dion Hulse 14d164397a Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
See #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@30310 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 03:05:31 +00:00
Dominik Schilling (ocean90) 4175d8a922 Customizer: Add support for the media library in Background Image controls.
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.

props celloexpressions, and ericlewis for docs.
see #21483.

git-svn-id: https://develop.svn.wordpress.org/trunk@30309 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 23:51:48 +00:00
Dominik Schilling (ocean90) 3566ac62c8 Customizer: Trigger `widget-added` event when initializing.
Widget controls are now added to the pane dynamically via JavaScript, see #28709.
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.

props westonruter.
fixes #30236.

git-svn-id: https://develop.svn.wordpress.org/trunk@30308 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:45:47 +00:00
Dominik Schilling (ocean90) 3b3be684e8 Customizer: Use `jQuery.fn.toggle()` instead of `slideUp`/`slideDown` if panel/section/control is not inserted into DOM yet.
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709.

props westonruter.
fixes #30251.

git-svn-id: https://develop.svn.wordpress.org/trunk@30307 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:36:51 +00:00
Dominik Schilling (ocean90) 63642323a5 Customizer: When navigating around the site within the Customizer preview, update the document title.
props westonruter.
fixes #28542.

git-svn-id: https://develop.svn.wordpress.org/trunk@30306 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:28:38 +00:00
Ian Stewart 88e80131df Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
Props celloexpressions, see #29988



git-svn-id: https://develop.svn.wordpress.org/trunk@30305 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 19:35:40 +00:00
Ian Stewart 8454637689 Twenty Fifteen: simplify the code used to generate screen reader text for the is_home title.
Props davidakennedy, fixes #30305



git-svn-id: https://develop.svn.wordpress.org/trunk@30304 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 19:23:47 +00:00
Ian Stewart eeda30610c Twenty Fifteen: create consistent spacing with embeds and images.
Props afercia, fixes #30286



git-svn-id: https://develop.svn.wordpress.org/trunk@30303 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 19:03:55 +00:00
Ian Stewart 85df1aea07 Twenty Fifteen: simpler CSS by using divs instead of spans for menu descriptions.
Props philiparthurmoore, fixes #30296



git-svn-id: https://develop.svn.wordpress.org/trunk@30302 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 19:01:47 +00:00
Boone Gorges 96eb9a93d9 Correct grammar error in `WP_Date_Query` error message.
Props Offereins.
See #25834.

git-svn-id: https://develop.svn.wordpress.org/trunk@30301 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 14:55:52 +00:00
Boone Gorges a26cf7ba6e Improve localization for `WP_Date_Query` error strings.
* Don't create an extra variable for the string when it's only used once.
* Avoid using `<code>` HTML tags inside of translatable string.
* Improve data types and escaping on sprintfed values.

Props dd32.
Fixes #25834.

git-svn-id: https://develop.svn.wordpress.org/trunk@30300 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 13:24:01 +00:00
Gary Pendergast c2fb136b47 wpdb: When flushing results on a mysqli connection, make sure that `wpdb::$dbh` is a valid mysqli connection handle.
Fixes a unit test failure introduced in [30297].

Fixes #28155.

Props soulseekah.



git-svn-id: https://develop.svn.wordpress.org/trunk@30299 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 02:16:19 +00:00
Boone Gorges df11fb8593 Exclude external-http tests when running `phpunit`.
The external-http tests are very slow, and `Wp_Http` functionality is fairly
isolated, so the benefits of skipping these tests by default outweigh the
risks.

A `grunt phpunit:external-http` subtask has been added, to ensure that the
tests are executed during exhaustive runs of the test suite, such as in
continuous integration.

Fixes #30304.

git-svn-id: https://develop.svn.wordpress.org/trunk@30298 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 14:48:28 +00:00
Gary Pendergast 4b1aa89206 `wpdb::flush()` was not flushing results correctly when using mysqli.
This change also allows stored procedures or queries made with `mysqli_multi_query()` to be flushed.

Includes unit tests.

Fixes #28155.

Props soulseekah.


git-svn-id: https://develop.svn.wordpress.org/trunk@30297 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 05:39:50 +00:00
Andrew Ozz c8340a2cda TinyMCE: enable direct calls to `_WP_Editors::wp_mce_translation()`. When using TinyMCE directly, this makes it easier to load the translation of the default strings. Fixes #30293.
git-svn-id: https://develop.svn.wordpress.org/trunk@30296 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 02:07:00 +00:00
Boone Gorges 3c360968ef Fix PHP notice in `Tests_Feed_RSS2::test_items()`.
A notice was being thrown when `get_the_tags()` returned false, and `foreach()`
was run over that return value.

See [30283].

git-svn-id: https://develop.svn.wordpress.org/trunk@30295 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 02:04:22 +00:00
Andrew Ozz d011f4ef00 TinyMCE: remove strings that are not translated before outputting the translations. Fixes #27797.
git-svn-id: https://develop.svn.wordpress.org/trunk@30294 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 01:59:23 +00:00
Andrew Ozz 18f75bf2f7 Heartbeat:
- Use the page visibility API (when available) and document.hasFocus() instead of window.onfocus/onblur. Improves speeding up/slowing down the interval and works for iframes by default.
- Add a setting for minimal interval. Maximum value is 10 min. This overrides all other intervals and cannot be changed after setting it at initialization. Can be used to reduce the frequency of requests on hosts that have low limits for used CPU time, etc.
- Extend the setting of interval to support 120 sec. (60 sec, is still the default).
- Always suspend after one hour of keyboard/mouse/touch inactivity.
Fixes #29779.

git-svn-id: https://develop.svn.wordpress.org/trunk@30293 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-10 01:46:04 +00:00
Gary Pendergast 3b3a33b583 WPDB's `__get()` function should perform strict comparisons against member names
git-svn-id: https://develop.svn.wordpress.org/trunk@30292 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-09 12:03:31 +00:00
Aaron Jorbin 218924d9ee Remove failing Unbalanced tags tests
Patch with tests added to #6297 for use in the future

Props MikeHansenMe for creating patch of current unit test

see #30284


git-svn-id: https://develop.svn.wordpress.org/trunk@30291 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 23:14:28 +00:00
Aaron Jorbin 44825185f7 Remove failing shortcode unit tests
Test added to #14050 in case we want to include it in a future fix.

see #30284



git-svn-id: https://develop.svn.wordpress.org/trunk@30290 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 22:50:30 +00:00
Aaron Jorbin e7e27c2e4d Remove failing uploadfile test in trunk
The test has been added to #11946 and can be readded when that ticket is fixed.

Props MikeHansenMe for creating patch of current unit test

See #30284



git-svn-id: https://develop.svn.wordpress.org/trunk@30289 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 21:55:41 +00:00
Drew Jaynes (DrewAPicture) 68f8703893 Fix incorrect documentation in the DocBlocks for `get_lastpostmodified()` and `_get_last_post_time()`.
Props ericlewis for the initial patch.
Fixes #30249.


git-svn-id: https://develop.svn.wordpress.org/trunk@30287 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 21:07:46 +00:00
Jeremy Felt 211c7ac373 Move tests for ms_files_rewriting to separate group, ms-files
When the `ms_files_rewriting` flag is enabled, `ms_upload_constants()` is required to properly set upload directory constants. Once this fires, it is impossible to clean up for a non `ms_files_rewriting` test by turning the option back off.

Excluding these tests by default offer a more consistent environment overall. Any tests written for uploaded files in multisite should ideally have a correspondign test in this area.

This commit also moves existing `ms_files_rewriting` tests for `test_switch_upload_dir()`.

Fixes #30256


git-svn-id: https://develop.svn.wordpress.org/trunk@30286 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 21:07:05 +00:00
Boone Gorges ffcfc0573b Remove failing test related to post galleries.
It relied on the old _WPDataset technique, which is no longer used.

The test has been added to #UT30 as a patch, in case anyone wants to make
future use of it.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30285 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 21:01:39 +00:00
Drew Jaynes (DrewAPicture) 72cc949b5d Fix the syntax for some status-related documentation introduced in [30155].
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30284 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 20:55:14 +00:00