Commit Graph

33530 Commits

Author SHA1 Message Date
Konstantin Obenland
12ac7b2998 Themes: Clear floated theme cards on Themes page.
Also maintains visual separation for Broken Themes table on searches that
return no results.

See [36171] for `.wp-clearfix`.

Props 5um17, obenland, valendesigns, afercia.
Fixes #26646.



git-svn-id: https://develop.svn.wordpress.org/trunk@36270 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 17:12:17 +00:00
Pascal Birchler
13896125d5 Docs: Revert [36268] as the global is indeed used, just via the superglobal.
Fixes #35413.

git-svn-id: https://develop.svn.wordpress.org/trunk@36269 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 12:25:37 +00:00
Pascal Birchler
d7ed4900a1 Docs: Fix incorrect DocBlock for wp_get_attachment_url().
The documented `$pagenow` global isn't used in the function.

Props sebastian.pisula.
Fixes #35413.

git-svn-id: https://develop.svn.wordpress.org/trunk@36268 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 12:07:30 +00:00
Andrea Fercia
9a9278ca1a After [36263] escape filterable HTML output.
Props adamsilverstein.
Fixes #35064.

git-svn-id: https://develop.svn.wordpress.org/trunk@36267 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 08:57:41 +00:00
Pascal Birchler
3a358c33d3 Introduce wp_get_raw_referer() to retrieve unvalidated referer.
For things like redirects `wp_get_referer()` should be used instead.

Props voldemortensen for initial patch.
Fixes #27152.

git-svn-id: https://develop.svn.wordpress.org/trunk@36266 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-12 08:31:10 +00:00
Andrea Fercia
baaa8946a2 Accessibility: Remove title attributes from the Terms list table.
Fixes #35187.

git-svn-id: https://develop.svn.wordpress.org/trunk@36265 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 23:30:00 +00:00
Andrea Fercia
6c2876acce Menus screen: improve responsiveness of select elements.
Props Luan-Ramos, sagarjadhav.
Fixes #31826.

git-svn-id: https://develop.svn.wordpress.org/trunk@36264 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 23:04:40 +00:00
Andrea Fercia
e6297676fb Accessibility: Remove title attributes from the General Settings screen.
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.

Props afercia, perezlabs.
Fixes #35064.

git-svn-id: https://develop.svn.wordpress.org/trunk@36263 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 22:53:10 +00:00
Weston Ruter
8ad1df35f8 Customizer: Re-use list of components to eliminate code duplication.
Introduces protected `WP_Customize_Manager::$components` to store list of loaded core components filtered by `customize_loaded_components`.

Props DrewAPicture.
See #35242
See #33552.
Fixes #35354.


git-svn-id: https://develop.svn.wordpress.org/trunk@36262 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 20:27:40 +00:00
Weston Ruter
2fa620e4c3 Customizer: Prevent erroneously directing user to login screen when closing.
Fixes issue where user gets stuck at login screen after trying to close the app if previously they had to first login to access the Customizer. Prevents `WP_Customize_Manager::get_return_url()` from using `wp-login.php` as a referer.

Props chandrapatel.
See #32637.
Fixes #35355.


git-svn-id: https://develop.svn.wordpress.org/trunk@36261 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 18:50:30 +00:00
Andrea Fercia
68d4b23608 Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.
Fixes #35401 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36260 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 13:14:18 +00:00
Dion Hulse
c4526edeec Multisite: The networks group should be global.
Fixes #35251.


git-svn-id: https://develop.svn.wordpress.org/trunk@36258 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 05:03:35 +00:00
Boone Gorges
68bc0fc216 Add missing param to 'comments_template_query_args'.
As introduced in [36235].

Props birgire.
See #34442.

git-svn-id: https://develop.svn.wordpress.org/trunk@36256 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-11 02:27:43 +00:00
Pascal Birchler
844e1b6e7e After [36254], commit all the necessary files and not just the unit test.
git-svn-id: https://develop.svn.wordpress.org/trunk@36255 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 19:06:03 +00:00
Pascal Birchler
94992e25ae Rewrite: Ensure WP_Rewrite::flush_rules() does not delete the 'rewrite_rules' option.
Instead, the option gets updated to an empty string.
Adds unit tests.

Props SergeyBiryukov, jesin, voldemortensen.
Fixes #29107.

git-svn-id: https://develop.svn.wordpress.org/trunk@36254 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 19:01:13 +00:00
Pascal Birchler
519051b305 Permalinks: Ensure the page hierarchy is correct for sample permalinks.
Fixes #35368.

git-svn-id: https://develop.svn.wordpress.org/trunk@36253 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 18:27:06 +00:00
Boone Gorges
28818255c2 Don't reset index keys when trimming results of term queries.
`array_slice()` must be told to preserve keys when the query results exceed the
limit specified the 'number' parameter, so that `id=>parent` and other
id-indexed return value formats don't get mangled.

Props fantasyworld, wpdelighter.
Fixes #35382.

git-svn-id: https://develop.svn.wordpress.org/trunk@36252 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 04:05:26 +00:00
Boone Gorges
e75a1f5ab3 Avoid invalid SQL when building ORDER BY clause using long search strings.
The introduction of negative search terms in 4.4 [34934] introduced the
possibility that the ORDER BY clause of a search query could be assembled in
such a way as to create invalid syntax. The current changeset fixes this by
ensuring that the ORDER BY clause corresponding to the search terms is
excluded when it would otherwise be empty.

Props salvoaranzulla.
Fixes #35361.

git-svn-id: https://develop.svn.wordpress.org/trunk@36251 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 03:25:15 +00:00
John Blackbourn
ba5f0fdc7b Docs: Various docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36250 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 01:25:44 +00:00
John Blackbourn
61fbfa9947 Emoji: Explictly use https as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.
Fixes #35376
Props ocean90


git-svn-id: https://develop.svn.wordpress.org/trunk@36249 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 01:23:49 +00:00
John Blackbourn
f0a706d1eb Comments: Correct the docblocks for various methods in the comment list table class.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36248 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-10 00:51:35 +00:00
John Blackbourn
6681e9701c Taxonomy: More tests for unregister_taxonomy().
See #35227


git-svn-id: https://develop.svn.wordpress.org/trunk@36247 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 23:34:27 +00:00
Eric Andrew Lewis
2670f66c76 Login is not a verb, change "login" to "log in".
See #35387


git-svn-id: https://develop.svn.wordpress.org/trunk@36246 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 21:07:44 +00:00
Eric Andrew Lewis
fb1852fe5c Users: Fix incorrect docs for user authentication and login functions.
Fixes #35387


git-svn-id: https://develop.svn.wordpress.org/trunk@36245 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 20:51:13 +00:00
Pascal Birchler
f4b3c2453c Taxonomy: Use Invalid taxonomy instead of Invalid Taxonomy for error strings.
git-svn-id: https://develop.svn.wordpress.org/trunk@36244 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 15:15:55 +00:00
Pascal Birchler
eafbcb3b6e Taxonomy: Introduce unregister_taxonomy().
This new function can be used to completely unregister non built-in taxonomies.

Fixes #35227.

git-svn-id: https://develop.svn.wordpress.org/trunk@36243 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:57:22 +00:00
Pascal Birchler
d92ead50c8 Ensure wp_get_referer() returns false when the referrer URL is the current URL.
Adds unit tests.

Fixes #19856.

git-svn-id: https://develop.svn.wordpress.org/trunk@36242 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:35:03 +00:00
swissspidy
0002ff515b Media: After [36240], remove some unneeded whitespace.
Props ocean90.
See #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36241 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:28:02 +00:00
Pascal Birchler
54134dd49b Media: Fix wp_audio_shortcode and wp_video_shortcode attributes handling.
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.

Fixes #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36240 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:17:02 +00:00
Dion Hulse
0e73cc3da4 Tests: Add more paged canonical tests for page_on_front.
See #35344.


git-svn-id: https://develop.svn.wordpress.org/trunk@36238 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 08:08:47 +00:00
Dion Hulse
3cce67f8bc Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front.
This fixes an issue where pages become inacessible on a front page post.

Fixes #35344 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36237 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 07:32:42 +00:00
Dion Hulse
5f55910b5c Tests: Remove some debug that's slipped in at some point.
git-svn-id: https://develop.svn.wordpress.org/trunk@36236 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 06:11:58 +00:00
Boone Gorges
530ffc712f Introduce comments_template_query_args filter.
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.

Props birgire.
Fixes #34442.

git-svn-id: https://develop.svn.wordpress.org/trunk@36235 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 04:43:33 +00:00
Boone Gorges
32194797d5 Clarify return types in get_option() documentation.
The new note specifies that scalar values will always be returned as strings.

Fixes #31820.

git-svn-id: https://develop.svn.wordpress.org/trunk@36234 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 03:11:59 +00:00
Andrew Ozz
3fba1e59d7 Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio.
Fixes #35363.

git-svn-id: https://develop.svn.wordpress.org/trunk@36233 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 02:21:28 +00:00
John Blackbourn
021401424b Docs: @param fixes for a variety of docblocks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36232 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:44:31 +00:00
John Blackbourn
aaa61e80e4 Docs: Correct the parameter docs for various Heartbeat filters and functions.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36231 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:36:45 +00:00
John Blackbourn
5b2c1a52cc Feeds: Remove the rss-http feed type, unused since r32468.
See #15110


git-svn-id: https://develop.svn.wordpress.org/trunk@36230 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:19:31 +00:00
Eric Andrew Lewis
75cc6be57a Add documentation for parseData() and ajaxDel() in wp-lists.js.
Fixes #35360.


git-svn-id: https://develop.svn.wordpress.org/trunk@36229 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 00:04:57 +00:00
Eric Andrew Lewis
5c7043593b Cron: Add the cron lock timestamp to the 'cron_request' filter arguments.
Fixes #31307


git-svn-id: https://develop.svn.wordpress.org/trunk@36228 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 23:53:10 +00:00
Boone Gorges
ca642a8562 Use a more generous selector when setting up tag suggestion.
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.

Props johnjamesjacoby..
Fixes #35349.

git-svn-id: https://develop.svn.wordpress.org/trunk@36227 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 23:17:21 +00:00
Boone Gorges
8dbc62d267 In comments_template(), don't run hierarchical queries if comment threading is disabled.
When hierarchical=true, `WP_Comment_Query` will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.

We address the issue by refraining from querying hierarchically when comment
threading is disabled.

Props jmdodd.
Fixes #35378.

git-svn-id: https://develop.svn.wordpress.org/trunk@36226 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 22:16:11 +00:00
Eric Andrew Lewis
5304745be0 Permalinks: Make get_post_type_archive_link() work for the 'post' post type.
Props jjj.
See #19902. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36225 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 22:00:48 +00:00
Boone Gorges
b5a4504f7e Introduce 'author_url' param to WP_Comment_Query.
Props swissspidy.
Fixes #35377.

git-svn-id: https://develop.svn.wordpress.org/trunk@36224 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 21:51:50 +00:00
Andrea Fercia
05934ebd87 Media: make the Image Editor usable with a keyboard.
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.

git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:12:11 +00:00
Andrea Fercia
fa998d9b8c Accessibility: remove the title attribute from the get_search_form() HTML5 search field.
It was added in [23801] as a workaround for issues with very old browser/screen reader combos (Jaws7/IE6).
No more necessary today. Reduces redundancy and noise for screen reader users.

See #16539.
Fixes #33952.

git-svn-id: https://develop.svn.wordpress.org/trunk@36222 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:00:39 +00:00
Konstantin Obenland
e4b8679d17 Plugins: Use plugin file rather than slug as identifier
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.



git-svn-id: https://develop.svn.wordpress.org/trunk@36221 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 17:47:18 +00:00
Dion Hulse
9fc247408c Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules.
Props sarciszewski.
Fixes #35327 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36220 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 03:27:58 +00:00
Weston Ruter
de5f72567a Customizer: Improve _doing_it_wrong() message when widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel().
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.

Amends [36216].
Props DrewAPicture.
Fixes #35242.


git-svn-id: https://develop.svn.wordpress.org/trunk@36219 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 18:43:11 +00:00
Pascal Birchler
1f47f9c5f5 Tests: Fix unit tests after [36217].
See #35236.

git-svn-id: https://develop.svn.wordpress.org/trunk@36218 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 10:16:47 +00:00