Commit Graph

39424 Commits

Author SHA1 Message Date
Sergey Biryukov
d72a0092d5 Site Health: Display a correct error message for a failing request in wp_version_check() test.
Props Clorith, axaak.
Fixes #46814.

git-svn-id: https://develop.svn.wordpress.org/trunk@45118 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:27:33 +00:00
Felix Arntz
a511415d0a Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.


git-svn-id: https://develop.svn.wordpress.org/trunk@45117 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 16:59:34 +00:00
Felix Arntz
075a85c05e Bootstrap/Load: Do not redefine constants because tests don't like it.
See #46045.


git-svn-id: https://develop.svn.wordpress.org/trunk@45116 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:52:39 +00:00
Felix Arntz
dca58d725e Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.


git-svn-id: https://develop.svn.wordpress.org/trunk@45115 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:32:31 +00:00
Felix Arntz
7f6adbb345 Bootstrap/Load: Ensure WP_Fatal_Error_Handler does not conflict with existing mechanisms treating fatal errors.
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.


git-svn-id: https://develop.svn.wordpress.org/trunk@45114 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:19:50 +00:00
Pascal Birchler
99a0145ba1 Site Health: Remove unused $wp_config_path variable.
Discovered and fixed during WordCamp London 2019 contributor day.

Props m_uysl.
Fixes #46808.


git-svn-id: https://develop.svn.wordpress.org/trunk@45113 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 11:08:30 +00:00
Alex Shiels
45771f9f11 Upgrade/Install: Add more context in signature verify failures.
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.

Props dd32.
See #39309.


git-svn-id: https://develop.svn.wordpress.org/trunk@45112 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 05:19:15 +00:00
Andrew Ozz
9945849317 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45111 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:53:45 +00:00
Jonathan Desrosiers
af60a3c2bf Site Health: Ensure the user locale is listed in debug information.
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.

git-svn-id: https://develop.svn.wordpress.org/trunk@45110 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:23:29 +00:00
Jonathan Desrosiers
0afc9b5119 Twenty Eleven: Correct linear-gradient direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.

git-svn-id: https://develop.svn.wordpress.org/trunk@45109 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 18:25:21 +00:00
Sergey Biryukov
a0ca5afd89 Site Health: Use wp_get_upload_dir() instead of wp_upload_dir(), remove duplicate call.
Props m_uysl.
Fixes #46729.

git-svn-id: https://develop.svn.wordpress.org/trunk@45108 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:19:53 +00:00
Sergey Biryukov
681edf04bc Site Health: Use correct property for database-related messages.
Props mukesh27, birgire.
Fixes #46783.

git-svn-id: https://develop.svn.wordpress.org/trunk@45107 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:00:06 +00:00
Sergey Biryukov
c8913b375e PHPCS: Fix WPCS violations in [45104].
See #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45106 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:13:31 +00:00
Sergey Biryukov
fa0ad447c8 Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes.
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735.

git-svn-id: https://develop.svn.wordpress.org/trunk@45105 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:00:56 +00:00
Andrew Ozz
d5d4979921 Site health:
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45104 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 23:32:31 +00:00
Sergey Biryukov
f6f02a327f Docs: Remove an empty line between @param and @return in the tests added in [45101], per documentation coding standards.
See #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45103 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:21:19 +00:00
Sergey Biryukov
3b7028104b Site Health: Use an established pattern for numbered placeholders in translator comments in WP_Debug_Data.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45102 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:17:18 +00:00
Sergey Biryukov
ffbc0e3b4e Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.
Add unit tests missed in [45100].

Props Toro_Unit, birgire.
See #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45101 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:14:19 +00:00
Sergey Biryukov
f4e57f92e4 Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45100 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:12:11 +00:00
Sergey Biryukov
b3a625fdf1 Site Health: i18n audit, take 1.
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.

Props ocean90, SergeyBiryukov.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45099 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 21:31:43 +00:00
Sergey Biryukov
e4a0f2dcab Docs: Fix typo in a comment in unzip_file().
Props mukesh27.
Fixes #46766.

git-svn-id: https://develop.svn.wordpress.org/trunk@45098 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:33:47 +00:00
Jonathan Desrosiers
91ac8aeefc Administration: Remove unnecessary transition-delay values from Dashicons.
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.

See #43195.
Fixes #46774.

git-svn-id: https://develop.svn.wordpress.org/trunk@45097 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:18:35 +00:00
Sergey Biryukov
03135696bd Twenty Fifteen: Fix typo in a comment for print styles.
Props mukesh27.
Fixes #46767.

git-svn-id: https://develop.svn.wordpress.org/trunk@45096 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:06:40 +00:00
Sergey Biryukov
fbf73bc8de Site Health: Add missing i18n for Security and Performance badge labels.
Props iworks.
Fixes #46755. See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45095 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 10:07:36 +00:00
Sergey Biryukov
adfe5e271b Docs: Fix more typos in WP_Site_Health DocBlocks.
See #46753.

git-svn-id: https://develop.svn.wordpress.org/trunk@45094 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:29:52 +00:00
Sergey Biryukov
302233dd11 Docs: Fix typos in WP_Site_Health DocBlocks.
Props mukesh27.
Fixes #46753.

git-svn-id: https://develop.svn.wordpress.org/trunk@45093 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:22:42 +00:00
Sergey Biryukov
421da58d8e Docs: Add missing @since tag for WP_Site_Health::get_test_php_extensions().
Props mukesh27.
Fixes #46752.

git-svn-id: https://develop.svn.wordpress.org/trunk@45092 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:16:54 +00:00
Andrea Fercia
1e0ef359fc Administration: Site Health: reserve some space for the admin notices.
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.


git-svn-id: https://develop.svn.wordpress.org/trunk@45091 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 18:00:58 +00:00
Sergey Biryukov
ee5f858436 PHPCS: Fix WPCS violation in [45088].
See #38168.

git-svn-id: https://develop.svn.wordpress.org/trunk@45090 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 16:48:32 +00:00
Sergey Biryukov
9cc5e3e760 Docs: Correct @param description for remove_theme_support().
Add `@return` description for `current_theme_supports()`.

See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45089 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 16:20:05 +00:00
Sergey Biryukov
28e7acf168 Customize: Only add custom-background to body_class() if the current theme supports custom background.
Props wido, swissspidy, ocean90, Mte90.
Fixes #38168.

git-svn-id: https://develop.svn.wordpress.org/trunk@45088 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 16:17:11 +00:00
Andrea Fercia
01bc0b9772 Accessibility: Improve the Site Health accordions.
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.


git-svn-id: https://develop.svn.wordpress.org/trunk@45087 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 15:07:30 +00:00
Sergey Biryukov
fe0db882c5 Docs: Correct parameter types for the_author(), get_the_author_meta(), and the_author_meta().
Props subrataemfluence.
Fixes #45596.

git-svn-id: https://develop.svn.wordpress.org/trunk@45086 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 14:22:06 +00:00
Sergey Biryukov
19ef699ec5 Docs: Improve documentation for get_plugin_page_hook() and get_plugin_page_hookname().
Props subrataemfluence, desrosj.
Fixes #44224.

git-svn-id: https://develop.svn.wordpress.org/trunk@45085 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 14:08:01 +00:00
Sergey Biryukov
0592027157 PHPCS: Fix WPCS violation in [45082].
See #42223.

git-svn-id: https://develop.svn.wordpress.org/trunk@45084 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 13:29:24 +00:00
Sergey Biryukov
63b70b892b Docs: Improve documentation for postbox_classes().
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.

Props sharifkiberu, DrewAPicture.
Fixes #45179.

git-svn-id: https://develop.svn.wordpress.org/trunk@45083 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 12:46:04 +00:00
Sergey Biryukov
6abcd97c8c I18N: Merge similar strings about allowed space allocation in Multisite.
Props ramiy, Jonathandejong, pento.
Fixes #42223.

git-svn-id: https://develop.svn.wordpress.org/trunk@45082 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 12:23:54 +00:00
Sergey Biryukov
0060f2ccbc Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
Props man4toman, andraganescu.
Fixes #46450.

git-svn-id: https://develop.svn.wordpress.org/trunk@45081 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 11:55:39 +00:00
Sergey Biryukov
f6dadb3738 Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
Props man4toman.
See #46450.

git-svn-id: https://develop.svn.wordpress.org/trunk@45080 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 11:54:23 +00:00
Sergey Biryukov
a795928e3b Site Health: If WP_DEBUG_LOG contains a file path, display it on Site Info tab.
Props xkon, knutsp, ocean90.
Fixes #46692.

git-svn-id: https://develop.svn.wordpress.org/trunk@45079 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 01:25:06 +00:00
Sergey Biryukov
0b63b69688 Site Health: Simplify the checks for constants that are always defined by default.
Props xkon.
Fixes #46738.

git-svn-id: https://develop.svn.wordpress.org/trunk@45078 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 00:09:09 +00:00
Sergey Biryukov
0fc5c3adaf Administration: Fix typo in fatal error email notification.
Props kraftbj.
Fixes #46722.

git-svn-id: https://develop.svn.wordpress.org/trunk@45077 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 18:53:21 +00:00
Andrea Fercia
123b973889 Administration: Display a notice in the Site Health pages when JavaScript is off.
- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible

Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)

Fixes #46717.


git-svn-id: https://develop.svn.wordpress.org/trunk@45076 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 15:37:28 +00:00
Andrea Fercia
02a0911bcc Accessibility: Make sure the Site Health layout tables are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used in the Site Health reports.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props chetan200891.
Fixes #46725.


git-svn-id: https://develop.svn.wordpress.org/trunk@45075 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 14:41:16 +00:00
Andrea Fercia
d1dfe7c414 Coding Standards: Improve the Site Health CSS for small screens.
Amends #45071.
See #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45074 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 14:08:45 +00:00
Sergey Biryukov
74211739fe Docs: Fix typos in site_status_tests filter DocBlock.
Props kraftbj.
Fixes #46727.

git-svn-id: https://develop.svn.wordpress.org/trunk@45073 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 10:58:00 +00:00
Andrea Fercia
d52f7c82c1 Administration: Improve the CSS for the Site Health pages header.
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.


git-svn-id: https://develop.svn.wordpress.org/trunk@45072 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:54:39 +00:00
Andrea Fercia
328c4f3432 Coding Standards: Clean up the Site Health stylesheet.
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45071 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:43:09 +00:00
Andrea Fercia
e1e1a40083 Accessibility: Make sure the Site Health pages have a unique document title.
The document `<title>` gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:
- it allows browser's history to store meaningful entries 
- when multiple browser's tabs are open, it allows users to better identify the tab content 
- it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content

Props chetan200891, mukesh27.
Fixes #46699.


git-svn-id: https://develop.svn.wordpress.org/trunk@45070 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:26:28 +00:00
Andrea Fercia
f5a66cacba Accessibility: Remove arrows navigation from the Site Health accordions.
Arrows navigation on accordions is an optional keyboard interaction feature mentioned in the WAI-ARIA Authoring Practices. While it can add some value in some specific cases, it's not so discoverable and it's unlikely users, including assistive technologies users, would really "expect" this kind of interaction.

See #46573.
Fixes #46682.


git-svn-id: https://develop.svn.wordpress.org/trunk@45069 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 11:26:33 +00:00