Commit Graph

26672 Commits

Author SHA1 Message Date
John Blackbourn
db8b7380b2 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin
git-svn-id: https://develop.svn.wordpress.org/trunk@28983 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:53:01 +00:00
John Blackbourn
35578f8f9a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28982 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:30:27 +00:00
Helen Hou-Sandi
71704c1156 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
git-svn-id: https://develop.svn.wordpress.org/trunk@28981 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:19:08 +00:00
Helen Hou-Sandi
6d8c6d8728 Don't escape customizer control descriptions, just as section descriptions are not escaped. These are set programmatically, not via user input. props tollmanz. fixes #27981.
git-svn-id: https://develop.svn.wordpress.org/trunk@28980 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:10:29 +00:00
Drew Jaynes (DrewAPicture)
79dd39c19c Note in the hook docs for preview_post_link that the $post parameter was added.
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:04:56 +00:00
Andrew Nacin
a7c3b23f1c Simplify the setup-config.php UI flow and load process.
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@28978 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:56:37 +00:00
Drew Jaynes (DrewAPicture)
26e262f93d Clarify the inline documentation for plugins_url() to reflect that it also works with mu-plugins.
Props ericlewis.
See #28499.


git-svn-id: https://develop.svn.wordpress.org/trunk@28977 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:41:23 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture)
7ffc91fdd6 Fix an incomplete docblock for wp_create_categories() as part of $post/$post_id cleanup.
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:21:34 +00:00
John Blackbourn
c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919.
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 18:47:33 +00:00
John Blackbourn
14bfade4ec Correct typo in sanitize_html_class() docblock.
git-svn-id: https://develop.svn.wordpress.org/trunk@28973 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:57:17 +00:00
Helen Hou-Sandi
3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for oembed_ttl.
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:44:15 +00:00
Sergey Biryukov
ff3644a220 Fix texturization of quotes when enclosed by angle brackets.
props miqrogroove.
fixes #28718.

git-svn-id: https://develop.svn.wordpress.org/trunk@28971 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:21:18 +00:00
Sergey Biryukov
09efb2dab9 Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead.
props westonruter.
fixes #27992.

git-svn-id: https://develop.svn.wordpress.org/trunk@28970 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:10:01 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter.
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 14:41:06 +00:00
Scott Taylor
16aa589a07 URLs need to be generated, not hard-coded, in user/listAuthors.php test.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28968 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 02:13:08 +00:00
wonderboymusic
26aa4e4e7f Make sure permalink structure is consistent when running query tests.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28967 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:50:02 +00:00
Scott Taylor
f23a5ef832 Setup rewrite changes in tests in a predictable fashion. Don't mix method calls with wrapper function calls.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28966 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:42:57 +00:00
Scott Taylor
73bde8a278 Transient timeouts are untestable when WP_INSTALLING is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because wpmu_create_blog() sets WP_INSTALLING. I have zero idea how these tests ever passed.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28965 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:16:33 +00:00
Scott Taylor
80a817ebcc Make sure hundreds of canonical tests don't fail in multisite every other time they are run.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28964 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 00:49:32 +00:00
John Blackbourn
53f98b80b7 Prepend "Draft:" to draft post titles when previewing on the front end, and add a "single-status-$status" class to the body classes for all post statuses. Fixes #28006. Props hlashbrooke
git-svn-id: https://develop.svn.wordpress.org/trunk@28963 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 22:52:31 +00:00
Scott Taylor
4379ec80d6 This test in post/revisions.php is too misleading and doesn't work as expected since multiple queries can occur before the one that is intended for testing.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28962 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:56:50 +00:00
Scott Taylor
d38227dbae test_wp_get_shortlink() assumes permalink structure is '' when it starts. It is not.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28961 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:49:05 +00:00
Scott Taylor
59b255c445 URLs in unit tests need to be generated, not hard-coded.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28960 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:44:08 +00:00
Sergey Biryukov
4a480146c0 Avoing a PHP warning in media modal if the attached file does not exist.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@28959 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:36:29 +00:00
Sergey Biryukov
ec0e2beebb Canonical redirects should only be applied for GET requests.
props c.axelsson.
fixes #27498.

git-svn-id: https://develop.svn.wordpress.org/trunk@28958 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:10:07 +00:00
SergeyBiryukov
57029ef3fb Make default 'template' argument of the_taxonomies() and get_the_taxonomies() translatable.
props juliobox.
fixes #28714.

git-svn-id: https://develop.svn.wordpress.org/trunk@28957 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 13:20:02 +00:00
Sergey Biryukov
8ee9631bb4 Remove non-breaking spaces from auto update email text.
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 12:45:31 +00:00
Drew Jaynes (DrewAPicture)
2d9bba0a5c Specify the $single parameter default for get_post_meta(). Docs spacing.
See #28708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28955 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:29:33 +00:00
Sergey Biryukov
65106eff1f Mark $single parameter of get_post_meta() as optional.
props netweb.
fixes #28708.

git-svn-id: https://develop.svn.wordpress.org/trunk@28954 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:25:28 +00:00
Sergey Biryukov
00a3c15185 Reorder test functions in term.php for consistency. Add @ticket references.
see #26570.

git-svn-id: https://develop.svn.wordpress.org/trunk@28953 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 01:49:41 +00:00
Drew Jaynes (DrewAPicture)
8e2098d706 Fix parameter description for $append in wp_set_object_terms() inline docs.
See #26570.


git-svn-id: https://develop.svn.wordpress.org/trunk@28952 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 01:38:22 +00:00
Sergey Biryukov
2ce93f915d Clarify the docs and add more unit tests for wp_set_object_terms().
props DrewAPicture.
fixes #26570.

git-svn-id: https://develop.svn.wordpress.org/trunk@28951 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 01:27:07 +00:00
Drew Jaynes (DrewAPicture)
c6b8bae1e8 Remove duplicate of the 'oembed_providers' filter accidentally introduced in [28949].
Move annoted table of oEmbed providers into the existing filter docs.

See #28507.
Fixes #28372. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28950 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:33:11 +00:00
Drew Jaynes (DrewAPicture)
0f20132801 Introduce an annotated list of oEmbed providers, their flavors, whether they support SSL, and when they were added to the oembed_providers filter docs.
See #28507.
Fixes #28372.


git-svn-id: https://develop.svn.wordpress.org/trunk@28949 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:18:12 +00:00
Sergey Biryukov
0d2817bf9e Simplify a condition in get_sample_permalink_html().
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28948 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:10:13 +00:00
Sergey Biryukov
3fe0336a63 Simplify logic in get_sample_permalink_html(), remove duplicated code.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28947 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:03:53 +00:00
Sergey Biryukov
7a8bedaf2a Display a correct preview link for drafts when permalinks are disabled.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28946 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:55:58 +00:00
Sergey Biryukov
339a0e87b7 Use correct variable.
props azaozz.
see #24472.

git-svn-id: https://develop.svn.wordpress.org/trunk@28945 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:29:03 +00:00
Sergey Biryukov
44f1a76a85 Add a filter for wp_editor() settings.
props DH-Shredder, JPry, DrewAPicture.
fixes #24472.

git-svn-id: https://develop.svn.wordpress.org/trunk@28944 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:02:58 +00:00
Scott Taylor
9ab7f4b144 Avoid polluted $table_prefix and $_wp_switched_stack in multisite unit tests.
Add `WP_TESTS_TABLE_PREFIX` in `bootstrap.php` to ensure the original value for `$table_prefix` is always available. 

Props jeremyfelt.
Fixes #28692.


git-svn-id: https://develop.svn.wordpress.org/trunk@28943 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 18:51:46 +00:00
Sergey Biryukov
99d75b6acb Make wp_kses_no_null() remove any invalid control characters in a string.
props mauteri, miqrogroove.
fixes #28506.

git-svn-id: https://develop.svn.wordpress.org/trunk@28942 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 18:00:50 +00:00
Sergey Biryukov
d6b9a469fe Twenty Fourteen: Fix display of center-aligned images with captions in TinyMCE.
props RDall.
fixes #28048.

git-svn-id: https://develop.svn.wordpress.org/trunk@28941 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 16:40:30 +00:00
Helen Hou-Sandi
c6c89eed8a Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox.
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.


git-svn-id: https://develop.svn.wordpress.org/trunk@28940 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 16:22:32 +00:00
Sergey Biryukov
92a7523362 Asterisk is an allowed character in a URI and should not be stripped out by wp_sanitize_redirect().
fixes #28362.

git-svn-id: https://develop.svn.wordpress.org/trunk@28939 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 15:55:04 +00:00
Sergey Biryukov
ef5e962cfb Add @since for get_translations_for_domain().
props DrewAPicture.
see #28690.

git-svn-id: https://develop.svn.wordpress.org/trunk@28938 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 15:28:55 +00:00
Sergey Biryukov
fd4ad167b2 Some fixes for get_weekstartend() docs.
see #26185.

git-svn-id: https://develop.svn.wordpress.org/trunk@28937 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 14:58:37 +00:00
Drew Jaynes (DrewAPicture)
ecb39eaccb General inline documentation improvements in wp-includes/functions.php.
Second run. See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28936 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 01:43:48 +00:00
Sergey Biryukov
8b0ef058f3 WP_Date_Query: The inclusive logic should include all times within the date range.
props mboynes, oso96_2000, DrewAPicture.
fixes #26653.

git-svn-id: https://develop.svn.wordpress.org/trunk@28935 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 01:17:39 +00:00
Sergey Biryukov
416e5bcb96 Move ms-load.php and ms-default-constants.php inclusion back to ms-settings.php to avoid breaking WP-CLI.
Use require_once() to allow for ms-settings.php to be included multiple times while testing.

props jeremyfelt.
see #27884.

git-svn-id: https://develop.svn.wordpress.org/trunk@28934 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 23:49:34 +00:00