Commit Graph

23497 Commits

Author SHA1 Message Date
Scott Taylor
148d8e1e29 Suppress the doing_it_wrong notice from firing in tests/phpunit/tests/dependencies/jquery.php` when running in debug mode.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25375 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:08:03 +00:00
Scott Taylor
591a96743e Passing non-existent object properties to WP_UnitTestCase::assertNull() produces notices, opt instead for WP_UnitTestCase::assertTrue( empty( $obj->prop ) ) in tests/db.php.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25374 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:01:34 +00:00
Scott Taylor
85881c19dc Fix the PHP 5.4 Only variables should be passed by reference notices in tests/action.php.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25373 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:53:56 +00:00
Sergey Biryukov
1b012770eb Inline documentation for hooks in wp-admin/options.php.
props siobhyb.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25372 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:43:48 +00:00
Helen Hou-Sandi
f1ef5c0e23 Indicate that the fall-through in is_serialized() is deliberate. fixes #24023.
git-svn-id: https://develop.svn.wordpress.org/trunk@25371 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:40:25 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254.
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288.
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 00:03:01 +00:00
Scott Taylor
f97a98011b Pass $args as an array, rather than a splat, to wp_clear_scheduled_hook(). There are comments in the code describing the deprecated argument behavior.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25368 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:21:43 +00:00
Scott Taylor
a3a7be77e3 Suppress deprecated notices for wp_shrink_dimensions().
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25367 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:16:43 +00:00
Scott Taylor
6de2f44495 get_home_url() assumes $GLOBALS['pagenow'] is set. It isn't in Tests_URL... and now it is.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25366 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:06:21 +00:00
Scott Taylor
38474ef5d1 Fix undefined index notices in comment/slashes test cases. wp_new_comment() and edit_comment() expect more variables than were being passed.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25365 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:56:31 +00:00
Scott Taylor
eddb6d958b Add a $post_id fixture to Tests_Comment_Query. Comments created without passing comment_post_ID produce an undefined variable notice in wp_insert_comment().
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25364 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:47:14 +00:00
Scott Taylor
169ddb12ad Set $_SERVER['REQUEST_METHOD'] = null in Tests_Auth::setUp() to suppress undefined index notices when wp_validate_auth_cookie() is called.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25363 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:37:46 +00:00
Scott Taylor
e7c543f997 Restore the test code for get_theme(), add the notice suppression filters, and fix the type in the remove_filter() call.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25362 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:32:14 +00:00
Scott Taylor
9f00115bd9 Avoid the following notice: Use of undefined constant term_id - assumed 'term_id', while running in debug mode.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25356 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:45:34 +00:00
Scott Taylor
961adfb51e Update the unit test methods in Tests_Admin_includesTheme. Use wp_get_theme() instead of get_theme().
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25355 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:39:09 +00:00
Scott Taylor
fc372eb7b8 Add action/filter to Tests_Theme::setUp() to suppress errors while running back-compat tests on get_theme(), get_themes(), get_theme_data(), get_current_theme().
See #25282.




git-svn-id: https://develop.svn.wordpress.org/trunk@25354 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:30:06 +00:00
Scott Taylor
135198d66d Use get_users() instead of the deprecated get_users_of_blog() in Tests_User_Capabilities::setUp() to avoid a tornado of warnings in debug mode.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25353 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:55:12 +00:00
Scott Taylor
9dc7afd478 Add set_current_screen( 'front' ) to query/conditionals tests setUp routine so that cruff from previous tests doesn't cause every conditional test to fail in debug mode.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25352 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:40:46 +00:00
Scott Taylor
d091e1d0b7 Avoid a notice by casting $args['rewrite'] to array() before adding a slug property and running array_merge().
Fixes #23668.



git-svn-id: https://develop.svn.wordpress.org/trunk@25351 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:17:00 +00:00
Dion Hulse
23d3b372d7 Fix the action that set_site_transient() fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213
git-svn-id: https://develop.svn.wordpress.org/trunk@25350 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:45:43 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:26:57 +00:00
Dion Hulse
7ebad3db1c Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057
git-svn-id: https://develop.svn.wordpress.org/trunk@25348 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:12:24 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:08:35 +00:00
Dion Hulse
052d276215 Add a set of helpers to turn the behaviour of mbstring.func_overload off when needed. Fixes #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25346 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 07:22:05 +00:00
Andrew Nacin
a1470e6161 Avoid error in ms-files.php after [25317].
git-svn-id: https://develop.svn.wordpress.org/trunk@25344 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:48:43 +00:00
Andrew Nacin
adf6fab55b Bump version in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@25343 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:19:36 +00:00
Andrew Nacin
1848709736 SimplePie: Fix use of DOMElement as array.
props MikeSchinkel.
fixes #25274.


git-svn-id: https://develop.svn.wordpress.org/trunk@25342 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:01:44 +00:00
Andrew Nacin
760e9e02d1 Avoid string offset notices in [25319].
git-svn-id: https://develop.svn.wordpress.org/trunk@25340 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:57:00 +00:00
Andrew Nacin
3b314a0adf Improve clarity and speed of [25320].
git-svn-id: https://develop.svn.wordpress.org/trunk@25338 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:22:09 +00:00
Andrew Nacin
cedb15724a Bump TinyMCE version for [25132]. See #25131.
git-svn-id: https://develop.svn.wordpress.org/trunk@25337 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 02:43:12 +00:00
Scott Taylor
3ee8135baa Don't call sanitize_title_with_dashes( $taxonomy ) in register_taxonomy() unless $args['rewrite']['slug'] is empty.
Props SergeyBiryukov.
Fixes #23668.



git-svn-id: https://develop.svn.wordpress.org/trunk@25335 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:08:04 +00:00
Scott Taylor
0c0c81d81c Add term_taxonomy_id to available fields in get_term_by(). Adds unit test.
Props jchristopher.
Fixes #21651.



git-svn-id: https://develop.svn.wordpress.org/trunk@25334 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:01:19 +00:00
Scott Taylor
a963ab0852 Remove dead code in add_query_arg().
Props hakre, c3mdigital.
Fixes #16942.



git-svn-id: https://develop.svn.wordpress.org/trunk@25333 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:37:23 +00:00
Scott Taylor
1a46a76c18 Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget to preserve use of `wp_get_nav_menus' filter.
Props Frank Klein.
Fixes #25263.



git-svn-id: https://develop.svn.wordpress.org/trunk@25332 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:29:04 +00:00
Scott Taylor
d738f5e586 Support orderby => meta_value in WP_User_Query. Adds unit test.
Props wpsmith.
Fixes #21581.



git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:09:10 +00:00
Scott Taylor
270cc9702d Check $profileuser->rich_editing for empty before using it in Edit User admin code.
Props sorich87, c3mdigital.
Fixes #17328.



git-svn-id: https://develop.svn.wordpress.org/trunk@25330 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:48:27 +00:00
Scott Taylor
c71a0422c0 Add an additional available param (the WP_User instance) to the user_has_cap filter.
Props Viper007Bond.
Fixes #24490.



git-svn-id: https://develop.svn.wordpress.org/trunk@25329 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:22:34 +00:00
Scott Taylor
4fccea305f Add filter flush_rewrite_rules_hard to give devs chance to prevent writing to file when hard-flushing rewrite rules.
Props jeremyfelt, nacin.
Fixes #23491.



git-svn-id: https://develop.svn.wordpress.org/trunk@25328 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:18:21 +00:00
Scott Taylor
a98660d517 Introduce get_previous_post_link(), get_next_post_link(), and get_adjacent_post_link(). Allows developers to retrieve the value without echoing.
Props yoavf, markjaquith, SergeyBiryukov.
Fixes #17302.



git-svn-id: https://develop.svn.wordpress.org/trunk@25327 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:11:53 +00:00
Andrew Nacin
9d7689c4ba Loose validation for is_serialized() in maybe_serialize().
git-svn-id: https://develop.svn.wordpress.org/trunk@25320 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:09:36 +00:00
Andrew Nacin
0281fc61da Better protocol validation in set_url_scheme().
git-svn-id: https://develop.svn.wordpress.org/trunk@25319 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:07:19 +00:00
Andrew Nacin
ac3361e997 Validate referrers to prevent off-domain redirects.
git-svn-id: https://develop.svn.wordpress.org/trunk@25318 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:06:43 +00:00
Andrew Nacin
31482a7968 Tighten allowed upload file types.
git-svn-id: https://develop.svn.wordpress.org/trunk@25317 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:03:26 +00:00
Andrew Nacin
2c0b23557a Ignore user ID post data.
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 17:57:14 +00:00
Scott Taylor
d141191598 Consistently wrap author and excerpt nodes with CDATA in feeds.
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 16:54:16 +00:00
Helen Hou-Sandi
37e5277651 Show the IP address, if available, in the comment edit screen submit meta box. props leewillis77. fixes #24638.
git-svn-id: https://develop.svn.wordpress.org/trunk@25314 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 14:40:15 +00:00
Scott Taylor
5a75531f19 Replace the ancient phpfreaks.com RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like & were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
Fixes #9064.



git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Scott Taylor
e72ffa5d96 Move checks for post_type being an array inline. See [25291], [25292], #18614.
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Scott Taylor
9ece28e545 Add an action at the end of WP_Query::parse_tax_query() called (wait for it...) parse_tax_query which will enable developers to alter $this->tax_query->queries before SQL is generated. pre_get_posts is too early for many scenarios.
git-svn-id: https://develop.svn.wordpress.org/trunk@25311 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:35:26 +00:00