Andrew Nacin
564d5a51c2
Reinstate an assertion commented out in [25409]. This test is skipped due to @ticket anyway. see #25282 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25440 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 19:17:31 +00:00
Scott Taylor
535ae26afd
Fix several esoteric errors related to AJAX unit tests for comments:
...
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.
All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.
Fixes #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-14 18:35:43 +00:00
Scott Taylor
402e61f269
Fix some undefined index notices related to Comment unit tests:
...
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 22:17:51 +00:00
Scott Taylor
d85e040859
Remove the unnecessary call to ob_end_clean()
directly after ob_get_clean()
in WP_Ajax_UnitTestCase::dieHandler()
. This fixes a large number of AJAX errors in debug mode.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25432 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 21:32:54 +00:00
Scott Taylor
f76f2a692a
Fix an error in tests/ajax/Compression
by removing the unnecessary call to ob_end_clean()
immediately after ob_get_clean()
in _gzdecode
, which has aleady deleted the buffer.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25431 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-13 21:29:12 +00:00
Andrew Nacin
9d9a28b3e0
Test framework: Update path to multisite.xml.
...
props jeremyfelt.
fixes #25242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25415 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 21:04:16 +00:00
Andrew Nacin
4c8f1e263a
Use @expectedDeprecated. see #25282 , [25408].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25409 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 18:37:32 +00:00
Andrew Nacin
d5d476974e
Test framework: Introduce the annotation @expectedDeprecated, modeled after PHPUnit's @expectedException.
...
It works for both functions and arguments (using the value of the first argument passed to _deprecated_function() or _deprecated_argument(), which is typically the function name). It asserts both ways:
* If specified, those deprecated notices must be caught, or the test fails.
* If not specified, any other deprecated notices cause the test to fail.
Works regardless of WP_DEBUG.
see #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25408 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 18:37:00 +00:00
Andrew Nacin
9bfe9b7230
Revert [25405] and use a file that does exist. see #25282 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25407 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 17:47:40 +00:00
Scott Taylor
8a2c79d897
Fix the failing l10n assertions:
...
* Check if the file exists before running `true` assertions
* If the file doesn't exist, run `false` assertions
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25405 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 17:36:45 +00:00
Scott Taylor
404fd85586
Fix the failing Tests_Link::test_wp_get_shortlink()
assertion:
...
* `wp_get_shortlink()` was firing a notice when reading `$post->ID` while `$post` was null in some cases
* Before the assertions that assume `$GLOBALS['post']` is not set, call `unset( $GLOBALS['post'] );` - there was global spillage from other tests
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25404 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 17:30:01 +00:00
Scott Taylor
654d07ebf9
There was way too much duplicated code in my notice cleanup, it built up over time, and there's definitely a need to standardize.
...
* Remove duplicated code for deprecated function notice suppression
* Add support in `WP_UnitTestCase` setUp/tearDown methods for `$deprecated_functions` fixture if the extending class has added it
* Add a `$deprecated_functions` fixture to each extending class that needs it
To use this fixture, add something to your Test Case class like so:
`protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25402 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 14:47:58 +00:00
Scott Taylor
3ae18e68ff
* Fill in undefined var in Tests_Option_BlogOption
...
* Add `defined()` check for `BLOGSUPLOADDIR`
* Suppress deprecated function notices for `is_blog_user()` and `get_dashboard_blog()`
* Check existence of `$user` in `wpmu_log_new_registrations()` before arbitrarily making a database query
Fixes all notices in multisite unit tests.
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25397 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 07:16:30 +00:00
Scott Taylor
285db00ed4
Suppress Non-static method PO::*() should not be called statically, assuming $this from incompatible context
by using the @
silencer in tests/pomo/po.php
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25395 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:46:35 +00:00
Scott Taylor
13381bfcdc
* sort()
returns a boolean, not a sorted set. Move the calls out of the assertions and fix the test methods.
...
* Fix instances where `Only variables should be passed by reference` was being triggered by assigning `array_keys()` return value to a var
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25394 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:41:36 +00:00
Scott Taylor
d58aace6f7
Avoid undefined variable
notice - wp_insert_user()
expects user_pass
to be passed to it.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25393 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:28:25 +00:00
Scott Taylor
d1d5bcf036
* Add isset()
checks all over WP_User_Query::prepare_query()
and WP_User_Query::query()
. When a WP_User_Query
instance is constructed without passing args, no query vars are filled in, thus $qv
doesn't contain most of the expected indices.
...
* Suppress an undefined index notice in `tests/user/query.php`
Fixes #25292 .
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25392 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:24:09 +00:00
Scott Taylor
c0c3359572
* Suppress deprecated function notice for set_current_user()
...
* Add assertions for `wp_set_current_user()`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25391 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:06:07 +00:00
Scott Taylor
b18d047edd
* Avoid Only variables should be passed by reference
notice by passing a var to array_pop()
in tests/user.php
...
* Suppress a notice by silencing the passing of a non-existent object prop
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25390 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:56:59 +00:00
Scott Taylor
6acb4cf24d
Don't assume $GLOBALS['post']
is set in tests/url.php
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25389 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:52:53 +00:00
Scott Taylor
f4ac65db2d
* Suppress deprecated function notices in tests/theme/themeDir.php
...
* Set `$theme['Template Files']` and `$theme['Stylesheet Files']` to a variable before calling array methods upon them - avoids `Indirect modification of overloaded element has no effect` notice
* Clean up setUp/tearDown in `tests/theme.php`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25388 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:48:58 +00:00
Scott Taylor
ee35baae6b
Suppress the _doing_it_wrong
notices when calling add_theme_support( 'html5' )
in tests/theme/support.php
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25387 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:39:45 +00:00
Scott Taylor
f9877147f6
Use reset()
to access the first element of an array, don't assume there is an item at index 0
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25384 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:08:33 +00:00
Scott Taylor
6ced366e7c
Add a post_id
fixture in test/meta/slashes.php
so Undefined variable: comment_post_ID
notices don't fire when creating comments.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25383 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:59:29 +00:00
Scott Taylor
9cb4234c3f
* Fix the horrendous whitespace in tests/media.php
...
* Suppress the deprecated function notice for `wp_convert_bytes_to_hr()`
* Add assertions for `size_format()`
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25382 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:55:24 +00:00
Scott Taylor
1e460fd6e2
Avoid a notice and clean up setting/unsetting of globals by moving them into setUp()
and tearDown()
methods in Tests_Mail
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25381 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:46:49 +00:00
Scott Taylor
a76e6cef7d
* Avoid notice by making WP_Image_Editor_Mock::test()
compatible with WP_Image_Editor::test()
.
...
* Suppress deprecated function notice for `wp_load_image()`.
* Add assertion for `wp_get_image_editor()`.
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25380 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:40:13 +00:00
Scott Taylor
dc35c8d11e
Pass a variable that actually exists to seems_utf8()
in tests/formatting/SeemsUtf8.php
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25379 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:28:34 +00:00
Scott Taylor
7001aeaa11
Suppress the deprecated function notice in tests/formatting/CleanPre.php
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25378 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:20:48 +00:00
Scott Taylor
691e3f25a0
Fix the PHP 5.4 Only variables should be passed by reference
notices in tests/filters.php
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25377 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:16:59 +00:00
Scott Taylor
62b7214706
Avoid an undefined index error in tests/phpunit/tests/dependencies/styles.php
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25376 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:13:11 +00:00
Scott Taylor
148d8e1e29
Suppress the doing_it_wrong
notice from firing in tests/phpunit/
tests/dependencies/jquery.php` when running in debug mode.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25375 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:08:03 +00:00
Scott Taylor
591a96743e
Passing non-existent object properties to WP_UnitTestCase::assertNull()
produces notices, opt instead for WP_UnitTestCase::assertTrue( empty( $obj->prop ) )
in tests/db.php
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25374 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 04:01:34 +00:00
Scott Taylor
85881c19dc
Fix the PHP 5.4 Only variables should be passed by reference
notices in tests/action.php
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25373 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:53:56 +00:00
Scott Taylor
f97a98011b
Pass $args
as an array, rather than a splat, to wp_clear_scheduled_hook()
. There are comments in the code describing the deprecated argument behavior.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25368 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:21:43 +00:00
Scott Taylor
a3a7be77e3
Suppress deprecated notices for wp_shrink_dimensions()
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25367 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:16:43 +00:00
Scott Taylor
6de2f44495
get_home_url()
assumes $GLOBALS['pagenow']
is set. It isn't in Tests_URL
... and now it is.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25366 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 22:06:21 +00:00
Scott Taylor
38474ef5d1
Fix undefined index notices in comment/slashes
test cases. wp_new_comment()
and edit_comment()
expect more variables than were being passed.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25365 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:56:31 +00:00
Scott Taylor
eddb6d958b
Add a $post_id
fixture to Tests_Comment_Query
. Comments created without passing comment_post_ID
produce an undefined variable notice in wp_insert_comment()
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25364 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:47:14 +00:00
Scott Taylor
169ddb12ad
Set $_SERVER['REQUEST_METHOD'] = null
in Tests_Auth::setUp()
to suppress undefined index notices when wp_validate_auth_cookie()
is called.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25363 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:37:46 +00:00
Scott Taylor
e7c543f997
Restore the test code for get_theme()
, add the notice suppression filters, and fix the type in the remove_filter()
call.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25362 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 21:32:14 +00:00
Scott Taylor
9f00115bd9
Avoid the following notice: Use of undefined constant term_id - assumed 'term_id'
, while running in debug mode.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25356 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:45:34 +00:00
Scott Taylor
961adfb51e
Update the unit test methods in Tests_Admin_includesTheme
. Use wp_get_theme()
instead of get_theme()
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25355 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:39:09 +00:00
Scott Taylor
fc372eb7b8
Add action/filter to Tests_Theme::setUp()
to suppress errors while running back-compat tests on get_theme()
, get_themes()
, get_theme_data()
, get_current_theme()
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25354 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 18:30:06 +00:00
Scott Taylor
135198d66d
Use get_users()
instead of the deprecated get_users_of_blog()
in Tests_User_Capabilities::setUp()
to avoid a tornado of warnings in debug mode.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25353 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:55:12 +00:00
Scott Taylor
9dc7afd478
Add set_current_screen( 'front' )
to query/conditionals
tests setUp
routine so that cruff from previous tests doesn't cause every conditional test to fail in debug mode.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25352 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:40:46 +00:00
Scott Taylor
0c0c81d81c
Add term_taxonomy_id
to available fields in get_term_by()
. Adds unit test.
...
Props jchristopher.
Fixes #21651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25334 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:01:19 +00:00
Scott Taylor
d738f5e586
Support orderby => meta_value
in WP_User_Query
. Adds unit test.
...
Props wpsmith.
Fixes #21581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:09:10 +00:00
Scott Taylor
5a75531f19
Replace the ancient phpfreaks.com
RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like &
were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
...
Fixes #9064 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Scott Taylor
e72ffa5d96
Move checks for post_type
being an array inline. See [25291], [25292], #18614 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Andrew Nacin
7f7aacbdec
wp_allowed_protocols() should not contain 'data', as it is not safe. see #19354 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25301 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-08 19:41:14 +00:00
Sergey Biryukov
c47302e70f
Use correct paths in multisite.xml. see [25165]. see #25088 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25294 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 15:19:56 +00:00
Scott Taylor
e688f070dc
Check the value passed to get_post_type_object()
. If it's an array, use the first item. get_query_var( 'post_type' )
can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
...
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.
See #18614 , [25291].
git-svn-id: https://develop.svn.wordpress.org/trunk@25292 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 23:38:51 +00:00
Scott Taylor
48dc7e576b
Ensure that the post type object is the queried object when a post type has been registered with has_archive => true
. Ensure it is not stomped when decorated with tax_query
. Adds unit tests.
...
Props nacin.
Fixes #18614 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25291 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 22:06:40 +00:00
Scott Taylor
0474a18863
Allow is_tag()
to accept term_id
, slug
, 'term_name or array of any. Many other
is_*()` funcs already do this. Adds unit tests.
...
Props ramiy.
Fixes #18746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25287 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:26:04 +00:00
Scott Taylor
09b9c44de9
Check bad dates and redirect, instead of 404ing, as necessary and appropriate.
...
Adds query, conditional, and canonical Unit Tests.
Props kovshenin, SergeyBiryukov, DrewAPicture.
Fixes #10935 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25280 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 16:35:22 +00:00
Scott Taylor
93cfccac2d
Add unit test for tax_query
against attachments.
...
See #22556 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25278 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 14:43:49 +00:00
Sergey Biryukov
093a580656
Whitespace cleanup for password strength meter tests. props TobiasBg. fixes #25088 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25275 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 10:56:01 +00:00
Andrew Nacin
27b0660c5f
Add a test case for calling get_page_uri() with a non-existent post.
...
see #24491 , [25262].
git-svn-id: https://develop.svn.wordpress.org/trunk@25265 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 22:02:42 +00:00
Andrew Nacin
f280a2f525
Remove old WP version checks from PHPUnit test cases now that tests are branched with each version.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25264 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 21:56:10 +00:00
Scott Taylor
a5d3bde7a0
Avoids incorrect results when url_to_postid()
checking is not strict enough. Adds a bunch of Unit Tests for `url_to_postid()', which is currently only tested lightly in some XML-RPC tests.
...
Props gcorne, gradyetc.
Fixes #20560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25258 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:28:52 +00:00
Scott Taylor
e8c7634e79
Avoid database error when include
or exclude
is not really a term_id
. Adds more unit tests.
...
Props kovshenin.
Fixes #11823 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25257 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:14:54 +00:00
Scott Taylor
83d1992d34
When meta_type
is passed with orderby => meta_value
, orderby
must also use CAST()
to avoid scenarios like: SELECT
ing by UNSIGNED
and then ordering by CHAR
. Adds unit test.
...
Fixes #21621 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25255 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:56:36 +00:00
Scott Taylor
16ef2c2e36
Remove lingering instances of call time pass-by-reference, limited to instances of callable
- use $this
instead of &$this
.
...
Props jdgrimes.
See #25160 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Scott Taylor
57b1d5ab28
Introduce author__in
and author__not_in
query vars. Fixes issue with multiple author exclusion when comma-separated string is passed for author
. Adds a bunch of missing unit tests.
...
Props pollett for initial patch.
Fixes #16854 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25248 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 21:32:11 +00:00
Scott Taylor
0b28c0137d
Allow get_pages()
to accept an array
for the arg parent
. Adds unit tests, some will fail until the next commit.
...
Fixes #9470 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25244 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:55:05 +00:00
Scott Taylor
0877a3eda4
Remove error_reporting()
debug cruff.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25242 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:56:06 +00:00
Scott Taylor
89997e4c80
Introduce description__like
arg to get_terms()
. Make description__like
and name__like
perform LIKE
s with a wildcard on both sides of passed string. Previously, strings had to match the beginning of the name, so searching for burrito
in This is a burrito
would fail. Adds unit tests.
...
Props aaroncampbell for the original patch, 5 years ago.
Fixes #8214 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25241 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:40:17 +00:00
Scott Taylor
d10b9d32a0
Remove unnecessary checks before setting $wp_settings_*
arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array
.
...
Props scribu.
Fixes #17884 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:06:13 +00:00
Scott Taylor
24bf60bb4f
Kill the query in the following edge case: post_type => 'any'
but exclude_from_search => false
returns no valid post types. Adds unit tests.
...
Props mitchoyoshitaka.
Fixes #19198 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25239 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 18:50:04 +00:00
Scott Taylor
0d0b17b617
Convert category__and
to category__in
(less expensive) and unset it when only one category is passed. Adds unit tests.
...
Fixes #24245 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25238 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 18:16:31 +00:00
Andrew Nacin
db5f9800d4
add_theme_support( 'html5' ) now defaults to comment-list, comment-form, and search-form.
...
This was the implicit case in 3.6.0, modified in [25193].
see #24932 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25235 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 17:43:29 +00:00
Scott Taylor
1e0d32406d
Allow int
to be passed in lieu of array
, add append
arg to wp_set_post_categories()
. Adds more extensive unit tests for wp_set_post_categories()
.
...
Props ptahdunbar for initial patch.
Fixes #16550 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25234 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 17:41:03 +00:00
Dion Hulse
5d57f260ed
WP_HTTP: Replacing the Fsockopen & Streams Transports with a new Streams transport which fully supports HTTPS communication.
...
This changeset also bundles ca-bundle.crt from the Mozilla project to allow for us to verify SSL certificates on hosts which have an incomplete, outdated, or invalid local SSL configuration.
Props rmccue for major assistance getting this this far. See #25007 for discussion, also Fixes #16606
git-svn-id: https://develop.svn.wordpress.org/trunk@25224 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 04:48:21 +00:00
Sergey Biryukov
59989c2de0
Update tests/README.txt to reflect the new tests directory structure. props jdgrimes. fixes #25133 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25199 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 13:42:56 +00:00
Andrew Nacin
788973ffb2
Case insensitivity for is_email_address_unsafe().
...
props jkudish.
fixes #25046 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25197 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 04:35:15 +00:00
Andrew Nacin
afe7f94304
Fix 'html5' theme support.
...
* Require it to have a second argument when adding.
* Merge, rather than replace, on second add.
* Make current_theme_supports() work when two arguments are passed.
Adds unit tests.
props nathanrice for initial patch.
see #24932 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@25193 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:29:08 +00:00
Jon Cave
94e03ce09f
Test that passwords containing the username are penalised.
...
Tidy up some spelling, indentation and whitespace whilst we're at it.
Props iandunn. See #25088 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25175 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 22:28:32 +00:00
Andrew Nacin
f6966d20b3
Basic tests for wp_parse_id_list() to ensure positive integers. see [25169].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25170 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:58:40 +00:00
Scott Taylor
f458d16c01
Improve the include / exclude SQL generation in get_pages()
by using IN
and NOT IN
where applicable. Adds unit tests for include / exclude.
...
Fixes #22074 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25168 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:48:29 +00:00
Andrew Nacin
dd78079286
Add QUnit tests for password-strength-meter.js.
...
props jorbin.
see #25088 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25167 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:44:36 +00:00
Andrew Nacin
1a651a4723
Add QUnit to WordPress core for JavaScript unit testing.
...
props jorbin.
see #25088 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25166 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:42:59 +00:00
Andrew Nacin
8045afd81b
Move PHPUnit tests into a tests/phpunit directory.
...
wp-tests-config.php can/should reside in the root of a develop checkout. `phpunit` should be run from the root.
see #25088 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25165 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:39:34 +00:00
Scott Taylor
d34baebc1d
Search term name
and slug
when the search
arg is passed to get_terms()
. Adds unit test.
...
Props wojtek.szkutnik.
Fixes #13992 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25164 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:49:43 +00:00
Scott Taylor
9e96365b8e
Pass the taxonomy around to relevant nav menu actions to avoid arbitrarily deleting all items with menu-item-type
of taxonomy
. Adds unit test for wp_get_associated_nav_menu_items()
.
...
Props garyc40, SergeyBiryukov.
Fixes #15264 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25163 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:44:36 +00:00
Scott Taylor
a4a765c5fd
Improve the include / exclude SQL generation in get_terms()
by using IN
and NOT IN
where applicable. Adds unit tests for include / exclude.
...
Props sirzooro, duck_.
Fixes #11823 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25162 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 16:23:30 +00:00
Scott Taylor
69785902db
Support id=>name
and id=>slug
values for fields
arg in get_terms()
. Adds unit tests.
...
Props mikeschinkel.
Fixes #13661 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25161 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 15:18:08 +00:00
Scott Taylor
744a4a80a4
Respect the fields
arg when passed to get_children()
.
...
Fixes #22208 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25160 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 15:07:59 +00:00
Dion Hulse
b38ac8cd66
Unit Tests: Make it more compatible with PHPUnit when installed as a Phar, or, Composer package, by removing a duplicate require (Phpunit already includes the file itself). Props scribu Fixes #25065
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25145 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-28 01:43:14 +00:00
Andrew Nacin
c637de7316
WP_Date_Query.
...
props Viper007Bond.
see #18694 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25139 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-27 16:38:32 +00:00
Sergey Biryukov
d3a86958e6
Update the directory reference in tests/README.txt. props jdgrimes. fixes #25133 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25116 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-24 14:05:00 +00:00
Andrew Nacin
dc9bd8db8a
Multisite tests: Update default space allowed in get_space_allowed(). see #23650 , [25092].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25111 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-23 22:54:54 +00:00
Scott Taylor
39171d7527
Check term_id
against the $term
object, not the non-existent var $args
. Props rboren. Fixes #12729 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25106 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-23 21:04:22 +00:00
Sergey Biryukov
ac338fc070
Check if a locale category is an existing constant when restoring locale settings in Tests_DB::test_locale_floats(). props nofearinc. fixes #25118 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25084 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-22 15:28:01 +00:00
Andrew Nacin
d71f11bdd7
Remove sourceMappingURL from jquery.min.js.
...
props Jayjdk.
fixes #24994 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25072 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-21 15:40:35 +00:00
Dion Hulse
0fbadc1e03
Adding some basic Unit Tests for the Filesystem methods, primarily, WP_Filesystem_Base::find_folder() which is used during FTP upgrades.
...
This introduces a Mock Filesystem in memory to avoid having to setup a different VM for every combination of filesystem structures possible.
git-svn-id: https://develop.svn.wordpress.org/trunk@25053 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-20 05:39:20 +00:00
Dion Hulse
b5b118558e
WP_HTTP: Cookies: When following redirects, include the request cookies in the redirected requests. Fixes #24987
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25046 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-17 01:19:04 +00:00
Ryan Boren
17267dd999
wp_get_shortlink() improvements.
...
* Return shortlinks for pages and public CPTs.
* Return shortlinks even when cruft-free links are not enabled.
* Unit tests
Props sillybean, layotte, cais
fixes #18632
see #14760
git-svn-id: https://develop.svn.wordpress.org/trunk@25030 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-15 20:08:06 +00:00
Dion Hulse
02134236de
Tests: Avoid PHP Deprecated and Strict Standards warnings from Object references and incompatible method declarations when running under WP_DEBUG
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25017 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-08 02:55:44 +00:00
Peter Westwood
ddbe85a1a7
Tests: Add support for storing your wp-test-config.php file a directory higher if you want to like we do for wp-config.php
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25008 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 10:09:35 +00:00
Peter Westwood
c366722810
Tests: Remove the real test configuration file, we only check in the sample one :)
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25007 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 10:08:59 +00:00
Peter Westwood
90ff12d777
Tests: Remove the transitory ticket cache files that shouldn't be under version control.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25006 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 10:08:15 +00:00
Andrew Nacin
98e788c259
Remove the legacy Tests_Theme_ThemeDirLarge test to drop the wpcom-themes external/dependency. see #24976 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25004 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 06:51:04 +00:00
Andrew Nacin
1801ed459c
Initial import of unit-tests repository into develop.svn.wordpress.org.
...
Imported from https://unit-tests.svn.wordpress.org/trunk@1337
see #24976 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25002 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 06:38:38 +00:00