Commit Graph

26893 Commits

Author SHA1 Message Date
Helen Hou-Sandi
fdabfafa0f Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.


git-svn-id: https://develop.svn.wordpress.org/trunk@29204 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 03:54:44 +00:00
Andrew Ozz
db9a148b34 TinyMCE:
- Update to 4.1.2, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt
- Update the tests to 4.1.2.
Fixes #28576.

git-svn-id: https://develop.svn.wordpress.org/trunk@29203 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:58:41 +00:00
Andrew Ozz
50f7313fdd TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905.
git-svn-id: https://develop.svn.wordpress.org/trunk@29202 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:49:11 +00:00
Scott Taylor
283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Scott Taylor
bda6f0cffe Properly set $subdomain_error to false when applicable in ms_subdomain_constants(). This was previously untestable because it used static vars: use globals instead.
Adds unit test.
Fixes #28697.


git-svn-id: https://develop.svn.wordpress.org/trunk@29200 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:34:18 +00:00
Drew Jaynes (DrewAPicture)
8a5d825fac Fix a typo in the @access tag for WP_List_Table::__get().
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:12:11 +00:00
Scott Taylor
e7e0aa5a42 Make sure that the ready event only fires once for relevant MCE views that are sandbox'd in iframes. Move some editor callbacks to initialize.
Props avryl.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29198 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:09:13 +00:00
Scott Taylor
17d67d93e7 Make has_shortcode() recursive/work for nested shortcodes.
Adds unit test.

Props katzwebdesign.
Fixes #26343.


git-svn-id: https://develop.svn.wordpress.org/trunk@29197 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:04:08 +00:00
Scott Taylor
722930611c Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.
Adds a unit test.

Props dlh.
Fixes #19205.


git-svn-id: https://develop.svn.wordpress.org/trunk@29196 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 21:51:40 +00:00
Andrew Ozz
0e3aac5016 TinyMCE: fix aligncenter for html5-captions, props obenland, fixes #28681.
git-svn-id: https://develop.svn.wordpress.org/trunk@29195 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 21:27:54 +00:00
Scott Taylor
977b4a7c26 Cleanup after [29179]:
* Remove `wp.media.mixin.pauseAllPlayers()` - was only ever intended to be used in MCE views, reaches too far into global scope. Rendered irrelevant since [28364].
* Remove `wp.media.mixin.pausePlayers()` - added in [28364]. MCE views no longer keep track of player instances and call mixin methods, they refer to their child iframes and call MEjs methods on the iframe's `window.mejs.players`. 

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29194 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 19:35:55 +00:00
Scott Taylor
aa10b9f67b Cleanup after [29179]:
Don't attach nodes to the view instance and check if the iframe still exists before resizing.

Props avryl.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29193 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 19:31:30 +00:00
Andrew Ozz
67c5474701 Autosave: always expose the wp.autosave.local methods, fixes #28924.
git-svn-id: https://develop.svn.wordpress.org/trunk@29192 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 18:33:03 +00:00
Scott Taylor
72c8cf3233 Cleanup after [29179]:
* Pause players when media is edited via modal
* Remove players on unind
* Account for failure when an empty node is passed to an `mce.view.View`

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29191 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 18:18:18 +00:00
Andrew Ozz
fa4ed6e062 TinyMCE wpView: add noop() when returning early, fixes #28921
git-svn-id: https://develop.svn.wordpress.org/trunk@29190 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 17:55:00 +00:00
Scott Taylor
f071e710c2 Cleanup after [29179]:
* Cleanup players when the editor is hidden - window scope is unique to each frame
* Add the editor body class to each iframe sandbox
* Remove unneeded code from `wp-mediaelement.js`

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29189 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 16:13:47 +00:00
Andrew Nacin
9452f31220 DB schema change: Add comment_author_email(10) index.
props tellyworth, pento.
fixes #21435.


git-svn-id: https://develop.svn.wordpress.org/trunk@29188 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 15:53:14 +00:00
Scott Taylor
7e05c69ce2 Cleanup after [29179]:
* `_WP_Editors::editor_settings()` no longer needs to load MEjs styles
* Make sure each identical shortcode with multiple instances also has an iframe sandbox for each instance
* For the time being, make audio and video shortcodes bypass the loading placeholder to avoid whiplash visually

Props avryl, wonderboymusic.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29187 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 15:39:05 +00:00
Andrew Ozz
09f5183276 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29186 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 04:05:13 +00:00
Andrew Ozz
850d8eb69e Editor scrolling: on setcontent, resize the editor after some delay to allow the browser to render the content. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29185 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 02:29:53 +00:00
Andrew Ozz
a90e8c6ff2 TinyMCE wpView: handle execCommand when the "fake caret" P is selected, props avryl, see #28595
git-svn-id: https://develop.svn.wordpress.org/trunk@29184 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 02:18:18 +00:00
Andrew Ozz
76c3055aec TinyMCE wpView:
- Cast off commands targeted to a view except undo, redo, RemoveFormat and mceToggleFormat (bold, italic, etc.).
- Disable the link and unlink buttons when a view is selected.
Props avryl, see #28595

git-svn-id: https://develop.svn.wordpress.org/trunk@29183 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 00:09:58 +00:00
Andrew Ozz
e7b7e3fa44 TinyMCE wpView: remove unused code, props avryl, see #28595
git-svn-id: https://develop.svn.wordpress.org/trunk@29182 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 23:38:33 +00:00
Lance Willett
aa163fdee3 Twenty Thirteen: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than h3 for the toggle element. Fixes #28293, props rclations and obenland.
git-svn-id: https://develop.svn.wordpress.org/trunk@29181 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 23:09:41 +00:00
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:36:02 +00:00
Scott Taylor
cba1ae06af Simplify creation of audio, video, and playlist MCE views by placing them in iframe sandboxes.
Wins:
* Eliminates duplication of code between PHP and JS
* Views can load JS without messing with TinyMCE and scope
* MEjs doesn't break when it loads a file plugin-mode. This allows any file type the MEjs supports to play in MCE views.
* YouTube now works as the source for video.
* Users can still style the views, editor stylesheets are included in these sandboxes.
* Audio and Video URLs and `[embed]`s are no longer broken.
* Remove the crazy compat code necessary to determine what file types play in what browser.
* Remove unneeded Underscore templates.
* Remove the compat code for playlists.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29179 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:17:58 +00:00
Scott Taylor
9e573243cf Add a new AJAX action: parse-media-shortcode. This async call will replace JS rendering of audio/video/playlist shortcodes.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29178 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:07:16 +00:00
Scott Taylor
de49a2e6da _WP_Editors::editor_settings() should make use of get_editor_stylesheets().
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29177 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:00:34 +00:00
Scott Taylor
bbfdf38a5b Make audio and video URLs/embed handlers work in <iframe>-sandbox'd MCE views.
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29176 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 21:50:41 +00:00
Helen Hou-Sandi
0db107498a No-JS fallback for the Media Library grid view. props michalzuber. fixes #28830, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29175 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 20:44:38 +00:00
Lance Willett
a9f6a727eb Twenty Fourteen: optimize featured content lookup to reduce the number of queries for featured posts. Props Chouby and obenland, closes #26744.
git-svn-id: https://develop.svn.wordpress.org/trunk@29174 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 06:43:31 +00:00
Dominik Schilling (ocean90)
4d6759dcf5 Remove unused variable in WP_Theme_Install_List_Table::install_theme_info(). Unused since [26380].
props Corphi.
fixes #28749.

git-svn-id: https://develop.svn.wordpress.org/trunk@29173 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 20:27:37 +00:00
Dominik Schilling (ocean90)
cf673a6985 Fix wrong indentation in [29136].
git-svn-id: https://develop.svn.wordpress.org/trunk@29172 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 20:08:38 +00:00
Dominik Schilling (ocean90)
1b2386e787 Remove plugin_install_details_link filter, which was added in [29047].
see #28785.

git-svn-id: https://develop.svn.wordpress.org/trunk@29171 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 19:49:15 +00:00
Dominik Schilling (ocean90)
60b1befd8e Customizer: Add meta capability customize which is mapped to edit_theme_options.
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.

git-svn-id: https://develop.svn.wordpress.org/trunk@29170 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 19:00:24 +00:00
Lance Willett
305e72859a Twenty Fourteen: pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@29169 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 17:48:48 +00:00
Lance Willett
6b86010ec2 Twenty Fourteen: improve styles for media "play" button. Props iamtakashi, closes #26469.
git-svn-id: https://develop.svn.wordpress.org/trunk@29168 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 17:47:36 +00:00
Lance Willett
4024ffdabc Twenty Fourteen: RTL display adjustment for Custom Header, props yoavf. Fixes #28670.
git-svn-id: https://develop.svn.wordpress.org/trunk@29167 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 17:40:07 +00:00
Scott Taylor
e5a663297c Missed one: WP_MS_Sites_List_Table::display_rows() must be public.
Props extendwings.
Fixes #28894.



git-svn-id: https://develop.svn.wordpress.org/trunk@29166 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 15:41:53 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
a752c42b05 Inline documentation cleanup for 4.0 audit.
Added in [28652]:
* Various phpDoc improvements for `wp_embed_handler_youtube()`
* Adds `@see` reference to `wp_embed_handler_youtube()` in 'wp_embed_handler_youtube' filter docs

Added in [29029]:
* s/post_id/post ID in `@return` description for `attachment_url_to_postid()`

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29164 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:06:58 +00:00
Drew Jaynes (DrewAPicture)
551f829c55 Inline documentation cleanup for 4.0 audit.
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29163 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:01:22 +00:00
Drew Jaynes (DrewAPicture)
94d5e7b388 Fill out inline documentation for the __call() magic method added to the WP_Comment_Query class in [28519].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29162 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:47:36 +00:00
Drew Jaynes (DrewAPicture)
2d27b684fb Fill out inline documentation for the __call() magic method added to the wp_xmlrpc_server class in [28515].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29161 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:45:54 +00:00
Drew Jaynes (DrewAPicture)
1a2da86366 Inline documentation cleanup for 4.0 audit.
Document the first parameter, `$time`, in the 'oembed_ttl' filter, added in [28972].

See #14759 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29160 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:43:51 +00:00
Drew Jaynes (DrewAPicture)
17ba9ab973 Inline documentation cleanup for 4.0 audit.
phpDoc tweaks for methods, properties, and filters added in [29051]:
* `WP_Customize_Widgets::is_widget_rendered()` method
* `WP_Customize_Widgets::is_sidebar_rendered()` method

See #27993 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29159 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:41:20 +00:00
Drew Jaynes (DrewAPicture)
37a39b6b74 Inline documentation cleanup for 4.0 audit.
phpDoc tweaks for methods added in [28861]:
* `WP_Customize_Panel` constructor method
* `WP_Customize_Panel::render()` method

See #27406 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29158 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:39:10 +00:00
Drew Jaynes (DrewAPicture)
f6c14d758e Inline documentation cleanup for 4.0 audit.
phpDoc tweaks for methods added in [28861]:
* `WP_Customize_Manager::panels()` method
* `WP_Customize_Manager::add_panel()` method
* `WP_Customize_Manager::get_panel()` method
* `WP_Customize_Manager::remove_panel()` method

Added in [28970]:
* `WP_Customize_Manager::customize_preview_override_404_status()` method

See #27406 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29157 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:35:43 +00:00
Drew Jaynes (DrewAPicture)
e52c954fad Inline documentation cleanup for 4.0 audit.
phpDoc tweaks for methods, properties, and filters added in [29051]:
* `WP_Customize_Control->$active_callback` property
* `WP_Customize_Control::active()` method
* `WP_Customize_Control::active_callback()` method
* `WP_Widget_Area_Customize_Control::active_callback()` method
* `WP_Widget_Form_Customize_Control::active_callback()` method
* 'customize_control_active' filter

Added in [28930]:
* `WP_Customize_Control::input_attrs()` method

See #27993 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29156 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:31:22 +00:00
Drew Jaynes (DrewAPicture)
e68fd93be4 Inline documentation cleanup for 4.0 audit.
* Fill out inline documentation for the `__call()` magic method added in [28507]
* Inline documentation tweaks for `get_provider()`, added in [28728]
* Inline documentation tweaks for `_add_provider_early()`, added in [28846]
* `@access` tag added for `_remove_provider_early()`, added in [28846]

See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29155 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:22:18 +00:00