Commit Graph

26893 Commits

Author SHA1 Message Date
Andrew Ozz d12c520c5e Remove debug remnants, see #28595
git-svn-id: https://develop.svn.wordpress.org/trunk@29004 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-05 00:24:05 +00:00
Sergey Biryukov 4b9c7b3e1d Add 'status-sticky' class in get_post_class() for sticky posts in the admin.
props mordauk, netweb.
fixes #22590.

git-svn-id: https://develop.svn.wordpress.org/trunk@29003 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-05 00:12:46 +00:00
Sergey Biryukov c1c0693cee Reinstate 'install_themes_tabs' filter.
props ghost1227.
fixes #28578.

git-svn-id: https://develop.svn.wordpress.org/trunk@29002 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:57:39 +00:00
Sergey Biryukov 359fe16c9c Fix alignment of Advanced Options close toggle arrow in Edit Media dialog.
props paulwilde.
fixes #28752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29001 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:37:48 +00:00
Sergey Biryukov c10391dcbe Fix a regression of positioning in Attachment Display Settings.
props paulwilde.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29000 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:28:40 +00:00
Sergey Biryukov fbda6f7c0a Add is_customize_preview(), a conditional function to check if the site is being previewed in the Customizer.
props sammybeats, mattwiebe.
fixes #23509.

git-svn-id: https://develop.svn.wordpress.org/trunk@28999 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 16:16:46 +00:00
Scott Taylor d075028201 Media Grid: JSHint fixes.
See #24716. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28998 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:13:46 +00:00
Scott Taylor 7438b91f6f Media Grid: Use the proper attachment value for `uploadedToTitle`.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28997 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:03:06 +00:00
wonderboymusic 9ba94b5c58 Media Grid: for audio and video files with covers, show that instead of the icon. The filename is still present with the extension to identify the type.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28996 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:59:01 +00:00
Scott Taylor ee29246036 Make media grid text fields (data) toggle-able. Checking/unchecking is saved in user settings cookie.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28995 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:47:40 +00:00
Andrew Ozz fdb58455f6 TinyMCE: improve the way wpViews work. Add two paragraphs and capture the caret in them on clicking before/after/left/right of a view or moving the caret with the arrow keys, then show a "fake" caret.
This makes it much more "natural" to move the caret with the arrow keys and to add paragraphs before a view when it is the first element or after a view when it's last.

Props avryl, see #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@28994 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 03:58:20 +00:00
Helen Hou-Sandi e14d866665 Media grid, round 2. Expect much more to come.
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28993 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 03:38:33 +00:00
Scott Taylor 9c314d1d00 Make a new file: `media-grid.js`. This will be way more useful in later commits and help reduce churn and bloat in `media-views.js`.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28992 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:17:22 +00:00
Scott Taylor b67b45aaa2 The MCE view for galleries needs to read `wp.media.galleryDefaults.columns` after [28990].
See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@28991 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:05:22 +00:00
Scott Taylor 038dc75b66 Allow users to override default gallery settings in JS via `wp_localize_script()`. This is already possible in PHP by filtering `shortcode_atts_gallery`.
Fixes #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@28990 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:02:16 +00:00
Scott Taylor f262fef790 Add more docs for `media.view.MediaFrame.Select` methods.
Props ericlewis.
See #28459.


git-svn-id: https://develop.svn.wordpress.org/trunk@28989 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:42:27 +00:00
Scott Taylor 3708cdc7c2 Bring back `define( 'WP_INSTALLING', true );` in `phpunit/includes/install.php`, which was removed in [28965]. tl;dr = wp-cli. Unit tests still pass in multisite because of the skips I added.
Fixes #28738, #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28988 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:38:43 +00:00
Scott Taylor f8b878f8da `WP_Query::parse_tax_query()` has always been documented as `protected`. Plugins should never have used it. However, it did not have a `protected` access modifier, so its visibility was `public` by default. If the access modifier had been present, accessing the method in a plugin would have produced a fatal error. The access modifier was added in [28523], along with magic methods to allow it to be accessed for BC. This one method is problematic because it expects to be passed a reference. The `WP_Query::__call()` logic does not go out of its way to fix this signature discrepancy, and so a warning is thrown: `Parameter 1 to WP_Query::parse_tax_query() expected to be a reference, value given`.
Remove the `protected` access modifier from `WP_Query::parse_tax_query()`.

Fixes #28739.


git-svn-id: https://develop.svn.wordpress.org/trunk@28987 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:28:02 +00:00
Scott Taylor 4e8afc6caa Optimize regexp usage in `wptexturize()` for a "3x Performance Boost."
Props miqrogroove.
See #28724.


git-svn-id: https://develop.svn.wordpress.org/trunk@28986 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:14:08 +00:00
Scott Taylor 4b58f47a5c Add IE11 to the browser whitelist for MediaElement-based MCE views.
Props azaozz.
Fixes #28742.


git-svn-id: https://develop.svn.wordpress.org/trunk@28985 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:09:25 +00:00
John Blackbourn 4e3b729b09 If we already have a value for WPLANG when installing, insert this language at the top of the language selector and pre-select it. See #28577
git-svn-id: https://develop.svn.wordpress.org/trunk@28984 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:55:57 +00:00
John Blackbourn db8b7380b2 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin
git-svn-id: https://develop.svn.wordpress.org/trunk@28983 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:53:01 +00:00
John Blackbourn 35578f8f9a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28982 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:30:27 +00:00
Helen Hou-Sandi 71704c1156 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
git-svn-id: https://develop.svn.wordpress.org/trunk@28981 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:19:08 +00:00
Helen Hou-Sandi 6d8c6d8728 Don't escape customizer control descriptions, just as section descriptions are not escaped. These are set programmatically, not via user input. props tollmanz. fixes #27981.
git-svn-id: https://develop.svn.wordpress.org/trunk@28980 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:10:29 +00:00
Drew Jaynes (DrewAPicture) 79dd39c19c Note in the hook docs for `preview_post_link` that the `$post` parameter was added.
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:04:56 +00:00
Andrew Nacin a7c3b23f1c Simplify the setup-config.php UI flow and load process.
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@28978 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:56:37 +00:00
Drew Jaynes (DrewAPicture) 26e262f93d Clarify the inline documentation for `plugins_url()` to reflect that it also works with mu-plugins.
Props ericlewis.
See #28499.


git-svn-id: https://develop.svn.wordpress.org/trunk@28977 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:41:23 +00:00
Drew Jaynes (DrewAPicture) b1b454c7a0 Remove backticks on `$post` variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture) 7ffc91fdd6 Fix an incomplete docblock for `wp_create_categories()` as part of `$post/$post_id` cleanup.
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:21:34 +00:00
John Blackbourn c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919.
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 18:47:33 +00:00
John Blackbourn 14bfade4ec Correct typo in `sanitize_html_class()` docblock.
git-svn-id: https://develop.svn.wordpress.org/trunk@28973 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:57:17 +00:00
Helen Hou-Sandi 3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for `oembed_ttl`.
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:44:15 +00:00
Sergey Biryukov ff3644a220 Fix texturization of quotes when enclosed by angle brackets.
props miqrogroove.
fixes #28718.

git-svn-id: https://develop.svn.wordpress.org/trunk@28971 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:21:18 +00:00
Sergey Biryukov 09efb2dab9 Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead.
props westonruter.
fixes #27992.

git-svn-id: https://develop.svn.wordpress.org/trunk@28970 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:10:01 +00:00
Sergey Biryukov 8bf7ed77f3 Pass $post object to 'preview_post_link' filter.
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 14:41:06 +00:00
Scott Taylor 16aa589a07 URLs need to be generated, not hard-coded, in `user/listAuthors.php` test.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28968 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 02:13:08 +00:00
wonderboymusic 26aa4e4e7f Make sure permalink structure is consistent when running query tests.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28967 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:50:02 +00:00
Scott Taylor f23a5ef832 Setup rewrite changes in tests in a predictable fashion. Don't mix method calls with wrapper function calls.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28966 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:42:57 +00:00
Scott Taylor 73bde8a278 Transient timeouts are untestable when `WP_INSTALLING` is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because `wpmu_create_blog()` sets `WP_INSTALLING`. I have zero idea how these tests ever passed.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28965 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 01:16:33 +00:00
Scott Taylor 80a817ebcc Make sure hundreds of canonical tests don't fail in multisite every other time they are run.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28964 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 00:49:32 +00:00
John Blackbourn 53f98b80b7 Prepend "Draft:" to draft post titles when previewing on the front end, and add a "single-status-$status" class to the body classes for all post statuses. Fixes #28006. Props hlashbrooke
git-svn-id: https://develop.svn.wordpress.org/trunk@28963 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 22:52:31 +00:00
Scott Taylor 4379ec80d6 This test in `post/revisions.php` is too misleading and doesn't work as expected since multiple queries can occur before the one that is intended for testing.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28962 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:56:50 +00:00
Scott Taylor d38227dbae `test_wp_get_shortlink()` assumes permalink structure is '' when it starts. It is not.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28961 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:49:05 +00:00
Scott Taylor 59b255c445 URLs in unit tests need to be generated, not hard-coded.
See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28960 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 19:44:08 +00:00
Sergey Biryukov 4a480146c0 Avoing a PHP warning in media modal if the attached file does not exist.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@28959 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:36:29 +00:00
Sergey Biryukov ec0e2beebb Canonical redirects should only be applied for GET requests.
props c.axelsson.
fixes #27498.

git-svn-id: https://develop.svn.wordpress.org/trunk@28958 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:10:07 +00:00
SergeyBiryukov 57029ef3fb Make default 'template' argument of the_taxonomies() and get_the_taxonomies() translatable.
props juliobox.
fixes #28714.

git-svn-id: https://develop.svn.wordpress.org/trunk@28957 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 13:20:02 +00:00
Sergey Biryukov 8ee9631bb4 Remove non-breaking spaces from auto update email text.
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 12:45:31 +00:00
Drew Jaynes (DrewAPicture) 2d9bba0a5c Specify the `$single` parameter default for `get_post_meta()`. Docs spacing.
See #28708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28955 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:29:33 +00:00