2015-08-01 15:34:27 +02:00
|
|
|
/****************************************************************************
|
2017-10-03 20:51:15 +02:00
|
|
|
* sched/semaphore/sem_tickwait.c
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
2020-03-29 16:56:18 +02:00
|
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
|
|
* contributor license agreements. See the NOTICE file distributed with
|
|
|
|
* this work for additional information regarding copyright ownership. The
|
|
|
|
* ASF licenses this file to you under the Apache License, Version 2.0 (the
|
|
|
|
* "License"); you may not use this file except in compliance with the
|
|
|
|
* License. You may obtain a copy of the License at
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
2020-03-29 16:56:18 +02:00
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
2020-03-29 16:56:18 +02:00
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
|
|
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
|
|
* License for the specific language governing permissions and limitations
|
|
|
|
* under the License.
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
|
|
|
****************************************************************************/
|
|
|
|
|
|
|
|
/****************************************************************************
|
|
|
|
* Included Files
|
|
|
|
****************************************************************************/
|
|
|
|
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
#include <time.h>
|
2021-05-18 08:59:14 +02:00
|
|
|
#include <assert.h>
|
2015-08-01 15:34:27 +02:00
|
|
|
#include <errno.h>
|
|
|
|
#include <debug.h>
|
|
|
|
|
2016-02-14 15:17:46 +01:00
|
|
|
#include <nuttx/irq.h>
|
2015-08-01 15:34:27 +02:00
|
|
|
#include <nuttx/arch.h>
|
2015-08-01 22:57:31 +02:00
|
|
|
#include <nuttx/clock.h>
|
2015-08-01 15:34:27 +02:00
|
|
|
#include <nuttx/wdog.h>
|
|
|
|
|
|
|
|
#include "sched/sched.h"
|
|
|
|
#include "semaphore/semaphore.h"
|
|
|
|
|
|
|
|
/****************************************************************************
|
|
|
|
* Public Functions
|
|
|
|
****************************************************************************/
|
|
|
|
|
|
|
|
/****************************************************************************
|
2017-10-03 20:51:15 +02:00
|
|
|
* Name: nxsem_tickwait
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
|
|
|
* Description:
|
|
|
|
* This function is a lighter weight version of sem_timedwait(). It is
|
|
|
|
* non-standard and intended only for use within the RTOS.
|
|
|
|
*
|
2018-03-13 16:52:27 +01:00
|
|
|
* Input Parameters:
|
2015-08-01 15:34:27 +02:00
|
|
|
* sem - Semaphore object
|
2015-08-01 22:57:31 +02:00
|
|
|
* delay - Ticks to wait from the start time until the semaphore is
|
|
|
|
* posted. If ticks is zero, then this function is equivalent
|
2017-10-05 15:59:06 +02:00
|
|
|
* to nxsem_trywait().
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
2018-02-01 17:00:02 +01:00
|
|
|
* Returned Value:
|
2017-10-03 20:51:15 +02:00
|
|
|
* This is an internal OS interface, not available to applications, and
|
|
|
|
* hence follows the NuttX internal error return policy: Zero (OK) is
|
|
|
|
* returned on success. A negated errno value is returned on failure.
|
|
|
|
* -ETIMEDOUT is returned on the timeout condition.
|
2015-08-01 15:34:27 +02:00
|
|
|
*
|
|
|
|
****************************************************************************/
|
|
|
|
|
2022-05-10 02:33:09 +02:00
|
|
|
int nxsem_tickwait(FAR sem_t *sem, uint32_t delay)
|
2015-08-01 15:34:27 +02:00
|
|
|
{
|
2016-02-07 00:44:41 +01:00
|
|
|
FAR struct tcb_s *rtcb = this_task();
|
2021-12-09 08:08:01 +01:00
|
|
|
irqstate_t flags;
|
2015-08-01 15:34:27 +02:00
|
|
|
int ret;
|
|
|
|
|
2020-08-04 12:31:31 +02:00
|
|
|
DEBUGASSERT(sem != NULL && up_interrupt_context() == false);
|
2015-08-01 15:34:27 +02:00
|
|
|
|
2021-12-09 08:08:01 +01:00
|
|
|
/* We will disable interrupts until we have completed the semaphore
|
|
|
|
* wait. We need to do this (as opposed to just disabling pre-emption)
|
|
|
|
* because there could be interrupt handlers that are asynchronously
|
|
|
|
* posting semaphores and to prevent race conditions with watchdog
|
|
|
|
* timeout. This is not too bad because interrupts will be re-
|
|
|
|
* enabled while we are blocked waiting for the semaphore.
|
2015-08-01 15:34:27 +02:00
|
|
|
*/
|
|
|
|
|
2021-12-09 08:08:01 +01:00
|
|
|
flags = enter_critical_section();
|
|
|
|
|
2015-08-01 15:34:27 +02:00
|
|
|
/* Try to take the semaphore without waiting. */
|
|
|
|
|
2017-10-05 15:59:06 +02:00
|
|
|
ret = nxsem_trywait(sem);
|
2015-08-01 15:34:27 +02:00
|
|
|
if (ret == OK)
|
|
|
|
{
|
|
|
|
/* We got it! */
|
|
|
|
|
2021-12-13 04:15:40 +01:00
|
|
|
goto out;
|
2015-08-01 15:34:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* We will have to wait for the semaphore. Make sure that we were provided
|
|
|
|
* with a valid timeout.
|
|
|
|
*/
|
|
|
|
|
2015-08-01 22:57:31 +02:00
|
|
|
if (delay == 0)
|
2015-08-01 15:34:27 +02:00
|
|
|
{
|
2017-10-05 15:59:06 +02:00
|
|
|
/* Return the errno from nxsem_trywait() */
|
2015-08-01 15:34:27 +02:00
|
|
|
|
2021-12-13 04:15:40 +01:00
|
|
|
goto out;
|
2015-08-01 15:34:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Start the watchdog with interrupts still disabled */
|
|
|
|
|
2023-02-01 11:05:58 +01:00
|
|
|
wd_start(&rtcb->waitdog, delay, nxsem_timeout, nxsched_gettid());
|
2015-08-01 15:34:27 +02:00
|
|
|
|
|
|
|
/* Now perform the blocking wait */
|
|
|
|
|
2017-10-04 23:22:27 +02:00
|
|
|
ret = nxsem_wait(sem);
|
2020-08-04 12:31:31 +02:00
|
|
|
|
|
|
|
/* Stop the watchdog timer */
|
|
|
|
|
|
|
|
wd_cancel(&rtcb->waitdog);
|
|
|
|
|
2021-12-09 08:08:01 +01:00
|
|
|
/* We can now restore interrupts */
|
|
|
|
|
2021-12-13 04:15:40 +01:00
|
|
|
out:
|
2021-12-09 08:08:01 +01:00
|
|
|
leave_critical_section(flags);
|
2015-08-01 15:34:27 +02:00
|
|
|
return ret;
|
|
|
|
}
|
2020-03-29 16:56:18 +02:00
|
|
|
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
/****************************************************************************
|
|
|
|
* Name: nxsem_tickwait_uninterruptible
|
|
|
|
*
|
|
|
|
* Description:
|
|
|
|
* This function is wrapped version of nxsem_tickwait(), which is
|
|
|
|
* uninterruptible and convenient for use.
|
|
|
|
*
|
|
|
|
* Input Parameters:
|
|
|
|
* sem - Semaphore object
|
|
|
|
* delay - Ticks to wait from the start time until the semaphore is
|
|
|
|
* posted. If ticks is zero, then this function is equivalent
|
|
|
|
* to sem_trywait().
|
|
|
|
*
|
|
|
|
* Returned Value:
|
2020-03-29 16:56:18 +02:00
|
|
|
* This is an internal OS interface, not available to applications, and
|
|
|
|
* hence follows the NuttX internal error return policy: Zero (OK) is
|
|
|
|
* returned on success. A negated errno value is returned on failure:
|
|
|
|
*
|
|
|
|
* -ETIMEDOUT is returned on the timeout condition.
|
|
|
|
* -ECANCELED may be returned if the thread is canceled while waiting.
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
*
|
|
|
|
****************************************************************************/
|
|
|
|
|
2022-05-10 02:33:09 +02:00
|
|
|
int nxsem_tickwait_uninterruptible(FAR sem_t *sem, uint32_t delay)
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
{
|
2022-05-10 02:33:09 +02:00
|
|
|
clock_t end = clock_systime_ticks() + delay;
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
int ret;
|
|
|
|
|
2022-05-10 02:33:09 +02:00
|
|
|
for (; ; )
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
{
|
|
|
|
/* Take the semaphore (perhaps waiting) */
|
|
|
|
|
2022-05-10 02:33:09 +02:00
|
|
|
ret = nxsem_tickwait(sem, delay);
|
|
|
|
if (ret != -EINTR)
|
|
|
|
{
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
delay = end - clock_systime_ticks();
|
|
|
|
if ((int32_t)delay < 0)
|
|
|
|
{
|
|
|
|
delay = 0;
|
|
|
|
}
|
include/nuttx: Fix improper use of inline
I finally figured out why the ez80 code has gotten so big. It is because people have been put putting big inline functions in header files. That is a violation of the coding standard, since only c89 compatibility is required in all common code. But we have been tolerating inline function it because include/nuttx/compiler.h defines 'inline' to be nothing for C89 compilers.
As a result, static inline functions declared within a C file not so bad; the inline qualifier is ignored, if not supported, but otherwise all is well.
But it is catastrophic in header files. Those static inline functions are included as static functions and implemented in EVERY file that includes those header files, even if the functions are never called. That makes the code base huge!So there is another PR coming to fix some of the worst offenders.
This commit fixes two of the worst offenders I have encountered so far: include/nuttx/sempahore.h and cache.h. But there may be a few other changes needed. Under include/nuttx there are still inline functions thread.h, inclue/nuttx/list.h, mutex.h, tree.h, and include/nuttx/crypto/blake2s.h with no protection for compilers that do not handler the inline qualifier. Otherwise we are clean.
With the changes to these two header files, the size of the z20x build is reduced by about 40%. And incredible size savings.
2020-03-02 21:51:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|