sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
9e5d3dacd6
nuttx/tools/nxstyle.c

3419 lines
101 KiB
C
Raw Normal View History

nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* tools/nxstyle.c
*
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership. The
* ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
* http://www.apache.org/licenses/LICENSE-2.0
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* Included Files
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
#include <stdlib.h>
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
#include <stdbool.h>
#include <stdio.h>
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
#include <stdint.h>
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
#include <string.h>
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
#include <strings.h>
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
#include <ctype.h>
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
#include <limits.h>
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
#include <unistd.h>
#include <libgen.h>
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* Pre-processor Definitions
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
#define NXSTYLE_VERSION "0.01"
#define LINE_SIZE 512
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
#define RANGE_NUMBER 4096
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
#define DEFAULT_WIDTH 78
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
#define FIRST_SECTION INCLUDED_FILES
#define LAST_SECTION PUBLIC_FUNCTION_PROTOTYPES
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
#define FATAL(m, l, o) message(FATAL, (m), (l), (o))
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
#define FATALFL(m, s) message(FATAL, (m), -1, -1)
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
#define WARN(m, l, o) message(WARN, (m), (l), (o))
#define ERROR(m, l, o) message(ERROR, (m), (l), (o))
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
#define ERRORFL(m, s) message(ERROR, (m), -1, -1)
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
#define INFO(m, l, o) message(INFO, (m), (l), (o))
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
#define INFOFL(m, s) message(INFO, (m), -1, -1)
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
* Private types
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
enum class_e
{
INFO,
WARN,
ERROR,
FATAL
};
const char *class_text[] =
{
"info",
"warning",
"error",
"fatal"
};
enum file_e
{
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
UNKNOWN = 0x00,
C_HEADER = 0x01,
C_SOURCE = 0x02
};
enum section_s
{
NO_SECTION = 0,
INCLUDED_FILES,
PRE_PROCESSOR_DEFINITIONS,
PUBLIC_TYPES,
PRIVATE_TYPES,
PRIVATE_DATA,
PUBLIC_DATA,
PRIVATE_FUNCTIONS,
PRIVATE_FUNCTION_PROTOTYPES,
INLINE_FUNCTIONS,
PUBLIC_FUNCTIONS,
PUBLIC_FUNCTION_PROTOTYPES
};
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
enum pptype_e
{
PPLINE_NONE = 0,
PPLINE_DEFINE,
Added assembly header detection.
2020-03-14 14:36:47 +01:00
PPLINE_IF,
PPLINE_ELIF,
PPLINE_ELSE,
PPLINE_ENDIF,
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
PPLINE_OTHER
};
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
struct file_section_s
{
const char *name; /* File section name */
uint8_t ftype; /* File type where section found */
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
};
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
* Private data
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
static enum file_e g_file_type = UNKNOWN;
static enum section_s g_section = NO_SECTION;
static int g_maxline = DEFAULT_WIDTH;
static int g_status = 0;
static int g_verbose = 2;
static int g_rangenumber = 0;
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
static int g_rangestart[RANGE_NUMBER];
static int g_rangecount[RANGE_NUMBER];
tools/nxstyle: Verify relative path in the file header
2021-03-04 20:34:39 +01:00
static char g_file_name[PATH_MAX];
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
static bool g_skipmixedcase;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
static const struct file_section_s g_section_info[] =
{
{
" *\n", /* Index: NO_SECTION */
C_SOURCE | C_HEADER
},
{
" * Included Files\n", /* Index: INCLUDED_FILES */
C_SOURCE | C_HEADER
},
{
" * Pre-processor Definitions\n", /* Index: PRE_PROCESSOR_DEFINITIONS */
C_SOURCE | C_HEADER
},
{
" * Public Types\n", /* Index: PUBLIC_TYPES */
C_HEADER
},
{
" * Private Types\n", /* Index: PRIVATE_TYPES */
C_SOURCE
},
{
" * Private Data\n", /* Index: PRIVATE_DATA */
C_SOURCE
},
{
" * Public Data\n", /* Index: PUBLIC_DATA */
C_SOURCE | C_HEADER
},
{
" * Private Functions\n", /* Index: PRIVATE_FUNCTIONS */
C_SOURCE
},
{
" * Private Function Prototypes\n", /* Index: PRIVATE_FUNCTION_PROTOTYPES */
C_SOURCE
},
{
" * Inline Functions\n", /* Index: INLINE_FUNCTIONS */
C_SOURCE | C_HEADER
},
{
" * Public Functions\n", /* Index: PUBLIC_FUNCTIONS */
C_SOURCE
},
{
" * Public Function Prototypes\n", /* Index: PUBLIC_FUNCTION_PROTOTYPES */
tools/nxstyle.c: All Public Function Prototypes in C files Allow "Public Function Prototypes" sections in .c files. Per the coding standard, all public function prototypes belong in .c files. However, there are some situations when the public function prototype is needed in a .c file and it shoudld, most correctly, be placed in a "Public Function Prototypes" section.
2020-04-01 21:38:53 +02:00
C_SOURCE | C_HEADER
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
}
};
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
static const char *g_white_prefix[] =
{
tools/nxstyle: Order g_white_prefix by alphanum Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-03-20 16:33:40 +01:00
"ASCII_", /* Ref: include/nuttx/ascii.h */
nxstyle: Add Dl_info to white list Avoid the mixed case identifiers warning for Dl_info which is from the POSIX. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
2024-07-26 11:41:57 +02:00
"Dl_info", /* Ref: include/dlfcn.h */
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
"Elf", /* Ref: include/elf.h, include/elf32.h, include/elf64.h */
nxstyle: Add more inttypes.h stuff to the whitelist
2020-11-05 13:51:38 +01:00
"PRId", /* Ref: inttypes.h */
"PRIi", /* Ref: inttypes.h */
"PRIo", /* Ref: inttypes.h */
"PRIu", /* Ref: inttypes.h */
"PRIx", /* Ref: inttypes.h */
"SCNd", /* Ref: inttypes.h */
"SCNi", /* Ref: inttypes.h */
"SCNo", /* Ref: inttypes.h */
"SCNu", /* Ref: inttypes.h */
"SCNx", /* Ref: inttypes.h */
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
"SYS_", /* Ref: include/sys/syscall.h */
"STUB_", /* Ref: syscall/syscall_lookup.h, syscall/sycall_stublookup.c */
tools/nxstyle: Order g_white_prefix by alphanum Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-03-20 16:33:40 +01:00
"XK_", /* Ref: include/input/X11_keysymdef.h */
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
"b8", /* Ref: include/fixedmath.h */
"b16", /* Ref: include/fixedmath.h */
"b32", /* Ref: include/fixedmath.h */
"ub8", /* Ref: include/fixedmath.h */
"ub16", /* Ref: include/fixedmath.h */
"ub32", /* Ref: include/fixedmath.h */
nxstyle: ignore mixed-case identifiers for Lua types
2022-03-19 17:22:42 +01:00
"lua_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lua.h */
"luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */
Move video_controls.h from include/nuttx/video to include/sys The video_controls.h is a public header file, and it is used by videoio.h. So it should be moved to the include/sys directory. Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2024-02-03 14:15:50 +01:00
"V4L2_", /* Ref: include/sys/video_controls.h */
tools/nxstyle: add infineon prefix into ignore list add infineon prefix into ignore list to avoid nxstyle warning Signed-off-by: chao an <anchao@lixiang.com>
2024-02-18 08:52:30 +01:00
"Ifx", /* Ref: arch/tricore/src */
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
NULL
};
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
static const char *g_white_suffix[] =
{
tools/nxstyle: Add kbps to the while suffix list and correct offset by 1 error Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 14:31:29 +02:00
/* Ref: include/nuttx/wireless/nrf24l01.h */
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
"Mbps",
tools/nxstyle: Add kbps to the while suffix list and correct offset by 1 error Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 14:31:29 +02:00
"kHz",
"kbps",
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
"us",
NULL
};
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
static const char *g_white_content_list[] =
tools/nxstyle: Support the white list and add _Exit to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-06-22 18:14:42 +02:00
{
tools: nxstyle: add L_tmpnam/P_tmpdir exceptions Those exceptions are defined in https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-03-03 14:50:27 +01:00
/* Ref: gnu_unwind_find_exidx.c */
"__EIT_entry",
/* Ref: gnu_unwind_find_exidx.c */
"__gnu_Unwind_Find_exidx",
tools/nxstyle: Add __sFILE_fake(defined by newlib) to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-03 14:19:02 +02:00
/* Ref: lib_impure.c */
"__sFILE_fake",
tools: nxstyle: add L_tmpnam/P_tmpdir exceptions Those exceptions are defined in https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-03-03 14:50:27 +01:00
/* Ref: stdlib.h */
"_Exit",
tools/nxstyle: Add _Atomic keyword to whitelisted words
2021-05-06 14:22:42 +02:00
/* Ref: stdatomic.h */
"_Atomic",
libm/newlib: add newlib/libm support Signed-off-by: yanghuatao <yanghuatao@xiaomi.com>
2023-04-22 13:08:00 +02:00
/* Ref: https://en.cppreference.com/w/c/keyword/_Thread_local */
"_Thread_local",
tools: nxstyle: add L_tmpnam/P_tmpdir exceptions Those exceptions are defined in https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-03-03 14:50:27 +01:00
/* Ref: unwind-arm-common.h */
tools/nxstyle: rename exception _Unwind_Ptr to _Unwind to support fuzzy match Signed-off-by: chao.an <anchao@xiaomi.com>
2021-04-19 07:55:34 +02:00
"_Unwind",
tools: nxstyle: add L_tmpnam/P_tmpdir exceptions Those exceptions are defined in https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-03-03 14:50:27 +01:00
/* Ref:
* https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html
*/
"P_tmpdir",
/* Ref:
* https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html
*/
"L_tmpnam",
tools: nxstyle: add exception for X11 keysymdef Add exception for XK_* Mixed Case defined by X11 keysymdef.h Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-04-03 17:37:27 +02:00
/* Ref:
* nuttx/compiler.h
*/
nxstyle: add Mixed Case exceptions Add _Far and _Erom to the mixed case exceptions Ref: nuttx/compiler.h Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-03-29 20:28:58 +02:00
"_Far",
"_Erom",
tools/nxstyle: fixed "Mixed case identifier found" errors related to sim/wpcap
2022-01-27 02:16:14 +01:00
/* Ref:
* arch/sim/src/sim/up_wpcap.c
*/
"Address",
"Description",
"FirstUnicastAddress",
"GetAdaptersAddresses",
"GetProcAddress",
"LoadLibrary",
"lpSockaddr",
"Next",
"PhysicalAddressLength",
"PhysicalAddress",
"WideCharToMultiByte",
tools/nxstyle: add Segger System View prototype name into white list Reference: https: //github.com/SEGGERMicro/SystemView/blob/master/SYSVIEW/SEGGER_SYSVIEW.h Signed-off-by: chao.an <anchao@xiaomi.com>
2022-01-24 14:46:17 +01:00
/* Ref:
* drivers/segger/note_sysview.c
*/
"SEGGER_SYSVIEW",
"TaskID",
"sName",
"Prio",
"StackBase",
"StackSize",
tools/nxstyle: add Segger RTT prototype name into white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-01-31 10:31:32 +01:00
/* Ref:
* drivers/segger/syslog_rtt.c
*/
"SEGGER_RTT",
tools: nxstyle: add exception for X11 keysymdef Add exception for XK_* Mixed Case defined by X11 keysymdef.h Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-04-03 17:37:27 +02:00
/* Ref:
* fs/nfs/rpc.h
* fs/nfs/nfs_proto.h
nuttx:Change fs strncpy to strlcpy to avoid losing'\0' Signed-off-by: zhouliang3 <zhouliang3@xiaomi.com>
2021-12-29 13:17:34 +01:00
* fs/nfs/nfs_mount.h
* fs/nfs/nfs_vfsops.c
tools: nxstyle: add exception for X11 keysymdef Add exception for XK_* Mixed Case defined by X11 keysymdef.h Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-04-03 17:37:27 +02:00
*/
tools: nxstyle: add Mixed case exceptions for nfs add exceptions for nfs to avoid future false warnings Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-04-03 14:48:33 +02:00
"CREATE3args",
"CREATE3resok",
"LOOKUP3args",
"LOOKUP3filename",
"LOOKUP3resok",
"WRITE3args",
"WRITE3resok",
"READ3args",
"READ3resok",
"REMOVE3args",
"REMOVE3resok",
"RENAME3args",
"RENAME3resok",
"MKDIR3args",
"MKDIR3resok",
"RMDIR3args",
"RMDIR3resok",
"READDIR3args",
"READDIR3resok",
"SETATTR3args",
"SETATTR3resok",
"FS3args",
nuttx:Change fs strncpy to strlcpy to avoid losing'\0' Signed-off-by: zhouliang3 <zhouliang3@xiaomi.com>
2021-12-29 13:17:34 +01:00
"SIZEOF_rpc_reply_read",
"SIZEOF_rpc_call_write",
"SIZEOF_rpc_reply_readdir",
"SIZEOF_nfsmount",
tools: nxstyle: add Mixed case exceptions for nfs add exceptions for nfs to avoid future false warnings Signed-off-by: Alin Jerpelea <alin.jerpelea@sony.com>
2021-04-03 14:48:33 +02:00
mm: Support the kernel address sanitizer Signed-off-by: chenwei23 <chenwei23@xiaomi.com>
2021-10-09 09:22:28 +02:00
/* Ref:
* mm/kasan/kasan.c
*/
"__asan_loadN",
"__asan_storeN",
"__asan_loadN_noabort",
"__asan_storeN_noabort",
Fix jlink-nuttx build with GCC 10.2 The packed-attribute on the tcb_info_s type was misplaced, which caused incompatible memory layout between host and target. According to current GCC documentation: > You may specify type attributes in an enum, struct or union type > declaration or definition by placing them immediately after the struct, > union or enum keyword. You can also place them just past the closing > curly brace of the definition, but this is less preferred because > logically the type should be fully defined at the closing brace. I also added jlink-nuttx.so to the .gitignore list and updated nxstyle to ignore the camel case function names required by JLinkGDBServer. Signed-off-by: Michael Jung <mijung@gmx.net>
2022-02-14 20:29:52 +01:00
/* Ref:
* tools/jlink-nuttx.c
*/
"RTOS_Init",
"RTOS_GetVersion",
"RTOS_GetSymbols",
"RTOS_GetNumThreads",
"RTOS_GetCurrentThreadId",
"RTOS_GetThreadId",
"RTOS_GetThreadDisplay",
"RTOS_GetThreadReg",
"RTOS_GetThreadRegList",
"RTOS_GetThreadRegList",
"RTOS_SetThreadReg",
"RTOS_SetThreadRegList",
"RTOS_UpdateThreads",
tools/nxstyle: add more white list for sim arch
2022-11-19 13:46:37 +01:00
/* Ref:
* sim/posix/sim_x11eventloop.c
*/
"Display",
"Button1Mask",
"Button2Mask",
"Button3Mask",
"Button1",
"Button2",
"Button3",
"XEvent",
"XPending",
"XNextEvent",
"KeyPress",
"KeyRelease",
"MotionNotify",
"ButtonPress",
"ButtonRelease",
"XLookupKeysym",
/* Ref:
* sim/posix/sim_x11framebuffer.c
*/
"Window",
"XShmSegmentInfo",
"XImage",
"XGCValues",
"XTextProperty",
"XSizeHints",
"XOpenDisplay",
"XCreateSimpleWindow",
"DefaultRootWindow",
"XStringListToTextProperty",
"XSetWMProperties",
"XMapWindow",
"XSelectInput",
"XAllowEvents",
"XGrabButton",
"XCreateGC",
"XSetErrorHandler",
"XSync",
"XShmDetach",
"XDestroyImage",
"XUngrabButton",
"XCloseDisplay",
"XShmQueryExtension",
"XShmCreateImage",
"XShmAttach",
"DefaultVisual",
"XCreateImage",
"XGetWindowAttributes",
"DefaultColormap",
"XAllocColor",
"XShmPutImage",
"XPutImage",
"Colormap",
"DefaultScreen",
"BlackPixel",
"PSize",
"PMinSize",
"PMaxSize",
"ButtonPressMask",
"ButtonReleaseMask",
"PointerMotionMask",
"KeyPressMask",
"KeyReleaseMask",
"ButtonMotionMask",
"GrabModeAsync",
"GCGraphicsExposures",
"XErrorEvent",
"AnyModifier",
"None",
"Status",
"DoGreen",
"DoRed",
"DoBlue",
"ZPixmap",
"readOnly",
"XWindowAttributes",
"XColor",
"AsyncBoth",
"CurrentTime",
mm/alloc: remove all unnecessary cast for alloc Fix the minor style issue and remove unnecessary cast Signed-off-by: chao an <anchao@xiaomi.com>
2023-08-28 09:39:47 +02:00
"XUnmapWindow",
sim: read the second buffer It can only read the contents of the first buffer, so fblen should be changed to ensure that it can read the second buffer as well. Signed-off-by: jianglianfang <jianglianfang@xiaomi.com>
2024-01-24 04:01:35 +01:00
"XFree",
tools/nxstyle: add more white list for sim arch
2022-11-19 13:46:37 +01:00
Add v4l2m2m & sim decoder Signed-off-by: shizhenghui <shizhenghui@xiaomi.com>
2024-03-21 12:03:16 +01:00
/* Ref:
* nuttx/arch/sim/src/sim_hostdecoder.*
*/
"ISVCDecoder",
"SBufferInfo",
"SDecodingParam",
"eEcActiveIdc",
"sVideoProperty",
"eVideoBsType",
"cmResultSuccess",
"uiInBsTimeStamp",
"dsErrorFree",
"iBufferStatus",
"UsrData",
"sSystemBuffer",
"iWidth",
"iHeight",
"iStride",
"uiOutYuvTimeStamp",
"WelsCreateDecoder",
"WelsDestroyDecoder",
"Initialize",
"Uninitialize",
"DecodeFrame2",
"FlushFrame",
"SetOption",
"GetOption",
tools/nxstyle: add more white list for sim arch
2022-11-19 13:46:37 +01:00
/* Ref:
* sim/posix/sim_deviceimage.c
*/
"inflateInit",
"inflateEnd",
"Bytef",
/* Ref:
* sim/posix/sim_hostmemory.c
*/
"CreateFileMapping",
"MapViewOfFile",
"CloseHandle",
"UnmapViewOfFile",
/* Ref:
* sim/posix/sim_hostmisc.c
*/
"CaptureStackBackTrace",
/* Ref:
* sim/posix/sim_hosttime.c
*/
"GetSystemTimeAsFileTime",
"QueryPerformanceFrequency",
"QueryPerformanceCounter",
"CreateWaitableTimer",
"SetWaitableTimer",
"WaitForSingleObject",
"dwHighDateTime",
"dwLowDateTime",
"QuadPart",
/* Ref:
arch/sim: Unify the host soruce file naming Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-11-21 20:08:47 +01:00
* sim/posix/sim_hostuart.c
tools/nxstyle: add more white list for sim arch
2022-11-19 13:46:37 +01:00
*/
"GetStdHandle",
"GetConsoleMode",
"SetConsoleMode",
"WriteConsole",
"ReadConsole",
"FlushConsoleInputBuffer",
"GetNumberOfConsoleInputEvents",
nxstyle: add "CMUnitTest" to nxstyle white list https://github.com/apache/nuttx-apps/pull/1575 need this Signed-off-by: wangbowen6 <wangbowen6@xiaomi.com>
2023-02-17 11:19:05 +01:00
/* Ref:
* apps/testing/drivertest/drivertest_xxx.c
*/
"CMUnitTest",
tools: nxstyle: add "NimMain" to whitelists. Signed-off-by: Takeyoshi Kikuchi <kikuchi@centurysys.co.jp>
2023-02-26 07:48:03 +01:00
/* Ref:
* apps/examples/hello_nim/hello_nim_main.c
*/
"NimMain",
sim/usb: add sim usb device Signed-off-by: zhangyuan21 <zhangyuan21@xiaomi.com>
2022-12-01 02:54:11 +01:00
/* Ref:
* sim/posix/sim_rawgadget.c
*/
"bRequestType",
"bRequest",
"wValue",
"wIndex",
"wLength",
"bLength",
"bDescriptorType",
"bEndpointAddress",
"bmAttributes",
"wMaxPacketSize",
"bInterval",
sim/usb: add sim usb host signed-off-by: zhangyuan21 <zhangyuan21@xiaomi.com>
2022-11-30 12:08:14 +01:00
/* Ref:
* sim/posix/sim_libusb.c
*/
"bNumConfigurations",
"bDeviceClass",
"idVendor",
"idProduct",
tools/nxstyle: add "_NSGetExecutablePath" into ignore list sim/posix/sim_hostmisc.c:128:6: error: Mixed case identifier found Signed-off-by: chao an <anchao@xiaomi.com>
2023-05-16 08:46:35 +02:00
/* Ref:
* sim/posix/sim_hostmisc.c
*/
"_NSGetExecutablePath",
tools/nxstyle: add 'IRQn_Type' to whitelists
2023-03-05 14:30:31 +01:00
/* Ref:
* arch/arm/src/nrf52/sdc/nrf.h
* arch/arm/src/nrf53/sdc/nrf.h
*/
"IRQn_Type",
fs:support zipfs,can mount zipfile we can mount a zipfile in nuttx use mount command like this: mount -t zipfs -o /data/test.zip /zip The zipfs is a read only file system,The advantage is that it does not occupy additional space when reading the decompressed file. When used, reading and decompression operations are simultaneous. The known disadvantage is that when using seek to read forward, it will reopen and cause slow speed problems. Signed-off-by: anjiahao <anjiahao@xiaomi.com>
2023-09-25 10:25:34 +02:00
/* Ref:
* fs/zipfs/zip_vfs.c
*/
"unzFile",
"uLong",
"unzOpen2_64",
"unzLocateFile",
"unzOpenCurrentFile",
"unzClose",
"unzReadCurrentFile",
"unzGetCurrentFileInfo64",
"unzGoToNextFile",
"unzGoToFirstFile",
tools/nxstyle: Support the white list and add _Exit to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-06-22 18:14:42 +02:00
NULL
};
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
static const char *g_white_headers[] =
{
"windows.h",
tools/nxstyle: add infineon prefix into ignore list add infineon prefix into ignore list to avoid nxstyle warning Signed-off-by: chao an <anchao@lixiang.com>
2024-02-18 08:52:30 +01:00
/* Ref:
* arch/tricore/src/common/tricore_serial.c
*/
"IfxAsclin_Asc.h",
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
NULL
};
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
static const char *g_white_files[] =
{
/* Skip assembler file headers
* Ref:
* libs/libc/machine/arm/arm-acle-compat.h
* libs/libc/machine/arm/arm_asm.h
*/
"arm-acle-compat.h",
"arm_asm.h",
NULL
};
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
* Private Functions
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: show_usage
*
* Description:
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
static void show_usage(char *progname, int exitcode, char *what)
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
fprintf(stderr, "%s version %s\n\n", basename(progname), NXSTYLE_VERSION);
if (what)
{
fprintf(stderr, "%s\n", what);
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
fprintf(stderr, "Usage: %s [-m <excess>] [-v <level>] "
"[-r <start,count>] <filename>\n",
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
basename(progname));
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
fprintf(stderr, " %s -h this help\n", basename(progname));
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
fprintf(stderr, " %s -v <level> where level is\n",
basename(progname));
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
fprintf(stderr, " 0 - no output\n");
fprintf(stderr, " 1 - PASS/FAIL\n");
fprintf(stderr, " 2 - output each line (default)\n");
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
exit(exitcode);
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: skip
*
* Description:
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
static int skip(int lineno)
{
int i;
for (i = 0; i < g_rangenumber; i++)
{
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
if (lineno >= g_rangestart[i] && lineno < g_rangestart[i] +
g_rangecount[i])
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
{
return 0;
}
}
return g_rangenumber != 0;
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: message
*
* Description:
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
static int message(enum class_e class, const char *text, int lineno, int ndx)
{
FILE *out = stdout;
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
if (skip(lineno))
{
return g_status;
}
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
if (class > INFO)
{
out = stderr;
g_status |= 1;
}
if (g_verbose == 2)
{
if (lineno == -1 && ndx == -1)
{
Nxstyle checkpatch support (#47) * tools/nxstyle.c: Donot check unknown file extension files nxstyle only support c soure file and header file check, donot check other unknown file extension files. * tools/checkpatch.sh: Add checkpatch.sh script based on nxstyle tool Usage: checkpatch.sh patch-list // default as patch list checkpatch.sh -p patch-list checkpatch.sh -c commit-list checkpatch.sh -f file-list checkpatch.sh - // read from stdin, which used by git pre-commit hook And git pre-commit hook could use checkpatch.sh as below: git diff --cached | ./tools/checkpatch.sh -
2020-01-07 15:12:18 +01:00
fprintf(out, "%s: %s: %s\n", g_file_name, class_text[class], text);
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
}
else
{
fprintf(out, "%s:%d:%d: %s: %s\n", g_file_name, lineno, ndx,
class_text[class], text);
}
}
return g_status;
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: check_spaces_left
*
* Description:
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
static void check_spaces_left(char *line, int lineno, int ndx)
{
/* Unary operator should generally be preceded by a space but make also
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
* follow a left parenthesis at the beginning of a parenthetical list or
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
* expression or follow a right parentheses in the case of a cast.
*/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
if (ndx-- > 0 && line[ndx] != ' ' && line[ndx] != '(' && line[ndx] != ')')
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Operator/assignment must be preceded with whitespace",
lineno, ndx);
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: check_spaces_leftright
*
* Description:
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
static void check_spaces_leftright(char *line, int lineno, int ndx1, int ndx2)
{
if (ndx1 > 0 && line[ndx1 - 1] != ' ')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Operator/assignment must be preceded with whitespace",
lineno, ndx1);
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
if (line[ndx2 + 1] != '\0' && line[ndx2 + 1] != '\n' && line[ndx2 + 1] != ' ')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Operator/assignment must be followed with whitespace",
lineno, ndx2);
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
}
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
/********************************************************************************
* Name: check_nospaces_leftright
*
* Description:
* Check if there are whitespaces on the left of right. If there is, report
* an error.
*
********************************************************************************/
static void check_nospaces_leftright(char *line, int lineno, int ndx1, int ndx2)
{
if (ndx1 > 0 && line[ndx1 - 1] == ' ')
{
ERROR("There should be no spaces before the operator/assignment",
lineno, ndx1);
}
if (line[ndx2 + 1] == ' ')
{
ERROR("There should be no spaces after the operator/assignment",
lineno, ndx2);
}
}
/********************************************************************************
* Name: check_operand_leftright
*
* Description:
* Check if the operator is next to an operand. If not, report the error.
*
********************************************************************************/
static void check_operand_leftright(char *line, int lineno, int ndx1, int ndx2)
{
/* The cases below includes("xx" represents the operator):
* " xx " | " xx(end)" | " xx;" | " xx\n" | " xx)" | " xx]" - (ndx1 > 0)
* "(xx " | "(xx(end)" | "(xx;" | "(xx\n" | "(xx)" | "(xx]" - (ndx1 > 0)
* "[xx " | "[xx(end)" | "[xx;" | "[xx\n" | "[xx)" | "[xx]" - (ndx1 > 0)
* "xx " | "xx(end)" | "xx;" | "xx\n" | "xx)" | "xx]" - (ndx1 = 0)
* In these cases, the operators must be not next any operands, thus errors
* are reported.
*/
if (ndx1 > 0 && (line[ndx1 - 1] == ' ' || line[ndx1 - 1] == '(' ||
line[ndx1 - 1] == '[') &&
(line[ndx2 + 1] == ' ' || line[ndx2 + 1] == '\0' ||
line[ndx2 + 1] == ';' || line[ndx2 + 1] == '\n' ||
line[ndx2 + 1] == ')' || line[ndx2 + 1] == ']'))
{
ERROR("Operator must be next to an operand", lineno, ndx2);
}
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: block_comment_width
*
* Description:
* Get the width of a block comment
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
static int block_comment_width(char *line)
{
int b;
int e;
int n;
/* Skip over any leading whitespace on the line */
for (b = 0; isspace(line[b]); b++)
{
}
/* Skip over any trailing whitespace at the end of the line */
tools/nxstyle: Fix AddressSanitizer error ================================================================= ==2474==ERROR: AddressSanitizer: stack-buffer-underflow on address 0x7fffb7e59b5f at pc 0x561fffec79f6 bp 0x7fffb7e59ac0 sp 0x7fffb7e59ab0 READ of size 1 at 0x7fffb7e59b5f thread T0 #0 0x561fffec79f5 in block_comment_width /home/xiaoxiang/mirtos/nuttx/tools/nxstyle.c:355 Address 0x7fffb7e59b5f is located in stack of thread T0 at offset 31 in frame #0 0x561fffec7b90 in get_line_width /home/xiaoxiang/mirtos/nuttx/tools/nxstyle.c:419 This frame has 1 object(s): [32, 544) 'line' (line 420) <== Memory access at offset 31 underflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-underflow /home/xiaoxiang/mirtos/nuttx/tools/nxstyle.c:355 in block_comment_width Shadow bytes around the buggy address: 0x100076fc3310: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3320: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3330: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3340: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x100076fc3360: 00 00 00 00 00 00 00 00 f1 f1 f1[f1]00 00 00 00 0x100076fc3370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc3390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x100076fc33a0: 00 00 00 00 00 00 00 00 00 00 00 00 f3 f3 f3 f3 0x100076fc33b0: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==2474==ABORTING Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> Change-Id: Ie7dee3cdfdbbd04ea9cdb58e227afef07073cecd
2020-06-16 16:00:15 +02:00
for (e = strlen(line) - 1; e >= 0 && isspace(line[e]); e--)
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
{
}
/* Number of characters on the line */
n = e - b + 1;
if (n < 4)
{
return 0;
}
/* The first line of a block comment starts with "[slash]***" and ends with
* "***"
*/
if (strncmp(&line[b], "/***", 4) == 0 &&
strncmp(&line[e - 2], "***", 3) == 0)
{
/* Return the the length of the line up to the final '*' */
return e + 1;
}
/* The last line of a block begins with whitespace then "***" and ends
* with "***[slash]"
*/
if (strncmp(&line[b], "***", 3) == 0 &&
tools/nxstyle.c: Correct indexing error noted by Xaio Xaing in commit comments.
2020-01-12 18:47:11 +01:00
strncmp(&line[e - 3], "***/", 4) == 0)
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
{
/* Return the the length of the line up to the final '*' */
return e;
}
/* But there is also a special single line comment that begins with "[slash]* "
* and ends with "***[slash]"
*/
if (strncmp(&line[b], "/*", 2) == 0 &&
tools/nxstyle.c: Correct indexing error noted by Xaio Xaing in commit comments.
2020-01-12 18:47:11 +01:00
strncmp(&line[e - 3], "***/", 4) == 0)
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
{
/* Return the the length of the line up to the final '*' */
return e;
}
/* Return zero if the line is not the first or last line of a block
* comment.
*/
return 0;
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: get_line_width
*
* Description:
* Get the maximum line width by examining the width of the block comments.
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
static int get_line_width(FILE *instream)
{
char line[LINE_SIZE]; /* The current line being examined */
Update nxstyle.c
2020-03-06 21:14:23 +01:00
int max = 0;
int min = INT_MAX;
int lineno = 0;
int lineno_max = 0;
int lineno_min = 0;
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
int len;
while (fgets(line, LINE_SIZE, instream))
{
nxstyle: Output line numbers when complaining on block comments length
2020-03-06 07:16:25 +01:00
lineno++;
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
len = block_comment_width(line);
if (len > 0)
{
if (len > max)
{
max = len;
nxstyle: Output line numbers when complaining on block comments length
2020-03-06 07:16:25 +01:00
lineno_max = lineno;
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
}
if (len < min)
{
min = len;
nxstyle fixes fixed coloumn number of error messages PR #487 fixed lineno_min = lineno_min
2020-03-08 13:55:46 +01:00
lineno_min = lineno;
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
}
}
}
if (max < min)
{
ERRORFL("No block comments found", g_file_name);
return DEFAULT_WIDTH;
}
else if (max != min)
{
nxstyle: Output line numbers when complaining on block comments length
2020-03-06 07:16:25 +01:00
ERROR("Block comments have different lengths", lineno_max, max);
ERROR("Block comments have different lengths", lineno_min, min);
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
return DEFAULT_WIDTH;
}
return min;
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
* Name: check_section_header
*
* Description:
* Check if the current line holds a section header
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
static bool check_section_header(const char *line, int lineno)
{
int i;
/* Search g_section_info[] to find a matching section header line */
for (i = FIRST_SECTION; i <= LAST_SECTION; i++)
{
if (strcmp(line, g_section_info[i].name) == 0)
{
g_section = (enum section_s)i;
/* Verify that this section is appropriate for this file type */
if ((g_file_type & g_section_info[i].ftype) == 0)
{
ERROR("Invalid section for this file type", lineno, 3);
}
return true;
}
}
return false;
}
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
/********************************************************************************
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
* Name: white_file_list
*
* Description:
* Return true if the filename string with a white-listed name
*
********************************************************************************/
static bool white_file_list(const char *filename)
{
const char **pptr;
const char *str;
for (pptr = g_white_files;
(str = *pptr) != NULL;
pptr++)
{
if (strstr(filename, str) != NULL)
{
return true;
}
}
return false;
}
/********************************************************************************
* Name: white_content_list
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
*
* Description:
* Return true if the identifier string begins with a white-listed prefix
*
********************************************************************************/
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
static bool white_content_list(const char *ident, int lineno)
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
{
const char **pptr;
const char *str;
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
size_t len2;
size_t len;
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
for (pptr = g_white_prefix;
(str = *pptr) != NULL;
pptr++)
{
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
len = strlen(str);
if (strncmp(ident, str, len) == 0)
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
{
return true;
}
}
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
for (pptr = g_white_headers;
(str = *pptr) != NULL;
pptr++)
{
if (strstr(ident, str) != NULL)
{
return true;
}
}
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
len2 = strlen(ident);
tools/nxstyle: Add kbps to the while suffix list and correct offset by 1 error Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 14:31:29 +02:00
while (!isalnum(ident[len2 - 1]))
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
{
len2--;
}
for (pptr = g_white_suffix;
tools/nxstyle: Support the white list and add _Exit to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-06-22 18:14:42 +02:00
(str = *pptr) != NULL;
pptr++)
{
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
len = strlen(str);
if (len2 >= len && strncmp(ident + len2 - len, str, len) == 0)
{
return true;
}
}
tools/nxstyle: Support the white list and add _Exit to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-06-22 18:14:42 +02:00
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
for (pptr = g_white_content_list;
tools/nxstyle: Add the suffix white list and initialize it to "kHz", "Mbps", and "us" Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2022-05-13 04:46:52 +02:00
(str = *pptr) != NULL;
pptr++)
{
len = strlen(str);
tools/nxstyle: Support the white list and add _Exit to the white list Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-06-22 18:14:42 +02:00
if (strncmp(ident, str, len) == 0 &&
isalnum(ident[len]) == 0)
{
return true;
}
}
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
return false;
}
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/********************************************************************************
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* Public Functions
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
********************************************************************************/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
int main(int argc, char **argv, char **envp)
{
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
FILE *instream; /* File input stream */
char line[LINE_SIZE]; /* The current line being examined */
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
char buffer[100]; /* Localy format error strings */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
char *lptr; /* Temporary pointer into line[] */
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
char *ext; /* Temporary file extension */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
bool btabs; /* True: TAB characters found on the line */
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
bool bcrs; /* True: Carriage return found on the line */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
bool bfunctions; /* True: In private or public functions */
bool bstatm; /* True: This line is beginning of a statement */
bool bfor; /* True: This line is beginning of a 'for' statement */
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
bool bif; /* True: This line is beginning of a 'if' statement */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
bool bswitch; /* True: Within a switch statement */
bool bstring; /* True: Within a string */
bool bquote; /* True: Backslash quoted character next */
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
bool bblank; /* Used to verify block comment terminator */
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
bool bexternc; /* True: Within 'extern "C"' */
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
enum pptype_e ppline; /* > 0: The next line the continuation of a
* pre-processor command */
int rhcomment; /* Indentation of Comment to the right of code
* (-1 -> don't check position) */
int prevrhcmt; /* Indentation of previous Comment to the right
* of code (-1 -> don't check position) */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
int lineno; /* Current line number */
int indent; /* Indentation level */
int ncomment; /* Comment nesting level on this line */
int prevncomment; /* Comment nesting level on the previous line */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
int bnest; /* Brace nesting level on this line */
int prevbnest; /* Brace nesting level on the previous line */
int dnest; /* Data declaration nesting level on this line */
int prevdnest; /* Data declaration nesting level on the previous line */
int pnest; /* Parenthesis nesting level on this line */
Added assembly header detection.
2020-03-14 14:36:47 +01:00
int ppifnest; /* #if nesting level on this line */
int inasm; /* > 0: Within #ifdef __ASSEMBLY__ */
tools/nxstyle.c: Correct detection of missing blank line following a block comment.
2019-11-09 15:15:12 +01:00
int comment_lineno; /* Line on which the last comment was closed */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
int blank_lineno; /* Line number of the last blank line */
int noblank_lineno; /* A blank line is not needed after this line */
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
int lbrace_lineno; /* Line number of last left brace */
tools/nxstyle.c: Add logic to detect if there is a blank line following the final right brace. sched/: Applied the modified nxstyle to all C file as a test.
2019-10-24 18:49:28 +02:00
int rbrace_lineno; /* Last line containing a right brace */
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
int externc_lineno; /* Last line where 'extern "C"' declared */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
int linelen; /* Length of the line */
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
int excess;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
int n;
int i;
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
int c;
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
excess = 0;
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
while ((c = getopt(argc, argv, ":hv:gm:r:")) != -1)
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
switch (c)
{
case 'm':
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
excess = atoi(optarg);
if (excess < 1)
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
{
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
show_usage(argv[0], 1, "Bad value for <excess>.");
excess = 0;
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
}
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
break;
case 'v':
g_verbose = atoi(optarg);
if (g_verbose < 0 || g_verbose > 2)
{
show_usage(argv[0], 1, "Bad value for <level>.");
}
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
break;
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Add -r option to check specified range lines Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file. Change-Id: I58ec56511fde14d6ec914400a7849e69960a3711 Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
2020-01-02 10:22:08 +01:00
case 'r':
g_rangestart[g_rangenumber] = atoi(strtok(optarg, ","));
g_rangecount[g_rangenumber++] = atoi(strtok(NULL, ","));
break;
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
case 'h':
show_usage(argv[0], 0, NULL);
break;
case ':':
show_usage(argv[0], 1, "Missing argument.");
break;
case '?':
show_usage(argv[0], 1, "Unrecognized option.");
break;
default:
show_usage(argv[0], 0, NULL);
break;
}
}
if (optind < argc - 1 || argv[optind] == NULL)
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
show_usage(argv[0], 1, "No file name given.");
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
}
tools/nxstyle: Verify relative path in the file header
2021-03-04 20:34:39 +01:00
/* Resolve the absolute path for the input file */
if (realpath(argv[optind], g_file_name) == NULL)
{
FATALFL("Failed to resolve absolute path.", g_file_name);
return 1;
}
tools/nxstyle.c: Add automatic detection of line width based on examining the width of all block comments. Includes a check to assure that all block comments use the same line width. Verified against all .c files under /sched. There were a few cosmetic changes to the coding style under /sched to account to new, correctly detected problems in the /sched files.
2020-01-12 17:07:54 +01:00
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
/* Are we parsing a header file? */
Nxstyle checkpatch support (#47) * tools/nxstyle.c: Donot check unknown file extension files nxstyle only support c soure file and header file check, donot check other unknown file extension files. * tools/checkpatch.sh: Add checkpatch.sh script based on nxstyle tool Usage: checkpatch.sh patch-list // default as patch list checkpatch.sh -p patch-list checkpatch.sh -c commit-list checkpatch.sh -f file-list checkpatch.sh - // read from stdin, which used by git pre-commit hook And git pre-commit hook could use checkpatch.sh as below: git diff --cached | ./tools/checkpatch.sh -
2020-01-07 15:12:18 +01:00
ext = strrchr(g_file_name, '.');
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
if (ext == 0)
{
}
else if (strcmp(ext, ".h") == 0)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
g_file_type = C_HEADER;
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
}
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
else if (strcmp(ext, ".c") == 0)
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
g_file_type = C_SOURCE;
tools/nxstyle.c: Fix logic from commit 005a077310f2f362a3f1147fdf38ae381d858d42 for the case of header files when contain no functions.
2019-06-30 02:38:56 +02:00
}
Nxstyle checkpatch support (#47) * tools/nxstyle.c: Donot check unknown file extension files nxstyle only support c soure file and header file check, donot check other unknown file extension files. * tools/checkpatch.sh: Add checkpatch.sh script based on nxstyle tool Usage: checkpatch.sh patch-list // default as patch list checkpatch.sh -p patch-list checkpatch.sh -c commit-list checkpatch.sh -f file-list checkpatch.sh - // read from stdin, which used by git pre-commit hook And git pre-commit hook could use checkpatch.sh as below: git diff --cached | ./tools/checkpatch.sh -
2020-01-07 15:12:18 +01:00
if (g_file_type == UNKNOWN)
{
return 0;
}
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
if (white_file_list(g_file_name))
{
return 0;
}
nxstyle: Don't parse a file if its type is unknown
2020-03-06 03:01:42 +01:00
instream = fopen(g_file_name, "r");
if (!instream)
{
FATALFL("Failed to open", g_file_name);
return 1;
}
/* Determine the line width */
g_maxline = get_line_width(instream) + excess;
rewind(instream);
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
btabs = false; /* True: TAB characters found on the line */
bcrs = false; /* True: Carriage return found on the line */
bfunctions = false; /* True: In private or public functions */
bswitch = false; /* True: Within a switch statement */
bstring = false; /* True: Within a string */
bexternc = false; /* True: Within 'extern "C"' */
tools/nxstyle: fix wrong error reports for if statements * Fix nxstyle check so it does not report error on comments on the same line as if statements * Rework if statement checks * Report warning instead of error for is statements check fail
2024-08-26 15:00:01 +02:00
bif = false; /* True: This line is beginning of a 'if' statement */
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
ppline = PPLINE_NONE; /* > 0: The next line the continuation of a
* pre-processor command */
rhcomment = 0; /* Indentation of Comment to the right of code
* (-1 -> don't check position) */
prevrhcmt = 0; /* Indentation of previous Comment to the right
* of code (-1 -> don't check position) */
lineno = 0; /* Current line number */
ncomment = 0; /* Comment nesting level on this line */
bnest = 0; /* Brace nesting level on this line */
dnest = 0; /* Data declaration nesting level on this line */
pnest = 0; /* Parenthesis nesting level on this line */
Added assembly header detection.
2020-03-14 14:36:47 +01:00
ppifnest = 0; /* #if nesting level on this line */
inasm = 0; /* > 0: Within #ifdef __ASSEMBLY__ */
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
comment_lineno = -1; /* Line on which the last comment was closed */
blank_lineno = -1; /* Line number of the last blank line */
noblank_lineno = -1; /* A blank line is not needed after this line */
lbrace_lineno = -1; /* Line number of last left brace */
rbrace_lineno = -1; /* Last line containing a right brace */
externc_lineno = -1; /* Last line where 'extern "C"' declared */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Add capability to detect CamelCase identifiers.
2019-03-05 20:08:57 +01:00
/* Process each line in the input stream */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
while (fgets(line, LINE_SIZE, instream))
{
lineno++;
indent = 0;
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
prevbnest = bnest; /* Brace nesting level on the previous line */
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
prevdnest = dnest; /* Data declaration nesting level on the
* previous line */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
prevncomment = ncomment; /* Comment nesting level on the previous line */
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
bstatm = false; /* True: This line is beginning of a
* statement */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
bfor = false; /* REVISIT: Implies for() is all on one line */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/* If we are not in a comment, then this certainly is not a right-hand
* comment.
*/
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
Formatting
2020-03-08 20:08:47 +01:00
prevrhcmt = rhcomment;
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
if (ncomment <= 0)
{
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
rhcomment = 0;
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
}
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
/* Check for a blank line */
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
for (n = 0; line[n] != '\n' && isspace((int)line[n]); n++)
{
}
if (line[n] == '\n')
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
{
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
if (n > 0)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Blank line contains whitespace", lineno, 1);
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
}
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
if (lineno == 1)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("File begins with a blank line", 1, 1);
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
}
else if (lineno == blank_lineno + 1)
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Too many blank lines", lineno, 1);
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
}
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
else if (lineno == lbrace_lineno + 1)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Blank line follows left brace", lineno, 1);
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
}
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
blank_lineno = lineno;
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
continue;
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
}
net/: Fixes for more coding standard issues detected by nxstyle.
2018-10-30 01:00:30 +01:00
else /* This line is non-blank */
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
{
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
/* Check for a missing blank line after a comment */
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (lineno == comment_lineno + 1)
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
{
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
/* No blank line should be present if the current line contains
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
* a right brace, a pre-processor line, the start of another
* comment.
net/: Fixes for more coding standard issues detected by nxstyle.
2018-10-30 01:00:30 +01:00
*
* REVISIT: Generates a false alarm if the current line is also
* a comment. Generally it is acceptable for one comment to
* follow another with no space separation.
tools/Directories.mk, Makefile.*: Extend the clean_context target so that it will remove the autogenerated files created during the context phase of the initial build.
2019-12-03 13:38:53 +01:00
*
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
* REVISIT: prevrhcmt is tested to case the preceding line
tools/Directories.mk, Makefile.*: Extend the clean_context target so that it will remove the autogenerated files created during the context phase of the initial build.
2019-12-03 13:38:53 +01:00
* contained comments to the right of the code. In such cases,
* the comments are normally aligned and do not follow normal
* indentation rules. However, this code will generate a false
* alarm if the comments are aligned to the right BUT the
* preceding line has no comment.
Update C Coding standard again. Correct some comments in tools/nxstyle.c
2018-08-21 21:32:05 +02:00
*/
Style
2020-03-08 20:12:06 +01:00
if (line[n] != '}' && line[n] != '#' && prevrhcmt == 0)
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing blank line after comment", comment_lineno,
1);
tools/nxstyle.c: Add logic to catch another formatting error and to eliminate some false alarms. Includes cosmetic changes to several files ... mostly as a result of testing nxstyle and finding issues.
2018-10-29 23:25:57 +01:00
}
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
}
tools/nxstyle.c: Make sure that all files begin with a comment on line 1 (which should be the file header).
2019-02-08 15:30:06 +01:00
Update README files.
2019-02-09 14:19:10 +01:00
/* Files must begin with a comment (the file header).
* REVISIT: Logically, this belongs in the STEP 2 operations
* below.
*/
tools/nxstyle.c: Make sure that all files begin with a comment on line 1 (which should be the file header).
2019-02-08 15:30:06 +01:00
if (lineno == 1 && (line[n] != '/' || line[n + 1] != '*'))
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing file header comment block", lineno, 1);
tools/nxstyle.c: Make sure that all files begin with a comment on line 1 (which should be the file header).
2019-02-08 15:30:06 +01:00
}
tools/nxstyle.c: Add logic to detect if there is a blank line following the final right brace. sched/: Applied the modified nxstyle to all C file as a test.
2019-10-24 18:49:28 +02:00
tools/nxstyle: Verify relative path in the file header
2021-03-04 20:34:39 +01:00
if (lineno == 2)
{
if (line[n] == '*' && line[n + 1] == '\n')
{
ERROR("Missing relative file path in file header", lineno,
n);
}
else if (isspace(line[n + 2]))
{
ERROR("Too many whitespaces before relative file path",
lineno, n);
}
else
{
const char *apps_dir = "apps/";
const size_t apps_len = strlen(apps_dir);
size_t offset;
#ifdef TOPDIR
/* TOPDIR macro contains the absolute path to the "nuttx"
* root directory. It should have been defined via Makefile
* and it is required to accurately evaluate the relative
* path contained in the file header. Otherwise, skip this
* verification.
*/
char *basedir = strstr(g_file_name, TOPDIR);
if (basedir != NULL)
{
/* Add 1 to the offset for the slash character */
offset = strlen(TOPDIR) + 1;
/* Duplicate the line from the beginning of the
* relative file path, removing the '\n' at the end of
* the string.
*/
char *line_dup = strndup(&line[n + 2],
strlen(&line[n + 2]) - 1);
if (strcmp(line_dup, basedir + offset) != 0)
{
ERROR("Relative file path does not match actual file",
lineno, n);
}
free(line_dup);
}
else if (strncmp(&line[n + 2], apps_dir, apps_len) != 0)
{
/* g_file_name neither belongs to "nuttx" repository
* nor begins with the root dir of the other
* repository (e.g. "apps/")
*/
ERROR("Path relative to repository other than \"nuttx\" "
"must begin with the root directory", lineno, n);
}
else
{
#endif
offset = 0;
if (strncmp(&line[n + 2], apps_dir, apps_len) == 0)
{
/* Input file belongs to the "apps" repository */
/* Calculate the offset to the first directory
* after the "apps/" folder.
*/
offset += apps_len;
}
/* Duplicate the line from the beginning of the
* relative file path, removing the '\n' at the end of
* the string.
*/
char *line_dup = strndup(&line[n + 2],
strlen(&line[n + 2]) - 1);
ssize_t base =
strlen(g_file_name) - strlen(&line_dup[offset]);
if (base < 0 ||
(base != 0 && g_file_name[base - 1] != '/') ||
strcmp(&g_file_name[base], &line_dup[offset]) != 0)
{
ERROR("Relative file path does not match actual file",
lineno, n);
}
free(line_dup);
#ifdef TOPDIR
}
#endif
}
}
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
/* Check for a blank line following a right brace */
tools/nxstyle.c: Add logic to detect if there is a blank line following the final right brace. sched/: Applied the modified nxstyle to all C file as a test.
2019-10-24 18:49:28 +02:00
if (bfunctions && lineno == rbrace_lineno + 1)
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
{
/* Check if this line contains a right brace. A right brace
* must be followed by 'else', 'while', 'break', a blank line,
* another right brace, or a pre-processor directive like #endif
*/
tools/nxstyle.c: Add logic to detect if there is a blank line following the final right brace. sched/: Applied the modified nxstyle to all C file as a test.
2019-10-24 18:49:28 +02:00
Handling of struct initializers changed. Break conditionals with || at the end.
2020-03-12 21:11:12 +01:00
if (dnest == 0 &&
strchr(line, '}') == NULL && line[n] != '#' &&
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
strncmp(&line[n], "else", 4) != 0 &&
strncmp(&line[n], "while", 5) != 0 &&
strncmp(&line[n], "break", 5) != 0)
{
ERROR("Right brace must be followed by a blank line",
rbrace_lineno, n + 1);
}
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
/* If the right brace is followed by a pre-processor command
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
* like #endif (but not #else or #elif), then set the right
* brace line number to the line number of the pre-processor
* command (it then must be followed by a blank line)
*/
if (line[n] == '#')
{
int ii;
for (ii = n + 1; line[ii] != '\0' && isspace(line[ii]); ii++)
{
}
if (strncmp(&line[ii], "else", 4) != 0 &&
strncmp(&line[ii], "elif", 4) != 0)
{
rbrace_lineno = lineno;
}
}
}
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
/* STEP 1: Find the indentation level and the start of real stuff on
* the line.
*/
for (n = 0; line[n] != '\n' && isspace((int)line[n]); n++)
{
switch (line[n])
{
case ' ':
{
indent++;
}
break;
case '\t':
{
if (!btabs)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("TABs found. First detected", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
btabs = true;
}
indent = (indent + 4) & ~3;
}
break;
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
case '\r':
{
if (!bcrs)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Carriage returns found. "
"First detected", lineno, n);
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
bcrs = true;
}
}
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
default:
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
snprintf(buffer, sizeof(buffer),
"Unexpected white space character %02x found",
line[n]);
ERROR(buffer, lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
break;
}
}
/* STEP 2: Detect some certain start of line conditions */
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
/* Skip over pre-processor lines (or continuations of pre-processor
* lines as indicated by ppline)
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (line[indent] == '#' || ppline != PPLINE_NONE)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
int len;
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
int ii;
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
/* Suppress error for comment following conditional compilation */
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
noblank_lineno = lineno;
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
/* Check pre-processor commands if this is not a continuation
* line.
*/
Added assembly header detection.
2020-03-14 14:36:47 +01:00
ii = indent + 1;
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (ppline == PPLINE_NONE)
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
{
/* Skip to the pre-processor command following the '#' */
Added assembly header detection.
2020-03-14 14:36:47 +01:00
while (line[ii] != '\0' && isspace(line[ii]))
{
ii++;
}
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (line[ii] != '\0')
{
/* Make sure that pre-processor definitions are all in
* the pre-processor definitions section.
*/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
ppline = PPLINE_OTHER;
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (strncmp(&line[ii], "define", 6) == 0)
{
ppline = PPLINE_DEFINE;
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (g_section != PRE_PROCESSOR_DEFINITIONS)
{
/* A complication is the header files always have
* the idempotence guard definitions before the
* "Pre-processor Definitions section".
*/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (g_section == NO_SECTION &&
g_file_type != C_HEADER)
{
/* Only a warning because there is some usage
* of define outside the Pre-processor
* Definitions section which is justifiable.
* Should be manually checked.
*/
WARN("#define outside of 'Pre-processor "
"Definitions' section",
lineno, ii);
}
}
}
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Make sure that files are included only in the Included
* Files section.
*/
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (strncmp(&line[ii], "include", 7) == 0)
{
if (g_section != INCLUDED_FILES)
{
/* Only a warning because there is some usage of
* include outside the Included Files section
* which may be is justifiable. Should be
* manually checked.
*/
WARN("#include outside of 'Included Files' "
"section",
lineno, ii);
}
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
else if (white_content_list(&line[ii], lineno))
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
{
g_skipmixedcase = true;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
}
else if (strncmp(&line[ii], "if", 2) == 0)
{
ppifnest++;
ppline = PPLINE_IF;
ii += 2;
}
else if (strncmp(&line[ii], "elif", 4) == 0)
{
if (ppifnest == inasm)
{
inasm = 0;
}
ppline = PPLINE_ELIF;
ii += 4;
}
else if (strncmp(&line[ii], "else", 4) == 0)
{
if (ppifnest == inasm)
{
inasm = 0;
}
ppline = PPLINE_ELSE;
}
else if (strncmp(&line[ii], "endif", 4) == 0)
{
if (ppifnest == inasm)
{
inasm = 0;
}
ppifnest--;
ppline = PPLINE_ENDIF;
}
}
}
if (ppline == PPLINE_IF || ppline == PPLINE_ELIF)
{
int bdef = 0;
if (strncmp(&line[ii], "def", 3) == 0)
{
bdef = 1;
ii += 3;
}
else
{
while (line[ii] != '\0' && isspace(line[ii]))
{
ii++;
}
if (strncmp(&line[ii], "defined", 7) == 0)
{
bdef = 1;
ii += 7;
}
}
if (bdef)
{
while (line[ii] != '\0' &&
(isspace(line[ii]) || line[ii] == '('))
{
ii++;
}
if (strncmp(&line[ii], "__ASSEMBLY__", 12) == 0)
{
inasm = ppifnest;
}
}
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
}
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
/* Check if the next line will be a continuation of the pre-
* processor command.
*/
len = strlen(&line[indent]) + indent - 1;
if (line[len] == '\n')
{
len--;
}
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
/* Propagate rhcomment over preprocessor lines Issue #120 */
Don't check position of comments right of code when separated by preprocessor line without comment.
2020-03-19 15:00:42 +01:00
if (prevrhcmt != 0)
{
/* Don't check position */
rhcomment = -1;
}
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
lptr = strstr(line, "/*");
if (lptr != NULL)
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
{
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
n = lptr - &line[0];
if (line[n + 2] == '\n')
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
{
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
ERROR("C comment opening on separate line", lineno, n);
}
else if (!isspace((int)line[n + 2]) && line[n + 2] != '*')
{
ERROR("Missing space after opening C comment", lineno, n);
}
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (strstr(lptr, "*/") == NULL)
{
/* Increment the count of nested comments */
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
ncomment++;
}
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (ppline == PPLINE_DEFINE)
{
Finetuning false positive
2020-03-08 22:37:39 +01:00
rhcomment = n;
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (prevrhcmt > 0 && n != prevrhcmt)
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
{
Finetuning false positive
2020-03-08 22:37:39 +01:00
rhcomment = prevrhcmt;
WARN("Wrong column position of comment right of code",
lineno, n);
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
}
}
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
else
{
/* Signal rhcomment, but ignore position */
rhcomment = -1;
Signal error for multiline comment right of #if
2020-03-09 16:16:06 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (ncomment > 0 &&
(ppline == PPLINE_IF ||
ppline == PPLINE_ELSE ||
ppline == PPLINE_ELIF))
Signal error for multiline comment right of #if
2020-03-09 16:16:06 +01:00
{
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* in #if... and #el... */
Checks for multiline comments right of #el..., changes message for a certain case of a comment following a right of code comment
2020-03-10 12:47:06 +01:00
Signal error for multiline comment right of #if
2020-03-09 16:16:06 +01:00
ERROR("No multiline comment right of code allowed here",
lineno, n);
}
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
}
}
if (line[len] != '\\' || ncomment > 0)
{
ppline = PPLINE_NONE;
Implemented comment processing for preprocessor lines
2020-03-08 13:29:47 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
continue;
}
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
/* Check for a single line comment */
linelen = strlen(line);
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
/* Minimum is slash, star, star, slash, newline */
if (linelen >= 5)
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
{
lptr = strstr(line, "*/");
tools/nxstyle.c: Eliminate false alarm errors on comments that are to the right of code when the comment terminator is on the same line as the last of the comment.
2019-10-25 20:34:42 +02:00
if (line[indent] == '/' && line[indent + 1] == '*' &&
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
lptr - line == linelen - 3)
{
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* If preceding comments were to the right of code, then we can
* assume that there is a columnar alignment of columns that do
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
* no follow the usual alignment. So the rhcomment flag
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
* should propagate.
*/
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
rhcomment = prevrhcmt;
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
/* Check if there should be a blank line before the comment */
if (lineno > 1 &&
comment_lineno != lineno - 1 &&
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
blank_lineno != lineno - 1 &&
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
noblank_lineno != lineno - 1 &&
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
rhcomment == 0)
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
{
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
/* TODO: This generates a false alarm if preceded
* by a label.
*/
Update C Coding standard again. Correct some comments in tools/nxstyle.c
2018-08-21 21:32:05 +02:00
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing blank line before comment found", lineno, 1);
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
}
drivers/power/pm: Historically, the NuttX PM subsystem has consisted of two functional components: (1) an "Upper" part that detects state changes based on a random walk driven by activity levels, and (2) and "lower" part that implementst the state changes. This change decouples that upper activity-based logic from the lower random walk logic and allows use of other upper state detection logic (such as a custom, application-specific state machine).
2019-11-09 16:09:33 +01:00
/* 'comment_lineno 'holds the line number of the last closing
* comment. It is used only to verify that the comment is
* followed by a blank line.
*/
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
comment_lineno = lineno;
tools/nxstyle.c;: Add check for blank lines before and after single line comments.
2018-04-11 23:45:39 +02:00
}
}
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
/* Check for the comment block indicating the beginning of a new file
* section.
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
if (check_section_header(line, lineno))
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle: Added logic to parse section headers (#90) * tools/nxstyle: Added logic to parse section headers (like Included files, Pre-processor Definitions, etc.) and to assure that the section headers are correct for the file type. Also (1) verify that #include appears only in the 'Included Files' section and that (2) #define only occurs in the Pre-processor definition section. Right now, there are several places where that rule is not followed. I think most of these are acceptable so these failures only generate warnings, not errors. The warning means that we need to go look at the offending #define or #include and decide if it is a acceptable usage or not.
2020-01-13 19:08:45 +01:00
if (g_section == PRIVATE_FUNCTIONS || g_section == PUBLIC_FUNCTIONS)
{
bfunctions = true; /* Latched */
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
/* Check for some kind of declaration.
* REVISIT: The following logic fails for any non-standard types.
* REVISIT: Terminator after keyword might not be a space. Might be
* a newline, for example. struct and unions are often unnamed, for
* example.
*/
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (inasm == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (strncmp(&line[indent], "auto ", 5) == 0 ||
strncmp(&line[indent], "bool ", 5) == 0 ||
strncmp(&line[indent], "char ", 5) == 0 ||
strncmp(&line[indent], "CODE ", 5) == 0 ||
strncmp(&line[indent], "const ", 6) == 0 ||
strncmp(&line[indent], "double ", 7) == 0 ||
strncmp(&line[indent], "struct ", 7) == 0 ||
strncmp(&line[indent], "struct\n", 7) == 0 || /* May be unnamed */
strncmp(&line[indent], "enum ", 5) == 0 ||
strncmp(&line[indent], "extern ", 7) == 0 ||
strncmp(&line[indent], "EXTERN ", 7) == 0 ||
strncmp(&line[indent], "FAR ", 4) == 0 ||
strncmp(&line[indent], "float ", 6) == 0 ||
strncmp(&line[indent], "int ", 4) == 0 ||
strncmp(&line[indent], "int16_t ", 8) == 0 ||
strncmp(&line[indent], "int32_t ", 8) == 0 ||
strncmp(&line[indent], "long ", 5) == 0 ||
strncmp(&line[indent], "off_t ", 6) == 0 ||
strncmp(&line[indent], "register ", 9) == 0 ||
strncmp(&line[indent], "short ", 6) == 0 ||
strncmp(&line[indent], "signed ", 7) == 0 ||
strncmp(&line[indent], "size_t ", 7) == 0 ||
strncmp(&line[indent], "ssize_t ", 8) == 0 ||
strncmp(&line[indent], "static ", 7) == 0 ||
strncmp(&line[indent], "time_t ", 7) == 0 ||
strncmp(&line[indent], "typedef ", 8) == 0 ||
strncmp(&line[indent], "uint8_t ", 8) == 0 ||
strncmp(&line[indent], "uint16_t ", 9) == 0 ||
strncmp(&line[indent], "uint32_t ", 9) == 0 ||
strncmp(&line[indent], "union ", 6) == 0 ||
strncmp(&line[indent], "union\n", 6) == 0 || /* May be unnamed */
strncmp(&line[indent], "unsigned ", 9) == 0 ||
strncmp(&line[indent], "void ", 5) == 0 ||
strncmp(&line[indent], "volatile ", 9) == 0)
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
{
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Check if this is extern "C"; We don't typically indent
* following this.
*/
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (strncmp(&line[indent], "extern \"C\"", 10) == 0)
{
externc_lineno = lineno;
}
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* bfunctions: True: Processing private or public functions.
* bnest: Brace nesting level on this line
* dnest: Data declaration nesting level on this line
*/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* REVISIT: Also picks up function return types */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* REVISIT: Logic problem for nested data/function declarations */
tools/nxstyle.c: Add check for multiple definitions of local variables on a line.
2019-02-15 01:33:23 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if ((!bfunctions || bnest > 0) && dnest == 0)
{
dnest = 1;
}
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Check for multiple definitions of variables on the line.
* Ignores declarations within parentheses which are probably
* formal parameters.
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
*/
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (pnest == 0)
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
{
Added assembly header detection.
2020-03-14 14:36:47 +01:00
int tmppnest;
tools/nxstyle: can use ',' in the string when declaring it Signed-off-by: yangjian11 <yangjian11@xiaomi.com>
2024-01-26 08:06:23 +01:00
bool tmpbstring;
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Note, we have not yet parsed each character on the line so
* a comma have have been be preceded by '(' on the same line.
* We will have parse up to any comma to see if that is the
* case.
*/
tools/nxstyle: can use ',' in the string when declaring it Signed-off-by: yangjian11 <yangjian11@xiaomi.com>
2024-01-26 08:06:23 +01:00
for (i = indent, tmppnest = 0, tmpbstring = false;
Added assembly header detection.
2020-03-14 14:36:47 +01:00
line[i] != '\n' && line[i] != '\0';
i++)
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
{
tools/nxstyle: can use ',' in the string when declaring it Signed-off-by: yangjian11 <yangjian11@xiaomi.com>
2024-01-26 08:06:23 +01:00
if (tmppnest == 0 && !tmpbstring && line[i] == ',')
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
{
Added assembly header detection.
2020-03-14 14:36:47 +01:00
ERROR("Multiple data definitions", lineno, i + 1);
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
break;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (line[i] == '(')
{
tmppnest++;
}
else if (line[i] == ')')
{
if (tmppnest < 1)
{
/* We should catch this later */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
break;
}
tmppnest--;
}
tools/nxstyle: can use ',' in the string when declaring it Signed-off-by: yangjian11 <yangjian11@xiaomi.com>
2024-01-26 08:06:23 +01:00
else if (line[i] == '"')
{
tmpbstring = !tmpbstring;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (line[i] == ';')
{
/* Break out if the semicolon terminates the
* declaration is found. Avoids processing any
* righthand comments in most cases.
*/
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
break;
}
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
}
}
tools/nxstyle.c: Add check for multiple definitions of local variables on a line.
2019-02-15 01:33:23 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Check for a keyword indicating the beginning of a statement.
* REVISIT: This, obviously, will not detect statements that do not
* begin with a C keyword (such as assignment statements).
*/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (strncmp(&line[indent], "break ", 6) == 0 ||
strncmp(&line[indent], "case ", 5) == 0 ||
#if 0 /* Part of switch */
strncmp(&line[indent], "case ", 5) == 0 ||
#endif
strncmp(&line[indent], "continue ", 9) == 0 ||
#if 0 /* Part of switch */
strncmp(&line[indent], "default ", 8) == 0 ||
#endif
strncmp(&line[indent], "do ", 3) == 0 ||
strncmp(&line[indent], "else ", 5) == 0 ||
strncmp(&line[indent], "goto ", 5) == 0 ||
strncmp(&line[indent], "return ", 7) == 0 ||
Update kconfig2html.c Fix nuttx coding style
2023-12-14 15:22:07 +01:00
#if 0 /* Doesn't follow pattern */
Added assembly header detection.
2020-03-14 14:36:47 +01:00
strncmp(&line[indent], "switch ", 7) == 0 ||
#endif
strncmp(&line[indent], "while ", 6) == 0)
{
bstatm = true;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
else if(strncmp(&line[indent], "if ", 3) == 0)
{
bif = true;
bstatm = true;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Spacing works a little differently for and switch statements */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (strncmp(&line[indent], "for ", 4) == 0)
{
bfor = true;
bstatm = true;
}
else if (strncmp(&line[indent], "switch ", 7) == 0)
{
bswitch = true;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* Also check for C keywords with missing white space */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (strncmp(&line[indent], "do(", 3) == 0 ||
strncmp(&line[indent], "while(", 6) == 0)
{
ERROR("Missing whitespace after keyword", lineno, n);
bstatm = true;
}
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
else if (strncmp(&line[indent], "if(", 3) == 0)
{
ERROR("Missing whitespace after keyword", lineno, n);
bif = true;
bstatm = true;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
else if (strncmp(&line[indent], "for(", 4) == 0)
{
ERROR("Missing whitespace after keyword", lineno, n);
bfor = true;
bstatm = true;
}
else if (strncmp(&line[indent], "switch(", 7) == 0)
{
ERROR("Missing whitespace after keyword", lineno, n);
bswitch = true;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
/* STEP 3: Parse each character on the line */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
bquote = false; /* True: Backslash quoted character next */
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
bblank = true; /* Used to verify block comment terminator */
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
for (; line[n] != '\n' && line[n] != '\0'; n++)
{
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
/* Report any use of non-standard white space characters */
if (isspace(line[n]))
{
if (line[n] == '\t')
{
if (!btabs)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("TABs found. First detected", lineno, n);
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
btabs = true;
}
}
else if (line[n] == '\r')
{
if (!bcrs)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Carriage returns found. "
"First detected", lineno, n);
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
bcrs = true;
}
}
else if (line[n] != ' ')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
snprintf(buffer, sizeof(buffer),
"Unexpected white space character %02x found",
line[n]);
ERROR(buffer, lineno, n);
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
}
}
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
/* Skip over identifiers */
tools/nxstyle.c: Add capability to detect CamelCase identifiers.
2019-03-05 20:08:57 +01:00
if (ncomment == 0 && !bstring && (line[n] == '_' || isalpha(line[n])))
{
bool have_upper = false;
bool have_lower = false;
int ident_index = n;
/* Parse over the identifier. Check if it contains mixed upper-
* and lower-case characters.
*/
do
{
have_upper |= isupper(line[n]);
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
/* The coding standard provides for some exceptions of lower
* case characters in pre-processor strings:
*
* IPv[4|6] as an IP version number
* ICMPv6 as an ICMP version number
* IGMPv2 as an IGMP version number
* [0-9]p[0-9] as a decimal point
* d[0-9] as a divisor
nxstyle: Allow Hz, KHz, GHz in identifiers Per the coding standard, we allow MHz as one of the few allowed exceptions to the identifier case rules. However, because this exception specifically looked for "MHz" we would generate undeserved nxstyle errors for Hz, KHz, GHz. This change adds recognition of any Hz value by eliminating the requirement for Hz to be preceded by M. tools/nxstyle.c: * main(): Eliminate requirement for Hz to be preceded by M to match the rule for allowed mixed case identifier. Update relevant comments. See: https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#macros Mailing list discussion archived at: https://lists.apache.org/thread.html/r481b9d145f439c24c8d70992081bf670bc0e893167149e0017519439%40%3Cdev.nuttx.apache.org%3E
2020-05-19 01:28:40 +02:00
* Hz for frequencies (including KHz, MHz, etc.)
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
*/
if (!have_lower && islower(line[n]))
{
switch (line[n])
{
tools/nxstyle.c: Costmetic alignment and corrections to comments.
2019-03-13 14:05:31 +01:00
/* A sequence containing 'v' may occur at the
tools/nxstyle.c: Fix a bacward test in the previous commit.
2019-03-12 21:48:43 +01:00
* beginning of the identifier.
*/
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
case 'v':
if (n > 1 &&
line[n - 2] == 'I' &&
line[n - 1] == 'P' &&
(line[n + 1] == '4' ||
line[n + 1] == '6'))
{
}
else if (n > 3 &&
line[n - 4] == 'I' &&
line[n - 3] == 'C' &&
line[n - 2] == 'M' &&
line[n - 1] == 'P' &&
line[n + 1] == '6')
{
}
else if (n > 3 &&
line[n - 4] == 'I' &&
line[n - 3] == 'G' &&
line[n - 2] == 'M' &&
line[n - 1] == 'P' &&
line[n + 1] == '2')
{
}
else
{
have_lower = true;
}
break;
tools/nxstyle.c: Alloc MHz in pre-processor variable names. The sub-string MHz is used frequently is pre-processor variable definitions. The section "Lowercase Exceptions" permits reasonable use of lowercase characters in pre-processor variable names and, given the frequency of the use of MHz (no pun intended), it certainly should qualify.
2020-04-02 20:57:08 +02:00
/* Sequences containing 'p', 'd', or 'z' must have
* been preceded by upper case characters.
tools/nxstyle.c: Fix a bacward test in the previous commit.
2019-03-12 21:48:43 +01:00
*/
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
case 'p':
tools/nxstyle.c: Fix a bacward test in the previous commit.
2019-03-12 21:48:43 +01:00
if (!have_upper || n < 1 ||
tools/nxstyle.c: Costmetic alignment and corrections to comments.
2019-03-13 14:05:31 +01:00
!isdigit(line[n - 1]) ||
!isdigit(line[n + 1]))
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
{
have_lower = true;
}
break;
case 'd':
tools/nxstyle.c: Fix a bacward test in the previous commit.
2019-03-12 21:48:43 +01:00
if (!have_upper || !isdigit(line[n + 1]))
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
{
have_lower = true;
}
break;
tools/nxstyle.c: Alloc MHz in pre-processor variable names. The sub-string MHz is used frequently is pre-processor variable definitions. The section "Lowercase Exceptions" permits reasonable use of lowercase characters in pre-processor variable names and, given the frequency of the use of MHz (no pun intended), it certainly should qualify.
2020-04-02 20:57:08 +02:00
case 'z':
nxstyle: Allow Hz, KHz, GHz in identifiers Per the coding standard, we allow MHz as one of the few allowed exceptions to the identifier case rules. However, because this exception specifically looked for "MHz" we would generate undeserved nxstyle errors for Hz, KHz, GHz. This change adds recognition of any Hz value by eliminating the requirement for Hz to be preceded by M. tools/nxstyle.c: * main(): Eliminate requirement for Hz to be preceded by M to match the rule for allowed mixed case identifier. Update relevant comments. See: https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#macros Mailing list discussion archived at: https://lists.apache.org/thread.html/r481b9d145f439c24c8d70992081bf670bc0e893167149e0017519439%40%3Cdev.nuttx.apache.org%3E
2020-05-19 01:28:40 +02:00
if (!have_upper || n < 1 ||
line[n - 1] != 'H')
tools/nxstyle.c: Alloc MHz in pre-processor variable names. The sub-string MHz is used frequently is pre-processor variable definitions. The section "Lowercase Exceptions" permits reasonable use of lowercase characters in pre-processor variable names and, given the frequency of the use of MHz (no pun intended), it certainly should qualify.
2020-04-02 20:57:08 +02:00
{
have_lower = true;
}
break;
break;
tools/nxstyle.c: Don't complain about certain lowercase characters in otherwise uppercase pre-processor identifers: IPv6, IPv4, ICMPv6, IGMPv2, p as a decimal point, d signifying a divisor. It was a bad idea to let the door open a crack for there. While they improve readability, the inconsistently also causes other problems.
2019-03-12 21:22:52 +01:00
default:
have_lower = true;
break;
}
}
tools/nxstyle.c: Add capability to detect CamelCase identifiers.
2019-03-05 20:08:57 +01:00
n++;
}
while (line[n] == '_' || isalnum(line[n]));
tools/nxstyle.c: Was confusing hex constants with strings staring with 'x'. Added logic to complain about hex constants containing upper case characters.
2019-03-09 16:21:12 +01:00
/* Check for mixed upper and lower case */
tools/nxstyle.c: Add capability to detect CamelCase identifiers.
2019-03-05 20:08:57 +01:00
if (have_upper && have_lower)
{
tools/nxstyle.c: Add fixedmath.h defines to white-listed prefixes Checking for white-listed prefixes is also simpler now because the check is table driver. New data structure: g_white_prefix[] and new function white_prefix().
2020-03-31 19:43:28 +02:00
/* Ignore symbols that begin with white-listed prefixes */
nxstyle: Don't complain on ELF things like Elf32_Hdr
2020-03-06 03:15:04 +01:00
tools/nxstyle: skip mixed case check for particular headers Add header keywords into whitelist, skip the warning if the particular headers will contain the functions with mixed case Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-11 07:27:14 +02:00
if (g_skipmixedcase ||
tools/nxstyle: add white files list to allow assembly headers to pass ci checks Signed-off-by: chao an <anchao@xiaomi.com>
2023-04-26 11:27:43 +02:00
white_content_list(&line[ident_index], lineno))
nxstyle: Don't complain on ELF things like Elf32_Hdr
2020-03-06 03:15:04 +01:00
{
/* No error */
}
tools/nxstyle.c: Was confusing hex constants with strings staring with 'x'. Added logic to complain about hex constants containing upper case characters.
2019-03-09 16:21:12 +01:00
/* Special case hex constants. These will look like
* identifiers starting with 'x' or 'X' but preceded
* with '0'
*/
tools/nxstyle.c: Ignore inttypes.h constants. Eliminate warnings. Ignore mixed case identifies beginning with PRIx. These most likely come from inttypes.h and we nxstyle must tolerate those definitions even though they do not follow the coding style.
2020-02-03 17:13:18 +01:00
else if (ident_index < 1 ||
(line[ident_index] != 'x' &&
line[ident_index] != 'X') ||
line[ident_index - 1] != '0')
tools/nxstyle.c: Was confusing hex constants with strings staring with 'x'. Added logic to complain about hex constants containing upper case characters.
2019-03-09 16:21:12 +01:00
{
tools/nxstyle.c: Ignore inttypes.h constants. Eliminate warnings. Ignore mixed case identifies beginning with PRIx. These most likely come from inttypes.h and we nxstyle must tolerate those definitions even though they do not follow the coding style.
2020-02-03 17:13:18 +01:00
ERROR("Mixed case identifier found",
lineno, ident_index);
tools/nxstyle.c: Was confusing hex constants with strings staring with 'x'. Added logic to complain about hex constants containing upper case characters.
2019-03-09 16:21:12 +01:00
}
else if (have_upper)
{
tools/nxstyle.c: Ignore inttypes.h constants. Eliminate warnings. Ignore mixed case identifies beginning with PRIx. These most likely come from inttypes.h and we nxstyle must tolerate those definitions even though they do not follow the coding style.
2020-02-03 17:13:18 +01:00
ERROR("Upper case hex constant found",
lineno, ident_index);
tools/nxstyle.c: Was confusing hex constants with strings staring with 'x'. Added logic to complain about hex constants containing upper case characters.
2019-03-09 16:21:12 +01:00
}
tools/nxstyle.c: Add capability to detect CamelCase identifiers.
2019-03-05 20:08:57 +01:00
}
/* Check if the identifier is the last thing on the line */
if (line[n] == '\n' || line[n] == '\0')
{
break;
}
}
/* Handle comments */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (line[n] == '/' && !bstring)
{
/* Check for start of a C comment */
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 1] == '*')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 2] == '\n')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("C comment opening on separate line", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
else if (!isspace((int)line[n + 2]) && line[n + 2] != '*')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing space after opening C comment", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* Increment the count of nested comments */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
ncomment++;
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* If there is anything to the left of the left brace, then
* this must be a comment to the right of code.
* Also if preceding comments were to the right of code, then
* we can assume that there is a columnar alignment of columns
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
* that do no follow the usual alignment. So the rhcomment
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
* flag should propagate.
*/
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
if (prevrhcmt == 0)
{
if (n != indent)
{
rhcomment = n;
}
}
else
{
rhcomment = n;
Some more fine tuning Handle #define different than other preprocessor lines Ignore backslash at the end of a comment right of a preprocessor line
2020-03-09 12:53:21 +01:00
if (prevrhcmt > 0 && n != prevrhcmt)
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
{
rhcomment = prevrhcmt;
Checks for multiline comments right of #el..., changes message for a certain case of a comment following a right of code comment
2020-03-10 12:47:06 +01:00
if (n != indent)
{
WARN("Wrong column position of "
"comment right of code", lineno, n);
}
else
{
ERROR("Wrong column position or missing "
"blank line before comment", lineno, n);
}
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
}
}
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
tools/nxstyle: fix wrong error reports for if statements * Fix nxstyle check so it does not report error on comments on the same line as if statements * Rework if statement checks * Report warning instead of error for is statements check fail
2024-08-26 15:00:01 +02:00
/* Allow comments on the same line as the if statement */
if (bif == true)
{
bif = false;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
n++;
continue;
}
/* Check for end of a C comment */
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
else if (n > 0 && line[n - 1] == '*')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
if (n < 2)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Closing C comment not indented", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Check for missing space before closing comment faulty (#543) *Addresses Issue #540, check for missing space before closing comment was faulty
2020-03-11 18:08:01 +01:00
else if (!isspace((int)line[n - 2]) && line[n - 2] != '*')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing space before closing C comment", lineno,
n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
/* Check for block comments that are not on a separate line.
* This would be the case if we are we are within a comment
* that did not start on this line and the current line is
* not blank up to the point where the comment was closed.
*/
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
if (prevncomment > 0 && !bblank && rhcomment == 0)
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Block comment terminator must be on a "
"separate line", lineno, n);
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
#if 0
/* REVISIT: Generates false alarms when portions of an
* expression are commented out within the expression.
*/
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 1] != '\n')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Garbage on line after C comment", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
#endif
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
/* Handle nested comments */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (ncomment > 0)
{
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
/* Remember the line number of the line containing the
* closing of the outermost comment.
*/
if (--ncomment == 0)
{
tools/nxstyle.c: Correct detection of missing blank line following a block comment.
2019-11-09 15:15:12 +01:00
/* 'comment_lineno 'holds the line number of the
* last closing comment. It is used only to
* verify that the comment is followed by a blank
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
* line.
tools/nxstyle.c: Remove some logic added in previous change. Causes too many false alarms.
2018-10-31 19:42:18 +01:00
*/
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
comment_lineno = lineno;
tools/nxstyle.c: Correct detection of missing blank line following a block comment.
2019-11-09 15:15:12 +01:00
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
/* Note that rhcomment must persist to support a
tools/nxstyle.c: Correct detection of missing blank line following a block comment.
2019-11-09 15:15:12 +01:00
* later test for comment alignment. We will fix
* that at the top of the loop when ncomment == 0.
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
*/
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else
{
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
/* Note that rhcomment must persist to support a later
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
* test for comment alignment. We will will fix that
* at the top of the loop when ncomment == 0.
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
ncomment = 0;
nuttx: remove space befone newline in logs Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2021-12-26 23:18:22 +01:00
ERROR("Closing without opening comment", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
n++;
continue;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
/* Check for C++ style comments */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
else if (line[n + 1] == '/')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle: Extend check to any URI scheme
2021-05-07 19:10:28 +02:00
/* Check for URI schemes, e.g. "http://" or "https://" */
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
nuttx: remove space befone newline in logs Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2021-12-26 23:18:22 +01:00
if ((ncomment == 0) &&
(n == 0 || strncmp(&line[n - 1], "://", 3) != 0))
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("C++ style comment", lineno, n);
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
n++;
continue;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
tools/nxstyle.c: Can not detect if the C comment closing is not on a separate line.
2019-02-08 14:49:19 +01:00
/* Check if the line is blank so far. This is only used to
* to verify the the closing of a block comment is on a separate
* line. So we also need to treat '*' as a 'blank'.
*/
if (!isblank(line[n]) && line[n] != '*')
{
bblank = false;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
/* Check for a string... ignore if we are in the middle of a
* comment.
*/
if (ncomment == 0)
{
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
/* Backslash quoted character */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (line[n] == '\\')
{
bquote = true;
n++;
}
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
/* Check for quoted characters: \" in string */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (line[n] == '"' && !bquote)
{
bstring = !bstring;
}
bquote = false;
}
Added assembly header detection.
2020-03-14 14:36:47 +01:00
/* The rest of the line is only examined of we are not in a comment,
* in a string or in assembly.
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*
* REVISIT: Should still check for whitespace at the end of the
* line.
*/
Added assembly header detection.
2020-03-14 14:36:47 +01:00
if (ncomment == 0 && !bstring && inasm == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
switch (line[n])
{
/* Handle logic nested with curly braces */
case '{':
{
if (n > indent)
{
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
/* REVISIT: dnest is always > 0 here if bfunctions ==
* false.
*/
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
Handling of struct initializers changed. Break conditionals with || at the end.
2020-03-12 21:11:12 +01:00
if (dnest == 0 || !bfunctions || lineno == rbrace_lineno)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Left bracket not on separate line", lineno,
n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
else if (line[n + 1] != '\n')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (dnest == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Garbage follows left bracket", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
bnest++;
if (dnest > 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
dnest++;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
/* Check if we are within 'extern "C"', we don't
* normally indent in that case because the 'extern "C"'
* is conditioned on __cplusplus.
*/
if (lineno == externc_lineno ||
lineno - 1 == externc_lineno)
{
bexternc = true;
}
Reverts cc31f22213991251c6262a912f5ffb48891f7134: That commit throughs the baby out with the bathwater. True, it did cause too many false alarms. But a better solution is to keep the logic but add some additional logic to reduce the number of false alarms.
2018-08-21 21:07:29 +02:00
/* Suppress error for comment following a left brace */
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
noblank_lineno = lineno;
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
lbrace_lineno = lineno;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
break;
case '}':
{
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
/* Decrement the brace nesting level */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (bnest < 1)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Unmatched right brace", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
bnest--;
if (bnest < 1)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
bnest = 0;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
bswitch = false;
}
}
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
/* Decrement the declaration nesting level */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (dnest < 3)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
dnest = 0;
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
bexternc = false;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
dnest--;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
/* The right brace should be on a separate line */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (n > indent)
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (dnest == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Right bracket not on separate line",
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
lineno, n);
}
}
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
/* Check for garbage following the left brace */
if (line[n + 1] != '\n' &&
line[n + 1] != ',' &&
line[n + 1] != ';')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
int sndx = n + 1;
tools/nxstyle.c: Trivial improvement to preceding change to allow white space separation.
2019-11-19 18:43:20 +01:00
bool whitespace = false;
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
/* Skip over spaces */
while (line[sndx] == ' ')
{
sndx++;
}
/* One possibility is that the right bracket is
* followed by an identifier then a semi-colon.
* Comma is possible to but would be a case of
* multiple declaration of multiple instances.
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*/
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
if (line[sndx] == '_' || isalpha(line[sndx]))
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
int endx = sndx;
/* Skip to the end of the identifier. Checking
* for mixed case identifiers will be done
* elsewhere.
net/: Fixes for more coding standard issues detected by nxstyle.
2018-10-30 01:00:30 +01:00
*/
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
while (line[endx] == '_' ||
isalnum(line[endx]))
{
endx++;
}
tools/nxstyle.c: Trivial improvement to preceding change to allow white space separation.
2019-11-19 18:43:20 +01:00
/* Skip over spaces */
while (line[endx] == ' ')
{
whitespace = true;
endx++;
}
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
/* Handle according to what comes after the
* identifier.
*/
if (strncmp(&line[sndx], "while", 5) == 0)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("'while' must be on a separate line",
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
lineno, sndx);
}
else if (line[endx] == ',')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Multiple data definitions on line",
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
lineno, endx);
}
tools/nxstyle.c: Trivial improvement to preceding change to allow white space separation.
2019-11-19 18:43:20 +01:00
else if (line[endx] == ';')
{
if (whitespace)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Space precedes semi-colon",
lineno, endx);
tools/nxstyle.c: Trivial improvement to preceding change to allow white space separation.
2019-11-19 18:43:20 +01:00
}
}
Handling of struct initializers changed. Break conditionals with || at the end.
2020-03-12 21:11:12 +01:00
else if (line[endx] == '=')
{
/* There's a struct initialization following */
check_spaces_leftright(line, lineno, endx, endx);
dnest = 1;
}
tools/nxstyle.c: Trivial improvement to preceding change to allow white space separation.
2019-11-19 18:43:20 +01:00
else
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Garbage follows right bracket",
lineno, n);
tools/nxstyle: Fix false alarm 'Garbage follows right bracket' on named structures that are fields of other structures or unions.
2019-11-19 18:32:57 +01:00
}
}
else
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Garbage follows right bracket", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
/* The right brace should not be preceded with a a blank
* line.
*/
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
if (lineno == blank_lineno + 1)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Blank line precedes right brace at line",
lineno, 1);
tools/nxstyle.c: Add logic to detect a blank line following a left brace or a blank line preceding a right brace.
2019-03-10 16:53:33 +01:00
}
tools/nxstyle.c: Add logic to detect if there is a blank line following the final right brace. sched/: Applied the modified nxstyle to all C file as a test.
2019-10-24 18:49:28 +02:00
rbrace_lineno = lineno;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
break;
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
/* Handle logic with parentheses */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
case '(':
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
/* Increase the parenthetical nesting level */
pnest++;
/* Check for inappropriate space around parentheses */
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
if (line[n + 1] == ' ')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Space follows left parenthesis", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
case ')':
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
/* Decrease the parenthetical nesting level */
if (pnest < 1)
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
{
ERROR("Unmatched right parentheses", lineno, n);
pnest = 0;
}
else
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
{
pnest--;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
/* Allow ')' as first thing on the line (n == indent)
* Allow "for (xx; xx; )" (bfor == true)
*/
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (n > 0 && n != indent && line[n - 1] == ' ' && !bfor)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
ERROR("Space precedes right parenthesis", lineno, n);
}
tools/nxstyle: fix wrong error reports for if statements * Fix nxstyle check so it does not report error on comments on the same line as if statements * Rework if statement checks * Report warning instead of error for is statements check fail
2024-08-26 15:00:01 +02:00
/* Unset bif if last parenthesis is closed */
if (bif == true && pnest == 0)
tools: nxstyle if statement check nxstyle will print an error on a single line if statement
2024-07-29 19:59:32 +02:00
{
tools/nxstyle: fix wrong error reports for if statements * Fix nxstyle check so it does not report error on comments on the same line as if statements * Rework if statement checks * Report warning instead of error for is statements check fail
2024-08-26 15:00:01 +02:00
bif = false;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
/* Check for inappropriate space around square brackets */
case '[':
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 1] == ' ')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Space follows left bracket", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
case ']':
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (n > 0 && line[n - 1] == ' ')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Space precedes right bracket", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
/* Semi-colon may terminate a declaration */
case ';':
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (!isspace((int)line[n + 1]))
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing whitespace after semicolon", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
/* Semicolon terminates a declaration/definition if there
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
* was no left curly brace (i.e., dnest is only 1).
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*/
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (dnest == 1)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
dnest = 0;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
/* Semi-colon may terminate a declaration */
case ',':
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (!isspace((int)line[n + 1]))
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing whitespace after comma", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
/* Skip over character constants */
case '\'':
{
int endndx = n + 2;
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 1] != '\n' && line[n + 1] != '\0')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Add capability to detect multiple blank lines. Single spacing required by the coding standard. Also coding standard fixes to server .c files for problems found during testing nxstyle.
2018-08-24 13:51:44 +02:00
if (line[n + 1] == '\\')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
for (;
line[endndx] != '\n' &&
line[endndx] != '\0' &&
line[endndx] != '\'';
endndx++);
}
fix: nxstyle: fix a bug after "'\'" When nxstyle.c detects a "\'", it seeks the other "\'", records the index as "endndx", then skip the "'x'". But it makes the index "n" as "endndx+1".Then it comes to the "n++" in "for()". So the character after "'x'" will be skipped, causing some errors. For example, "{"devid", no_argument, NULL, 'i'},", the "}" will be skipped, causing a lot of error reports. Now it's fixed. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-10-26 14:35:29 +02:00
n = endndx;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
break;
/* Check for space around various operators */
case '-':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
/* -> */
if (line[n + 1] == '>')
{
/* -> must have no whitespaces on its left or right */
check_nospaces_leftright(line, lineno, n, n + 1);
n++;
}
/* -- */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
else if (line[n + 1] == '-')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
/* "--" should be next to its operand. If there are
* whitespaces or non-operand characters on both left
nxstyle: cleanup UTF-8 Unicode to ASCII Signed-off-by: chao an <anchao@xiaomi.com>
2023-09-18 10:31:07 +02:00
* and right (e.g. "a -- ", "a[i --]", "(-- i)"),
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
* there's an error.
*/
check_operand_leftright(line, lineno, n, n + 1);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
n++;
}
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* -= */
else if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
tools/nxstyle.c: handle scientific notation with a negative exponent (eg. 9e-10)
2020-04-03 08:56:19 +02:00
/* Scientific notation with a negative exponent (eg. 10e-10)
* REVISIT: This fails for cases where the variable name
* ends with 'e' preceded by a digit:
* a = abc1e-10;
* a = ABC1E-10;
*/
else if ((line[n - 1] == 'e' || line[n - 1] == 'E') &&
isdigit(line[n + 1]) && isdigit(line[n - 2]))
{
n++;
}
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
else
{
/* '-' may function as a unary operator and snuggle
* on the left.
*/
check_spaces_left(line, lineno, n);
}
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
case '+':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* ++ */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '+')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
/* "++" should be next to its operand. If there are
* whitespaces or non-operand characters on both left
nxstyle: cleanup UTF-8 Unicode to ASCII Signed-off-by: chao an <anchao@xiaomi.com>
2023-09-18 10:31:07 +02:00
* and right (e.g. "a ++ ", "a[i ++]", "(++ i)"),
fix: nxstyle: detect --,->,++ not next to operand The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases. Signed-off-by: liucheng5 <liucheng5@xiaomi.com>
2021-09-10 11:44:41 +02:00
* there's an error.
*/
check_operand_leftright(line, lineno, n, n + 1);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
n++;
}
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* += */
else if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else
{
/* '+' may function as a unary operator and snuggle
* on the left.
*/
check_spaces_left(line, lineno, n);
}
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
case '&':
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* &<variable> OR &(<expression>) */
if (isalpha((int)line[n + 1]) || line[n + 1] == '_' ||
line[n + 1] == '(')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
/* &&, &= */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
else if (line[n + 1] == '=' || line[n + 1] == '&')
{
check_spaces_leftright(line, lineno, n, n + 1);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
n++;
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
case '/':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Check for missing space before closing comment faulty (#543) *Addresses Issue #540, check for missing space before closing comment was faulty
2020-03-11 18:08:01 +01:00
/* C comment terminator */
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
tools/nxstyle.c: Fix logic error that prevent detecion of '/' and '/=' as operators. net/: Minor updates resulting from testing tools/nxstyle.
2019-03-11 19:48:17 +01:00
if (line[n - 1] == '*')
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
{
tools/nxstyle.c: Fix logic error that prevent detecion of '/' and '/=' as operators. net/: Minor updates resulting from testing tools/nxstyle.
2019-03-11 19:48:17 +01:00
n++;
}
/* C++-style comment */
else if (line[n + 1] == '/')
{
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
/* Check for "http://" or "https://" */
if ((n < 5 || strncmp(&line[n - 5], "http://", 7) != 0) &&
(n < 6 || strncmp(&line[n - 6], "https://", 8) != 0))
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("C++ style comment on at %d:%d\n",
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
lineno, n);
}
tools/nxstyle.c: Fix logic error that prevent detecion of '/' and '/=' as operators. net/: Minor updates resulting from testing tools/nxstyle.
2019-03-11 19:48:17 +01:00
n++;
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
}
/* /= */
else if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
tools/nxstyle.c: Fix logic error that prevent detecion of '/' and '/=' as operators. net/: Minor updates resulting from testing tools/nxstyle.
2019-03-11 19:48:17 +01:00
/* Division operator */
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
else
{
check_spaces_leftright(line, lineno, n, n);
}
break;
case '*':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* *\/, ** */
if (line[n] == '*' &&
(line[n + 1] == '/' ||
line[n + 1] == '*'))
{
n++;
break;
}
/* *<variable>, *(<expression>) */
else if (isalpha((int)line[n + 1]) ||
line[n + 1] == '_' ||
line[n + 1] == '(')
{
break;
}
/* (<type> *) */
else if (line[n + 1] == ')')
{
/* REVISIT: This gives false alarms on syntax like *--ptr */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle: fix nxstyle check for pointer to function types Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
2021-11-25 06:06:35 +01:00
if (line[n - 1] != ' ' && line[n - 1] != '(')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Operator/assignment must be preceded "
"with whitespace", lineno, n);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
break;
}
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* *= */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
else if (line[n + 1] == '=')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
check_spaces_leftright(line, lineno, n, n + 1);
n++;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
else
{
/* A single '*' may be an binary operator, but
* it could also be a unary operator when used to deference
* a pointer.
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
check_spaces_left(line, lineno, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
case '%':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* %= */
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
case '<':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* <=, <<, <<= */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else if (line[n + 1] == '<')
{
if (line[n + 2] == '=')
{
check_spaces_leftright(line, lineno, n, n + 2);
n += 2;
}
else
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add a button upper/lower half driver
2015-10-12 22:29:43 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
case '>':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* >=, >>, >>= */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else if (line[n + 1] == '>')
{
if (line[n + 2] == '=')
{
check_spaces_leftright(line, lineno, n, n + 2);
n += 2;
}
else
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
case '|':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* |=, || */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else if (line[n + 1] == '|')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
case '^':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* ^= */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
case '=':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* == */
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
else
{
check_spaces_leftright(line, lineno, n, n);
}
Add a button upper/lower half driver
2015-10-12 22:29:43 +02:00
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
break;
case '~':
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
check_spaces_left(line, lineno, n);
break;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
case '!':
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* != */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
if (line[n + 1] == '=')
{
check_spaces_leftright(line, lineno, n, n + 1);
n++;
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix logic that detects if an operator is correctly delimited with spaces. sched/: Various changes because sched/ C files were used as Guinea Pigs to test nstyle.c.
2019-03-01 17:50:02 +01:00
/* !! */
else if (line[n + 1] == '!')
{
check_spaces_left(line, lineno, n);
n++;
}
else
{
check_spaces_left(line, lineno, n);
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
break;
default:
break;
}
}
}
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
/* Loop terminates when NUL or newline character found */
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
if (line[n] == '\n' || line[n] == '\0')
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
{
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
/* If the parse terminated on the NULL, then back up to the last
* character (which should be the newline).
*/
int m = n;
if (line[m] == '\0' && m > 0)
{
m--;
}
tools/nxstyle.c: Add detection of carriage returns. Improve reporting of TABs.
2019-10-23 20:49:27 +02:00
/* Check for space at the end of the line. Except for carriage
* returns which we have already reported (one time) above.
*/
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
if (m > 1 && isspace((int)line[m - 1]) &&
line[m - 1] != '\n' && line[m - 1] != '\r')
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
{
tools/nxstyle: fix wrong error reports for if statements * Fix nxstyle check so it does not report error on comments on the same line as if statements * Rework if statement checks * Report warning instead of error for is statements check fail
2024-08-26 15:00:01 +02:00
/* Report warning on if statement only is pnest is 0
* This takes into consideration the multiline if statement.
*/
if (bif == true && pnest == 0)
{
WARN("If statement followed by garbage", lineno, n);
}
ERROR("Dangling whitespace at the end of line", lineno, m);
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
}
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
/* The line width is determined by the location of the final
* asterisk in block comments. The closing line of the block
* comment will exceed that by one one character, the '/'
* following the final asterisk.
*/
else if (m > g_maxline)
{
bool bslash;
int a;
for (bslash = false, a = m;
a > 2 && strchr("\n\r/", line[a]) != NULL;
a--)
{
if (line[a] == '/')
{
bslash = true;
}
}
if (bslash && line[a] == '*')
{
m = a + 1;
}
}
/* Check for long lines
*
* REVISIT: Long line checks suppressed on right hand comments
* for now. This just prevents a large number of difficult-to-
* fix complaints that we would have otherwise.
*/
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
tools/nxstyle.c: Fix detection of long single line comments. This resolves issue 718: nxstyle line width check was ignoring the line width check for single line comments. This turned out to be an artifact in parsing. Usually when parsing character by character, the file character to be parsed was '/n'. Howefver, in the case of parsing single line comments, the final character was the NUL terminator. This means that the lenth check was not being performed in the case of single line comments. NOTE: Currently, I have suppressed error reports for single line right-hand comments. My fear is that this will unmask more standard violations than we can cope with. It is easy to re-enable and perhaps we should do that in the future: /* Check for long lines * * REVISIT: Long line checks suppressed on right hand comments * for now. This just prevents a large number of difficult-to- * fix complaints that we would have otherwise. */ if (m > g_maxline && !rhcomment) <-- remote the second condition
2020-04-06 20:02:29 +02:00
if (m > g_maxline && !rhcomment)
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
{
nxstyle: Ignore long line for file path at line 2 This patch fixes the issue reported by PR #12345 where the file path existent in the second line of each source file on NuttX. Sometimes the path could be too long and could raise a nxstyle issue during the CI test. Signed-off-by: Alan C. Assis <acassis@gmail.com>
2024-05-14 23:01:24 +02:00
/* Ignore the line 2 (file path) */
if (lineno == 2)
{
INFO("Skipping checking line 2: path file\n", 2, m);
}
else
{
ERROR("Long line found", lineno, m);
}
tools/nxstyle.c: Add logic to detect long lines.
2018-11-19 14:50:59 +01:00
}
tools/nxstyle.c: Fix detection of blank line at beginning for file. Fix detection of whitespace at the end of a line.
2018-10-30 23:33:41 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
/* STEP 4: Check alignment */
/* Within a comment block, we need only check on the alignment of the
* comment.
*/
if ((ncomment > 0 || prevncomment > 0) && !bstring)
{
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* Nothing should begin in comment zero */
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
if (indent == 0 && line[0] != '/' && !bexternc)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* NOTE: if this line contains a comment to the right of the
* code, then ncomment will be misleading because it was
* already incremented above.
*/
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
if (ncomment > 1 || rhcomment == 0)
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("No indentation line", lineno, indent);
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else if (indent == 1 && line[0] == ' ' && line[1] == '*')
{
/* Good indentation */
}
else if (indent > 0 && line[indent] == '\n')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Whitespace on blank line", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else if (indent > 0 && indent < 2)
{
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (bnest > 0)
Update README files.
2019-02-09 14:19:10 +01:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Insufficient indentation", lineno, indent);
Update README files.
2019-02-09 14:19:10 +01:00
}
else
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Expected indentation line", lineno, indent);
Update README files.
2019-02-09 14:19:10 +01:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else if (indent > 0 && !bswitch)
{
if (line[indent] == '/')
{
tools/nxstyle.c: Eliminate some false alarms related to comments to the right of code about alignment and spacing.
2019-12-01 18:37:30 +01:00
/* Comments should like at offsets 2, 6, 10, ...
* This rule is not followed, however, if the comments are
* aligned to the right of the code.
*/
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
if ((indent & 3) != 2 && rhcomment == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad comment alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
/* REVISIT: This screws up in cases where there is C code,
* followed by a comment that continues on the next line.
*/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
else if (line[indent + 1] != '*')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing asterisk in comment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
else if (line[indent] == '*')
{
/* REVISIT: Generates false alarms on comments at the end of
* the line if there is nothing preceding (such as the aligned
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
* comments with a structure field definition). So disabled
* for comments before beginning of function definitions.
tools/nxstyle.c: Eliminate false alarm errors on comments that are to the right of code when the comment terminator is on the same line as the last of the comment.
2019-10-25 20:34:42 +02:00
*
nxstyle:nxstyle should pass nxstyle checks!
2020-03-07 14:35:08 +01:00
* Suppress this error if this is a comment to the right of
* code.
tools/nxstyle.c: Eliminate false alarms when checking for alignment of comments to the right of code. Fix check for C++ style comments so that strings like http:// and https:// do not generate false alarms.
2019-10-27 18:45:33 +01:00
* Those may be unaligned.
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
*/
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
if ((indent & 3) != 3 && bfunctions && dnest == 0 &&
Changes to nxstyle which address issue #120 and add checks for column position of right of code comments
2020-03-08 20:02:51 +01:00
rhcomment == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad comment block alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
tools/nxstyle.c: Eliminate false positive 'Invalid character after asterisk in comment block'.
2019-11-09 19:10:22 +01:00
if (line[indent + 1] != ' ' &&
line[indent + 1] != '*' &&
line[indent + 1] != '\n' &&
line[indent + 1] != '/')
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Invalid character after asterisk "
"in comment block", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
/* If this is not the line containing the comment start, then this
* line should begin with '*'
*/
else if (prevncomment > 0)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Missing asterisk in comment block", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
}
/* Check for various alignment outside of the comment block */
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
else if ((ncomment == 0 && prevncomment == 0) && !bstring)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
if (indent == 0 && strchr("\n#{}", line[0]) == NULL)
{
/* Ignore if we are at global scope */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
if (prevbnest > 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
bool blabel = false;
if (isalpha((int)line[indent]))
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
for (i = indent + 1; isalnum((int)line[i]) ||
line[i] == '_'; i++);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
blabel = (line[i] == ':');
}
tools/nxstyle.c: No warning for declarations that begin in column 1 within 'extern "C"'. This is because the 'extern "C"' is conditioned on __cplusplus so the declarations are not normally indented.
2019-06-30 23:10:14 +02:00
if (!blabel && !bexternc)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("No indentation line", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
}
else if (indent == 1 && line[0] == ' ' && line[1] == '*')
{
/* Good indentation */
}
else if (indent > 0 && line[indent] == '\n')
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Whitespace on blank line", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else if (indent > 0 && indent < 2)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Insufficient indentation line", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
else if (line[indent] == '{')
{
tools/nxstyle.c: Add logic to detect check for left brace in first column, but preceded by a blank line. That should never happen for the outermost opening branch (but could happen with internal compound statements). Consider junk.c for example: /**************************************************************************** * xx ****************************************************************************/ /**************************************************************************** * Private Types ****************************************************************************/ struct foo_s { int bar; }; /**************************************************************************** * Public Functions ****************************************************************************/ int dofoo(int barin) { barout = barin; return barout; } nxstyle not detects these problems: $ tools/nxstyle.exe junk.c junk.c:11:0: error: Blank line before opening left brace junk.c:21:0: error: Blank line before opening left brace
2020-01-28 16:17:49 +01:00
/* Check for left brace in first column, but preceded by a
* blank line. Should never happen (but could happen with
* internal compound statements).
*/
if (indent == 0 && lineno == blank_lineno + 1)
{
ERROR("Blank line before opening left brace", lineno, indent);
}
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
/* REVISIT: Possible false alarms in compound statements
* without a preceding conditional. That usage often violates
* the coding standard.
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Add logic to detect check for left brace in first column, but preceded by a blank line. That should never happen for the outermost opening branch (but could happen with internal compound statements). Consider junk.c for example: /**************************************************************************** * xx ****************************************************************************/ /**************************************************************************** * Private Types ****************************************************************************/ struct foo_s { int bar; }; /**************************************************************************** * Public Functions ****************************************************************************/ int dofoo(int barin) { barout = barin; return barout; } nxstyle not detects these problems: $ tools/nxstyle.exe junk.c junk.c:11:0: error: Blank line before opening left brace junk.c:21:0: error: Blank line before opening left brace
2020-01-28 16:17:49 +01:00
else if (!bfunctions && (indent & 1) != 0)
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad left brace alignment", lineno, indent);
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
}
else if ((indent & 3) != 0 && !bswitch && dnest == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad left brace alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
else if (line[indent] == '}')
{
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
/* REVISIT: Possible false alarms in compound statements
* without a preceding conditional. That usage often violates
* the coding standard.
*/
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
if (!bfunctions && (indent & 1) != 0)
{
nxstyle: Fix typos in reported errors. Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
2021-04-01 08:38:17 +02:00
ERROR("Bad left brace alignment", lineno, indent);
tools/nxstyle.c: Fix error in conditional logic that was preventing detection bad brace alignment. Add logic to handle alignment of braces in data initializators which following slightly different indentation rules.
2019-06-30 18:35:10 +02:00
}
else if ((indent & 3) != 0 && !bswitch && prevdnest == 0)
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad right brace alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
else if (indent > 0)
{
/* REVISIT: Generates false alarms when a statement continues on
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
* the next line. The bstatm check limits to lines beginning
* with C keywords.
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* REVISIT: The bstatm check will not detect statements that
Fix some new warnings found in build testing.
2019-06-29 21:24:38 +02:00
* do not begin with a C keyword (such as assignment statements).
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* REVISIT: Generates false alarms on comments at the end of
* the line if there is nothing preceding (such as the aligned
* comments with a structure field definition). So disabled for
* comments before beginning of function definitions.
*/
if ((bstatm || /* Begins with C keyword */
tools/nxstyle: Fix the check tool incorrectly reported no alignment. The nxstyle check tool recognizes the division operator as a comment. Check the following content to determine whether it is a comment. Change-Id: Id07c6668489895b45a1042794bc3acca66cd3c47 Signed-off-by: yangjiukui <yangjiukui@xiaomi.com>
2021-09-07 05:20:23 +02:00
(line[indent] == '/' &&
bfunctions &&
line[indent + 1] == '*')) && /* Comment in functions */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
!bswitch && /* Not in a switch */
tools/nxstyle.c: Beef up logic that detects multiple variable definitions per line.
2019-02-17 17:57:28 +01:00
dnest == 0) /* Not a data definition */
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
{
if ((indent & 3) != 2)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Bad alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
tools/nxstyle.c: Bandaid-up logic that detects left brackets on the same line in global structure/enumeration types and initializers.
2019-06-30 00:19:10 +02:00
/* Crazy cases. There should be no small odd alignments
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
* outside of comment/string. Odd alignments are possible
* on continued lines, but not if they are small.
*/
else if (indent == 1 || indent == 3)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Small odd alignment", lineno, indent);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
}
}
}
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
if (!bfunctions && g_file_type == C_SOURCE)
tools/nxstyle.c: Tool depends on the file under test containing "Private Functions" or "Public Functions" block comments. Emit an error is neither are present.
2019-06-29 19:43:37 +02:00
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("\"Private/Public Functions\" not found!"
nxstyle: Fix typos in reported errors. Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
2021-04-01 08:38:17 +02:00
" File will not be checked", lineno, 1);
tools/nxstyle.c: Tool depends on the file under test containing "Private Functions" or "Public Functions" block comments. Emit an error is neither are present.
2019-06-29 19:43:37 +02:00
}
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
if (ncomment > 0 || bstring)
{
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
ERROR("Comment or string found at end of file", lineno, 1);
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
fclose(instream);
nxstyle improvements with No tooling (#12) tools/nxstyle.c: Output compiler like error format. Added features Uses getops to pars command line. Supports -s silence all output -g provide a PASS fail message * tools/README.txt: Update with new nxstyle options
2019-12-30 19:34:43 +01:00
if (g_verbose == 1)
{
fprintf(stderr, "%s: %s nxstyle check\n", g_file_name,
g_status == 0 ? "PASSED" : "FAILED");
}
return g_status;
Add toosl/nxstyle.c
2015-10-08 20:48:40 +02:00
}
Reference in New Issue Copy Permalink