Commit Graph

33204 Commits

Author SHA1 Message Date
Pascal Birchler d92ead50c8 Ensure `wp_get_referer()` returns `false` when the referrer URL is the current URL.
Adds unit tests.

Fixes #19856.

git-svn-id: https://develop.svn.wordpress.org/trunk@36242 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:35:03 +00:00
swissspidy 0002ff515b Media: After [36240], remove some unneeded whitespace.
Props ocean90.
See #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36241 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:28:02 +00:00
Pascal Birchler 54134dd49b Media: Fix `wp_audio_shortcode` and `wp_video_shortcode` attributes handling.
Although documented, the `class` and `style` attributes were simply ignored.
Adds unit tests.

Fixes #35367.

git-svn-id: https://develop.svn.wordpress.org/trunk@36240 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 14:17:02 +00:00
Dion Hulse 0e73cc3da4 Tests: Add more paged canonical tests for page_on_front.
See #35344.


git-svn-id: https://develop.svn.wordpress.org/trunk@36238 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 08:08:47 +00:00
Dion Hulse 3cce67f8bc Canonical: Generate the correct canonical url for paged posts/pages when they're used as the page_on_front.
This fixes an issue where pages become inacessible on a front page post.

Fixes #35344 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36237 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 07:32:42 +00:00
Dion Hulse 5f55910b5c Tests: Remove some debug that's slipped in at some point.
git-svn-id: https://develop.svn.wordpress.org/trunk@36236 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 06:11:58 +00:00
Boone Gorges 530ffc712f Introduce `comments_template_query_args` filter.
This new filter gives developers a way to target the arguments used for comment
queries specifically when populating the main comment template.

Props birgire.
Fixes #34442.

git-svn-id: https://develop.svn.wordpress.org/trunk@36235 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 04:43:33 +00:00
Boone Gorges 32194797d5 Clarify return types in `get_option()` documentation.
The new note specifies that scalar values will always be returned as strings.

Fixes #31820.

git-svn-id: https://develop.svn.wordpress.org/trunk@36234 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 03:11:59 +00:00
Andrew Ozz 3fba1e59d7 Media: fix undefined error that prevents showing a preview in the media modal when replacing video or audio.
Fixes #35363.

git-svn-id: https://develop.svn.wordpress.org/trunk@36233 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 02:21:28 +00:00
John Blackbourn 021401424b Docs: `@param` fixes for a variety of docblocks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36232 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:44:31 +00:00
John Blackbourn aaa61e80e4 Docs: Correct the parameter docs for various Heartbeat filters and functions.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36231 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:36:45 +00:00
John Blackbourn 5b2c1a52cc Feeds: Remove the `rss-http` feed type, unused since r32468.
See #15110


git-svn-id: https://develop.svn.wordpress.org/trunk@36230 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:19:31 +00:00
Eric Andrew Lewis 75cc6be57a Add documentation for parseData() and ajaxDel() in wp-lists.js.
Fixes #35360.


git-svn-id: https://develop.svn.wordpress.org/trunk@36229 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 00:04:57 +00:00
Eric Andrew Lewis 5c7043593b Cron: Add the cron lock timestamp to the 'cron_request' filter arguments.
Fixes #31307


git-svn-id: https://develop.svn.wordpress.org/trunk@36228 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 23:53:10 +00:00
Boone Gorges ca642a8562 Use a more generous selector when setting up tag suggestion.
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.

Props johnjamesjacoby..
Fixes #35349.

git-svn-id: https://develop.svn.wordpress.org/trunk@36227 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 23:17:21 +00:00
Boone Gorges 8dbc62d267 In `comments_template()`, don't run hierarchical queries if comment threading is disabled.
When hierarchical=true, `WP_Comment_Query` will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.

We address the issue by refraining from querying hierarchically when comment
threading is disabled.

Props jmdodd.
Fixes #35378.

git-svn-id: https://develop.svn.wordpress.org/trunk@36226 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 22:16:11 +00:00
Eric Andrew Lewis 5304745be0 Permalinks: Make `get_post_type_archive_link()` work for the 'post' post type.
Props jjj.
See #19902. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36225 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 22:00:48 +00:00
Boone Gorges b5a4504f7e Introduce 'author_url' param to `WP_Comment_Query`.
Props swissspidy.
Fixes #35377.

git-svn-id: https://develop.svn.wordpress.org/trunk@36224 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 21:51:50 +00:00
Andrea Fercia 05934ebd87 Media: make the Image Editor usable with a keyboard.
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.

Fixes #28864.

git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:12:11 +00:00
Andrea Fercia fa998d9b8c Accessibility: remove the title attribute from the `get_search_form()` HTML5 search field.
It was added in [23801] as a workaround for issues with very old browser/screen reader combos (Jaws7/IE6).
No more necessary today. Reduces redundancy and noise for screen reader users.

See #16539.
Fixes #33952.

git-svn-id: https://develop.svn.wordpress.org/trunk@36222 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 19:00:39 +00:00
Konstantin Obenland e4b8679d17 Plugins: Use plugin file rather than slug as identifier
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.

See [36205].
Fixes #35350.



git-svn-id: https://develop.svn.wordpress.org/trunk@36221 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 17:47:18 +00:00
Dion Hulse 9fc247408c Update to Random_Compat 1.1.5 to fix an issue with older libSodium modules.
Props sarciszewski.
Fixes #35327 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36220 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-08 03:27:58 +00:00
Weston Ruter de5f72567a Customizer: Improve `_doing_it_wrong()` message when `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.

Amends [36216].
Props DrewAPicture.
Fixes #35242.


git-svn-id: https://develop.svn.wordpress.org/trunk@36219 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 18:43:11 +00:00
Pascal Birchler 1f47f9c5f5 Tests: Fix unit tests after [36217].
See #35236.

git-svn-id: https://develop.svn.wordpress.org/trunk@36218 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 10:16:47 +00:00
Pascal Birchler 79f2e50ca5 Rewrite: Add a `remove_rewrite_tag()` helper function.
It can be used to properly remove registered rewrite tags. Adds unit tests.

Fixes #35236.

git-svn-id: https://develop.svn.wordpress.org/trunk@36217 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 09:38:06 +00:00
Weston Ruter e5707af429 Customizer: Call `_doing_it_wrong()` if `widgets` or `nav_menus` are manually removed via `WP_Customize_Manager::remove_panel()`.
Advise that the `customize_loaded_components` filter should be used instead.

Props voldemortensen.
See #33552.
Fixes #35242.


git-svn-id: https://develop.svn.wordpress.org/trunk@36216 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 06:05:07 +00:00
Boone Gorges e49c8b425c Allow comment agent and author IP to be set via `wp_update_comment()`.
Props adamsilverstein, welcher.
Fixes #35276.

git-svn-id: https://develop.svn.wordpress.org/trunk@36215 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 03:54:05 +00:00
Boone Gorges 3a9bc32949 Ensure 'description' is a string in `wp_insert_term()`.
Passing `'description' => null` when creating a term can cause MySQL notices,
as the description column in the terms table does not allow for null values.
We correct this by intepreting a `null` description as an empty string.

Props TimothyBlynJacobs.
Fixes #35321.

git-svn-id: https://develop.svn.wordpress.org/trunk@36214 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 03:31:48 +00:00
Konstantin Obenland c67abd1c66 Plugins: Avoid ID attribute collisions in plugins list table.
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.

Props khag7.
Fixes #18974.



git-svn-id: https://develop.svn.wordpress.org/trunk@36205 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:39:23 +00:00
Konstantin Obenland 58b35571bb Themes: Avoid changing the count of themes with updates in network admin.
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.

See [29786], [31495].
Fixes #35332.



git-svn-id: https://develop.svn.wordpress.org/trunk@36204 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:31:46 +00:00
Aaron Jorbin 9e91f753f8 Theme: Escape error messages
git-svn-id: https://develop.svn.wordpress.org/trunk@36185 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 17:22:08 +00:00
Dion Hulse 549c4fdd1d Unit Tests: Fix the unit test added in [36181] to include the index in the comparison.
See #35235


git-svn-id: https://develop.svn.wordpress.org/trunk@36183 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 08:09:51 +00:00
Dion Hulse 3e85247571 Updates: Don't perform an API call to WordPress.org for every plugin update displayed. The API has been updated to return this information with the update response.
See #35301


git-svn-id: https://develop.svn.wordpress.org/trunk@36182 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 07:52:53 +00:00
Pascal Birchler e055e5b80e Rewrite: Add a `remove_permastruct()` helper function.
It can be used to remove permastructs that were added using `add_permastruct()`.

Fixes #35235.

git-svn-id: https://develop.svn.wordpress.org/trunk@36181 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 07:39:29 +00:00
Dion Hulse ce4ef49b10 Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
See #27772, #35323.


git-svn-id: https://develop.svn.wordpress.org/trunk@36180 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 06:11:46 +00:00
Dominik Schilling (ocean90) cd6cc5c7db Bundled Themes: Bump version number of Twenty Thirteen.
Props davidakennedy.
Fixes #35319.

git-svn-id: https://develop.svn.wordpress.org/trunk@36179 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 22:19:41 +00:00
Dominik Schilling (ocean90) 36cf8b2932 Install: Use new colors for error notices.
Props duaneblake, DBrumbaugh10Up.
Fixes #34704.

git-svn-id: https://develop.svn.wordpress.org/trunk@36178 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 21:46:29 +00:00
Pascal Birchler e50296de48 Query: Add a `WP::remove_query_var()` helper function.
This makes cleaning up public query vars easier.

Fixes #35234.

git-svn-id: https://develop.svn.wordpress.org/trunk@36177 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 20:56:10 +00:00
Dominik Schilling (ocean90) e306e801a9 Install: Only enqueue scripts when necessary.
Props flixos90 for initial patch.
Fixes #34700.

git-svn-id: https://develop.svn.wordpress.org/trunk@36176 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:41:43 +00:00
Dominik Schilling (ocean90) 9d45966095 Docs: Move the hook doc for the `the_title` filter in `Walker_Page::start_el()` to directly precede the `apply_filters()` line.
See #32246.

git-svn-id: https://develop.svn.wordpress.org/trunk@36175 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:34:25 +00:00
Dominik Schilling (ocean90) 3f5fab4a0e Nav Menus: Apply the `the_title` filter on original post titles in `wp_setup_nav_menu_item()`.
The filter is already used in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit`. This ensures that titles are consistent across the admin and front end.

Fixes #35317.

git-svn-id: https://develop.svn.wordpress.org/trunk@36174 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:26:53 +00:00
Rachel Baker 693a5b793f Comments: Remove orphaned closing `td` tag within cancel button of Moderate Comment screen.
Left behind in r31641. See #23988.

Props ash.matadeen.


git-svn-id: https://develop.svn.wordpress.org/trunk@36173 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:06:54 +00:00
Andrea Fercia 0eba218570 Accessibility: Remove title attributes from the Admin Dashboard.
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.

Fixes #35049.

git-svn-id: https://develop.svn.wordpress.org/trunk@36172 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 14:18:57 +00:00
Andrea Fercia 3a9259a4c4 Introduce a new generic CSS clearfix utility class.
`.wp-clearfix` is now the recommended way to clear and contain floated elements.
Adds back compatibility for the `.nav-tab-wrapper` navigation tabs.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36171 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 13:37:56 +00:00
Konstantin Obenland 0d6514b28b Template: Always display the site title on the front page.
Limits using the page title to the blog page when the site has a static front page,
bringing it N’Sync with `wp_title()`.

Props peterwilsoncc.
Fixes #34962.



git-svn-id: https://develop.svn.wordpress.org/trunk@36168 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-04 17:15:31 +00:00
Andrew Ozz f891bb32f2 Media: when inserting an attachment in the editor and it is not an image, ensure the link is set to something else than `none`.
Props eherman24, azaozz.
Fizes #35153 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36166 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-04 00:32:56 +00:00
Andrew Nacin 5699c64a56 XML-RPC: Revert [34681] as it broke date handling.
props dossy, hnle, redsweater.
see #35053, #30429 (original ticket).


git-svn-id: https://develop.svn.wordpress.org/trunk@36163 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 19:48:07 +00:00
Andrea Fercia a12087bf0f Media: set the image editor spinner on the smallest possible area.
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196, #33311, #33322, and #34951.

Fixes #35296.

git-svn-id: https://develop.svn.wordpress.org/trunk@36162 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 16:48:47 +00:00
Gary Pendergast 59d442f921 Emoji: Add a test to the emoji loader, to see if the browser supports emoji diversity. If it doesn't, fall back to twemoji.
See #33592.



git-svn-id: https://develop.svn.wordpress.org/trunk@36160 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 04:25:52 +00:00
Boone Gorges 23b10789d4 Fix incorrect `@covers` annotation in `get_adjacent_post()` tests.
Introduced in [36077].

Props netweb.
Fixes #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36159 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 02:43:18 +00:00